From: Hugo Villeneuve <hugo@hugovil.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
ilpo.jarvinen@linux.intel.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v2 08/15] serial: earlycon: use uart_iotype_*() to simplify code
Date: Mon, 4 May 2026 11:40:01 -0400 [thread overview]
Message-ID: <20260504114001.a20541e974060c6fe2f26ba1@hugovil.com> (raw)
In-Reply-To: <afNvR59jmKu3-CoF@black.igk.intel.com>
On Thu, 30 Apr 2026 17:03:35 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Tue, Apr 28, 2026 at 01:53:54PM -0400, Hugo Villeneuve wrote:
>
> > Make use of new functions uart_iotype_mmio() and uart_iotype_legacy_io()
> > to simplify and improve code readability.
>
> ...
>
> > + char address[64] = "";
>
> TBH, I prefer two pr_info() calls as that approach
> - doesn't require temporary buffer
> - doesn't use heavy s*printf() on top of the existing printing
> - doesn't limit the flexibility of each of the strings (64 might
> become not enough in some cases, however unlikely to happen)
Note that this approach is already used in uart_report_port().
Also this patch may be reworked if patch "serial: uniformize serial
port I/O infos display" is deemed ok...
--
Hugo Villeneuve
next prev parent reply other threads:[~2026-05-04 15:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 17:53 [PATCH v2 00/15] serial: add new I/O type for SPI and I2C bus devices Hugo Villeneuve
2026-04-28 17:53 ` [PATCH v2 01/15] serial: 8250_hub6: add hub6_match_port() Hugo Villeneuve
2026-04-28 17:53 ` [PATCH v2 02/15] serial: core: add uart_iotype_mmio/legacy_io helper functions Hugo Villeneuve
2026-04-30 15:08 ` Andy Shevchenko
2026-04-30 15:30 ` Hugo Villeneuve
2026-05-01 11:48 ` Andy Shevchenko
2026-05-02 23:25 ` Maciej W. Rozycki
2026-05-04 8:48 ` Andy Shevchenko
2026-05-04 11:44 ` Maciej W. Rozycki
2026-05-04 14:30 ` Andy Shevchenko
2026-05-04 15:20 ` Maciej W. Rozycki
2026-05-04 15:59 ` Andy Shevchenko
2026-04-28 17:53 ` [PATCH v2 03/15] serial: core: use uart_iotype_*() to simplify uart_match_port() Hugo Villeneuve
2026-04-28 17:53 ` [PATCH v2 04/15] serial: core: use uart_iotype_*() to simplify uart_line_info() Hugo Villeneuve
2026-04-28 17:53 ` [PATCH v2 05/15] serial: core: replace snprintf with more robust scnprintf Hugo Villeneuve
2026-04-30 15:07 ` Andy Shevchenko
2026-05-04 15:27 ` Hugo Villeneuve
2026-05-04 15:59 ` Andy Shevchenko
2026-04-28 17:53 ` [PATCH v2 06/15] serial: core: fix indentation/alignment Hugo Villeneuve
2026-04-28 17:53 ` [PATCH v2 07/15] serial: core: use uart_iotype_*() to simplify uart_report_port() Hugo Villeneuve
2026-04-28 17:53 ` [PATCH v2 08/15] serial: earlycon: use uart_iotype_*() to simplify code Hugo Villeneuve
2026-04-30 15:03 ` Andy Shevchenko
2026-05-04 15:40 ` Hugo Villeneuve [this message]
2026-05-04 16:01 ` Andy Shevchenko
2026-04-28 17:53 ` [PATCH v2 09/15] serial: 8250: " Hugo Villeneuve
2026-04-28 17:53 ` [PATCH v2 10/15] serial: 8250_rsa: " Hugo Villeneuve
2026-04-28 17:53 ` [PATCH v2 11/15] serial: core: add new I/O type for SPI and I2C bus devices Hugo Villeneuve
2026-04-28 17:53 ` [PATCH v2 12/15] serial: sc16is7xx: use new UPIO_BUS as iotype Hugo Villeneuve
2026-04-28 17:53 ` [PATCH v2 13/15] serial: max310x: " Hugo Villeneuve
2026-04-28 17:54 ` [PATCH v2 14/15] serial: max3100: " Hugo Villeneuve
2026-04-28 17:54 ` [PATCH v2 15/15] serial: uniformize serial port I/O infos display Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504114001.a20541e974060c6fe2f26ba1@hugovil.com \
--to=hugo@hugovil.com \
--cc=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox