From: kernel test robot <lkp@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_fsl: Export fsl8250_handle_irq() conditionally
Date: Mon, 11 May 2026 20:54:12 +0800 [thread overview]
Message-ID: <202605112003.uLqRrYzE-lkp@intel.com> (raw)
In-Reply-To: <20260504151259.483924-1-andriy.shevchenko@linux.intel.com>
Hi Andy,
kernel test robot noticed the following build errors:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus linus/master v7.1-rc3 next-20260508]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/serial-8250_fsl-Export-fsl8250_handle_irq-conditionally/20260511-115924
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/20260504151259.483924-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] serial: 8250_fsl: Export fsl8250_handle_irq() conditionally
config: microblaze-defconfig (https://download.01.org/0day-ci/archive/20260511/202605112003.uLqRrYzE-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260511/202605112003.uLqRrYzE-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605112003.uLqRrYzE-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/tty/serial/8250/8250_of.c: In function 'of_platform_serial_setup':
>> drivers/tty/serial/8250/8250_of.c:187:36: error: 'fsl8250_handle_irq' undeclared (first use in this function); did you mean 'serial8250_handle_irq'?
187 | port->handle_irq = fsl8250_handle_irq;
| ^~~~~~~~~~~~~~~~~~
| serial8250_handle_irq
drivers/tty/serial/8250/8250_of.c:187:36: note: each undeclared identifier is reported only once for each function it appears in
vim +187 drivers/tty/serial/8250/8250_of.c
32f6ec282fb0ddb drivers/tty/serial/8250/8250_of.c Bastien Curutchet 2024-04-05 83
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 84 /*
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 85 * Fill a struct uart_port for a given device node
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 86 */
9671f09921d93e7 drivers/tty/serial/of_serial.c Bill Pemberton 2012-11-19 87 static int of_platform_serial_setup(struct platform_device *ofdev,
058bc104f7ca5c8 drivers/tty/serial/8250/8250_of.c Lukas Wunner 2020-02-28 88 int type, struct uart_8250_port *up,
0bbeb3c3e84bc96 drivers/tty/serial/of_serial.c Murali Karicheri 2012-10-22 89 struct of_serial_info *info)
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 90 {
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 91 struct resource resource;
4678de73932f8f3 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2023-09-12 92 struct device *dev = &ofdev->dev;
4678de73932f8f3 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2023-09-12 93 struct device_node *np = dev->of_node;
058bc104f7ca5c8 drivers/tty/serial/8250/8250_of.c Lukas Wunner 2020-02-28 94 struct uart_port *port = &up->port;
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 95 u32 spd;
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 96 int ret;
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 97
d3210c8e88ee413 drivers/tty/serial/8250/8250_of.c jempty.liang 2025-11-17 98 memset(port, 0, sizeof(*port));
a2d23edaef9e022 drivers/tty/serial/8250/8250_of.c Franklin S Cooper Jr 2017-08-16 99
a2d23edaef9e022 drivers/tty/serial/8250/8250_of.c Franklin S Cooper Jr 2017-08-16 100 pm_runtime_enable(&ofdev->dev);
a2d23edaef9e022 drivers/tty/serial/8250/8250_of.c Franklin S Cooper Jr 2017-08-16 101 pm_runtime_get_sync(&ofdev->dev);
a2d23edaef9e022 drivers/tty/serial/8250/8250_of.c Franklin S Cooper Jr 2017-08-16 102
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 103 ret = of_address_to_resource(np, 0, &resource);
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 104 if (ret) {
4678de73932f8f3 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2023-09-12 105 dev_err_probe(dev, ret, "invalid address\n");
aef6b8631f9ddf2 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2023-09-19 106 goto err_pmruntime;
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 107 }
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 108
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 109 port->dev = &ofdev->dev;
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 110 port->flags = UPF_BOOT_AUTOCONF | UPF_FIXED_PORT | UPF_FIXED_TYPE;
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 111 spin_lock_init(&port->lock);
aa95947400edb57 drivers/tty/serial/8250/8250_of.c John Garry 2018-04-27 112
aa95947400edb57 drivers/tty/serial/8250/8250_of.c John Garry 2018-04-27 113 if (resource_type(&resource) == IORESOURCE_IO) {
aa95947400edb57 drivers/tty/serial/8250/8250_of.c John Garry 2018-04-27 114 port->iobase = resource.start;
aa95947400edb57 drivers/tty/serial/8250/8250_of.c John Garry 2018-04-27 115 } else {
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 116 port->mapbase = resource.start;
0787691230d88af drivers/tty/serial/of_serial.c Mans Rullgard 2015-03-08 117 port->mapsize = resource_size(&resource);
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 118 port->flags |= UPF_IOREMAP;
d06b1cf28297e27 drivers/tty/serial/8250/8250_of.c Robert Hancock 2022-01-12 119 }
d06b1cf28297e27 drivers/tty/serial/8250/8250_of.c Robert Hancock 2022-01-12 120
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 121 ret = uart_read_and_validate_port_properties(port);
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 122 if (ret)
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 123 goto err_pmruntime;
b912b5e2cfb35c0 drivers/serial/of_serial.c John Linn 2008-04-03 124
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 125 /* Get clk rate through clk driver if present */
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 126 if (!port->uartclk) {
81e4de4ba298d73 drivers/tty/serial/8250/8250_of.c Alex Elder 2025-04-09 127 struct clk *bus_clk;
81e4de4ba298d73 drivers/tty/serial/8250/8250_of.c Alex Elder 2025-04-09 128
81e4de4ba298d73 drivers/tty/serial/8250/8250_of.c Alex Elder 2025-04-09 129 bus_clk = devm_clk_get_optional_enabled(dev, "bus");
81e4de4ba298d73 drivers/tty/serial/8250/8250_of.c Alex Elder 2025-04-09 130 if (IS_ERR(bus_clk)) {
81e4de4ba298d73 drivers/tty/serial/8250/8250_of.c Alex Elder 2025-04-09 131 ret = dev_err_probe(dev, PTR_ERR(bus_clk), "failed to get bus clock\n");
81e4de4ba298d73 drivers/tty/serial/8250/8250_of.c Alex Elder 2025-04-09 132 goto err_pmruntime;
81e4de4ba298d73 drivers/tty/serial/8250/8250_of.c Alex Elder 2025-04-09 133 }
81e4de4ba298d73 drivers/tty/serial/8250/8250_of.c Alex Elder 2025-04-09 134
81e4de4ba298d73 drivers/tty/serial/8250/8250_of.c Alex Elder 2025-04-09 135 /* If the bus clock is required, core clock must be named */
81e4de4ba298d73 drivers/tty/serial/8250/8250_of.c Alex Elder 2025-04-09 136 info->clk = devm_clk_get_enabled(dev, bus_clk ? "core" : NULL);
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 137 if (IS_ERR(info->clk)) {
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 138 ret = dev_err_probe(dev, PTR_ERR(info->clk), "failed to get clock\n");
aef6b8631f9ddf2 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2023-09-19 139 goto err_pmruntime;
7423734e19e7e0a drivers/tty/serial/of_serial.c Jamie Iles 2011-06-27 140 }
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 141
926040da6064233 drivers/tty/serial/8250/8250_of.c Alex Elder 2025-04-11 142 info->bus_clk = bus_clk;
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 143 port->uartclk = clk_get_rate(info->clk);
7423734e19e7e0a drivers/tty/serial/of_serial.c Jamie Iles 2011-06-27 144 }
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 145 /* If current-speed was set, then try not to change it. */
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 146 if (of_property_read_u32(np, "current-speed", &spd) == 0)
1117a6fdc7c14d6 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-03-04 147 port->custom_divisor = port->uartclk / (16 * spd);
aa95947400edb57 drivers/tty/serial/8250/8250_of.c John Garry 2018-04-27 148
f4817843e39ce78 drivers/tty/serial/8250/8250_of.c Lubomir Rintel 2019-02-24 149 /* Compatibility with the deprecated pxa driver and 8250_pxa drivers. */
f4817843e39ce78 drivers/tty/serial/8250/8250_of.c Lubomir Rintel 2019-02-24 150 if (of_device_is_compatible(np, "mrvl,mmp-uart"))
f4817843e39ce78 drivers/tty/serial/8250/8250_of.c Lubomir Rintel 2019-02-24 151 port->regshift = 2;
f4817843e39ce78 drivers/tty/serial/8250/8250_of.c Lubomir Rintel 2019-02-24 152
e2860e1f62f2e87 drivers/tty/serial/8250/8250_of.c Joel Stanley 2017-05-29 153 info->rst = devm_reset_control_get_optional_shared(&ofdev->dev, NULL);
b9820a31691b771 drivers/tty/serial/8250/8250_of.c Masahiro Yamada 2017-12-27 154 if (IS_ERR(info->rst)) {
b9820a31691b771 drivers/tty/serial/8250/8250_of.c Masahiro Yamada 2017-12-27 155 ret = PTR_ERR(info->rst);
aef6b8631f9ddf2 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2023-09-19 156 goto err_pmruntime;
b9820a31691b771 drivers/tty/serial/8250/8250_of.c Masahiro Yamada 2017-12-27 157 }
b9820a31691b771 drivers/tty/serial/8250/8250_of.c Masahiro Yamada 2017-12-27 158
e2860e1f62f2e87 drivers/tty/serial/8250/8250_of.c Joel Stanley 2017-05-29 159 ret = reset_control_deassert(info->rst);
e2860e1f62f2e87 drivers/tty/serial/8250/8250_of.c Joel Stanley 2017-05-29 160 if (ret)
aef6b8631f9ddf2 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2023-09-19 161 goto err_pmruntime;
e2860e1f62f2e87 drivers/tty/serial/8250/8250_of.c Joel Stanley 2017-05-29 162
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 163 port->type = type;
283e096ffb7077c drivers/tty/serial/8250/8250_of.c Lukas Wunner 2020-02-28 164 port->rs485_config = serial8250_em485_config;
0139da50dc53f0c drivers/tty/serial/8250/8250_of.c Ilpo Järvinen 2022-07-04 165 port->rs485_supported = serial8250_em485_supported;
058bc104f7ca5c8 drivers/tty/serial/8250/8250_of.c Lukas Wunner 2020-02-28 166 up->rs485_start_tx = serial8250_em485_start_tx;
058bc104f7ca5c8 drivers/tty/serial/8250/8250_of.c Lukas Wunner 2020-02-28 167 up->rs485_stop_tx = serial8250_em485_stop_tx;
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 168
9b8777e3473e31b drivers/tty/serial/of_serial.c John Crispin 2014-10-16 169 switch (type) {
9b8777e3473e31b drivers/tty/serial/of_serial.c John Crispin 2014-10-16 170 case PORT_RT2880:
b334214ea08d941 drivers/tty/serial/8250/8250_of.c Ilpo Järvinen 2023-05-11 171 ret = rt288x_setup(port);
cd0eb354d441488 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-02-15 172 break;
cd0eb354d441488 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-02-15 173 case PORT_NPCM:
cd0eb354d441488 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-02-15 174 ret = npcm_setup(port);
cd0eb354d441488 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-02-15 175 break;
cd0eb354d441488 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-02-15 176 default:
cd0eb354d441488 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-02-15 177 /* Nothing to do */
cd0eb354d441488 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-02-15 178 ret = 0;
9b8777e3473e31b drivers/tty/serial/of_serial.c John Crispin 2014-10-16 179 break;
9b8777e3473e31b drivers/tty/serial/of_serial.c John Crispin 2014-10-16 180 }
cd0eb354d441488 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-02-15 181 if (ret)
cd0eb354d441488 drivers/tty/serial/8250/8250_of.c Andy Shevchenko 2024-02-15 182 goto err_pmruntime;
bf03f65b7967df5 drivers/tty/serial/of_serial.c Dan Williams 2012-04-10 183
d9f59caf94a92f7 drivers/tty/serial/8250/8250_of.c Uwe Kleine-König 2023-06-09 184 if (IS_REACHABLE(CONFIG_SERIAL_8250_FSL) &&
d43b54d269d27bd drivers/tty/serial/of_serial.c Scott Wood 2015-10-07 185 (of_device_is_compatible(np, "fsl,ns16550") ||
d68fefdd5b5f107 drivers/tty/serial/8250/8250_of.c Dmitry Safonov 2019-12-13 186 of_device_is_compatible(np, "fsl,16550-FIFO64"))) {
d43b54d269d27bd drivers/tty/serial/of_serial.c Scott Wood 2015-10-07 @187 port->handle_irq = fsl8250_handle_irq;
d68fefdd5b5f107 drivers/tty/serial/8250/8250_of.c Dmitry Safonov 2019-12-13 188 port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
d68fefdd5b5f107 drivers/tty/serial/8250/8250_of.c Dmitry Safonov 2019-12-13 189 }
d43b54d269d27bd drivers/tty/serial/of_serial.c Scott Wood 2015-10-07 190
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 191 return 0;
a2d23edaef9e022 drivers/tty/serial/8250/8250_of.c Franklin S Cooper Jr 2017-08-16 192 err_pmruntime:
a2d23edaef9e022 drivers/tty/serial/8250/8250_of.c Franklin S Cooper Jr 2017-08-16 193 pm_runtime_put_sync(&ofdev->dev);
a2d23edaef9e022 drivers/tty/serial/8250/8250_of.c Franklin S Cooper Jr 2017-08-16 194 pm_runtime_disable(&ofdev->dev);
0bbeb3c3e84bc96 drivers/tty/serial/of_serial.c Murali Karicheri 2012-10-22 195 return ret;
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 196 }
8d38a5b2fab1397 drivers/serial/of_serial.c Arnd Bergmann 2007-02-13 197
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2026-05-11 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 15:12 [PATCH v1 1/1] serial: 8250_fsl: Export fsl8250_handle_irq() conditionally Andy Shevchenko
2026-05-11 12:32 ` kernel test robot
2026-05-11 12:54 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202605112003.uLqRrYzE-lkp@intel.com \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox