From: kernel test robot <lkp@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_fsl: Export fsl8250_handle_irq() conditionally
Date: Mon, 11 May 2026 20:32:58 +0800 [thread overview]
Message-ID: <202605112047.Ie6qC0oT-lkp@intel.com> (raw)
In-Reply-To: <20260504151259.483924-1-andriy.shevchenko@linux.intel.com>
Hi Andy,
kernel test robot noticed the following build errors:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus linus/master v7.1-rc3 next-20260508]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/serial-8250_fsl-Export-fsl8250_handle_irq-conditionally/20260511-115924
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/20260504151259.483924-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] serial: 8250_fsl: Export fsl8250_handle_irq() conditionally
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20260511/202605112047.Ie6qC0oT-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260511/202605112047.Ie6qC0oT-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605112047.Ie6qC0oT-lkp@intel.com/
All errors (new ones prefixed by >>):
arch/powerpc/kernel/legacy_serial.c: In function 'fixup_port_irq':
>> arch/powerpc/kernel/legacy_serial.c:514:44: error: 'fsl8250_handle_irq' undeclared (first use in this function); did you mean 'serial8250_handle_irq'?
514 | port->handle_irq = fsl8250_handle_irq;
| ^~~~~~~~~~~~~~~~~~
| serial8250_handle_irq
arch/powerpc/kernel/legacy_serial.c:514:44: note: each undeclared identifier is reported only once for each function it appears in
vim +514 arch/powerpc/kernel/legacy_serial.c
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 489
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 490 static void __init fixup_port_irq(int index,
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 491 struct device_node *np,
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 492 struct plat_serial8250_port *port)
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 493 {
0ebfff1491ef85 Benjamin Herrenschmidt 2006-07-03 494 unsigned int virq;
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 495
0ebfff1491ef85 Benjamin Herrenschmidt 2006-07-03 496 DBG("fixup_port_irq(%d)\n", index);
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 497
0ebfff1491ef85 Benjamin Herrenschmidt 2006-07-03 498 virq = irq_of_parse_and_map(np, 0);
ef24ba7091517d Michael Ellerman 2016-09-06 499 if (!virq && legacy_serial_infos[index].irq_check_parent) {
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 500 np = of_get_parent(np);
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 501 if (np == NULL)
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 502 return;
0ebfff1491ef85 Benjamin Herrenschmidt 2006-07-03 503 virq = irq_of_parse_and_map(np, 0);
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 504 of_node_put(np);
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 505 }
ef24ba7091517d Michael Ellerman 2016-09-06 506 if (!virq)
0ebfff1491ef85 Benjamin Herrenschmidt 2006-07-03 507 return;
0ebfff1491ef85 Benjamin Herrenschmidt 2006-07-03 508
0ebfff1491ef85 Benjamin Herrenschmidt 2006-07-03 509 port->irq = virq;
9deaa53ac7fa37 Paul Gortmaker 2011-12-04 510
66eff0ef528b6d Uwe Kleine-König 2023-06-05 511 if (IS_ENABLED(CONFIG_SERIAL_8250) &&
66eff0ef528b6d Uwe Kleine-König 2023-06-05 512 of_device_is_compatible(np, "fsl,ns16550")) {
1eea99c04555e5 Uwe Kleine-König 2023-06-09 513 if (IS_REACHABLE(CONFIG_SERIAL_8250_FSL)) {
9deaa53ac7fa37 Paul Gortmaker 2011-12-04 @514 port->handle_irq = fsl8250_handle_irq;
d68fefdd5b5f10 Dmitry Safonov 2019-12-13 515 port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
66eff0ef528b6d Uwe Kleine-König 2023-06-05 516 } else {
66eff0ef528b6d Uwe Kleine-König 2023-06-05 517 pr_warn_once("Not activating Freescale specific workaround for device %pOFP\n",
66eff0ef528b6d Uwe Kleine-König 2023-06-05 518 np);
66eff0ef528b6d Uwe Kleine-König 2023-06-05 519 }
d68fefdd5b5f10 Dmitry Safonov 2019-12-13 520 }
0ebfff1491ef85 Benjamin Herrenschmidt 2006-07-03 521 }
463ce0e103f419 Benjamin Herrenschmidt 2005-11-23 522
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-05-11 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 15:12 [PATCH v1 1/1] serial: 8250_fsl: Export fsl8250_handle_irq() conditionally Andy Shevchenko
2026-05-11 12:32 ` kernel test robot [this message]
2026-05-11 12:54 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202605112047.Ie6qC0oT-lkp@intel.com \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox