From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: remove always included kconfig.h
Date: Thu, 30 Jul 2026 16:47:46 +0200 [thread overview]
Message-ID: <2026073034-unbroken-busload-f0cf@gregkh> (raw)
In-Reply-To: <20260721144847.3728422-1-hugo@hugovil.com>
On Tue, Jul 21, 2026 at 10:48:32AM -0400, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> The inclusion of <linux/kconfig.h> in commit 7ab80d1e72431 ("serial: 8250:
> fix compile error with hub6_match_port() when compiled as a module") is
> unneeded as it's guaranteed by the build starting from commit 2a11c8ea20bf
> ("kconfig: Introduce IS_ENABLED(), IS_BUILTIN() and IS_MODULE()").
> Remove it here.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> Maybe this could be merged with commit 7ab80d1e72431 ("serial: 8250: fix
> compile error with hub6_match_port() when compiled as a module") since it
> is, for now, only in tty-testing?
It's now in tty-next, so I'll just apply this, thanks!
greg k-h
prev parent reply other threads:[~2026-07-30 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 14:48 [PATCH] serial: 8250: remove always included kconfig.h Hugo Villeneuve
2026-07-21 20:32 ` Andy Shevchenko
2026-07-30 14:47 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026073034-unbroken-busload-f0cf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox