* [PATCH] serial: 8250: remove always included kconfig.h
@ 2026-07-21 14:48 Hugo Villeneuve
2026-07-21 20:32 ` Andy Shevchenko
2026-07-30 14:47 ` Greg Kroah-Hartman
0 siblings, 2 replies; 3+ messages in thread
From: Hugo Villeneuve @ 2026-07-21 14:48 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: hugo, Hugo Villeneuve, Andy Shevchenko, linux-kernel,
linux-serial
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
The inclusion of <linux/kconfig.h> in commit 7ab80d1e72431 ("serial: 8250:
fix compile error with hub6_match_port() when compiled as a module") is
unneeded as it's guaranteed by the build starting from commit 2a11c8ea20bf
("kconfig: Introduce IS_ENABLED(), IS_BUILTIN() and IS_MODULE()").
Remove it here.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
Maybe this could be merged with commit 7ab80d1e72431 ("serial: 8250: fix
compile error with hub6_match_port() when compiled as a module") since it
is, for now, only in tty-testing?
---
drivers/tty/serial/8250/8250.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h
index b62f88eec881f..f72c7e7bb94f6 100644
--- a/drivers/tty/serial/8250/8250.h
+++ b/drivers/tty/serial/8250/8250.h
@@ -8,7 +8,6 @@
*/
#include <linux/bits.h>
-#include <linux/kconfig.h>
#include <linux/serial_8250.h>
#include <linux/serial_core.h>
#include <linux/dmaengine.h>
base-commit: 782f4dbd1794b4f30dc116a7ca42c5962c409be8
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: 8250: remove always included kconfig.h
2026-07-21 14:48 [PATCH] serial: 8250: remove always included kconfig.h Hugo Villeneuve
@ 2026-07-21 20:32 ` Andy Shevchenko
2026-07-30 14:47 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2026-07-21 20:32 UTC (permalink / raw)
To: Hugo Villeneuve
Cc: Greg Kroah-Hartman, Jiri Slaby, Hugo Villeneuve, linux-kernel,
linux-serial
On Tue, Jul 21, 2026 at 10:48:32AM -0400, Hugo Villeneuve wrote:
> The inclusion of <linux/kconfig.h> in commit 7ab80d1e72431 ("serial: 8250:
> fix compile error with hub6_match_port() when compiled as a module") is
> unneeded as it's guaranteed by the build starting from commit 2a11c8ea20bf
> ("kconfig: Introduce IS_ENABLED(), IS_BUILTIN() and IS_MODULE()").
> Remove it here.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: 8250: remove always included kconfig.h
2026-07-21 14:48 [PATCH] serial: 8250: remove always included kconfig.h Hugo Villeneuve
2026-07-21 20:32 ` Andy Shevchenko
@ 2026-07-30 14:47 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2026-07-30 14:47 UTC (permalink / raw)
To: Hugo Villeneuve
Cc: Jiri Slaby, Hugo Villeneuve, Andy Shevchenko, linux-kernel,
linux-serial
On Tue, Jul 21, 2026 at 10:48:32AM -0400, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> The inclusion of <linux/kconfig.h> in commit 7ab80d1e72431 ("serial: 8250:
> fix compile error with hub6_match_port() when compiled as a module") is
> unneeded as it's guaranteed by the build starting from commit 2a11c8ea20bf
> ("kconfig: Introduce IS_ENABLED(), IS_BUILTIN() and IS_MODULE()").
> Remove it here.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> Maybe this could be merged with commit 7ab80d1e72431 ("serial: 8250: fix
> compile error with hub6_match_port() when compiled as a module") since it
> is, for now, only in tty-testing?
It's now in tty-next, so I'll just apply this, thanks!
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-30 16:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-21 14:48 [PATCH] serial: 8250: remove always included kconfig.h Hugo Villeneuve
2026-07-21 20:32 ` Andy Shevchenko
2026-07-30 14:47 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox