From: sashiko-bot@kernel.org
To: "Mohamed Osama" <mohamed.osama189110@gmail.com>
Cc: ojeda@kernel.org, gary@garyguo.net, linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/4] rust: mem: add DropGuard
Date: Sun, 27 Sep 2026 10:52:57 +0000 [thread overview]
Message-ID: <20260927105258.5D8631F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260927104528.103881-2-mohamed.osama189110@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: import does not follow vertical import style
--
commit 4ef060000d9f83c4c9fca329ddeac4824d4432ca
Author: Mohamed Osama <mohamed.osama189110@gmail.com>
rust: mem: add DropGuard
Vendor DropGuard from the Rust standard library and re-export it
from kernel::mem.
> diff --git a/rust/kernel/std_vendor.rs b/rust/kernel/std_vendor.rs
> index abbab5050cc50..21a26b4eec71c 100644
> --- a/rust/kernel/std_vendor.rs
> +++ b/rust/kernel/std_vendor.rs
> @@ -7,6 +7,9 @@
> //! "Apache-2.0 OR MIT" and adapted for kernel use. For copyright details,
> //! see <https://github.com/rust-lang/rust/blob/master/COPYRIGHT>.
>
> +use core::mem::ManuallyDrop;
> +use core::ops::{Deref, DerefMut};
[Severity: Low]
This isn't a bug, but does this import follow the vertical import style?
The kernel coding guidelines specify that when braces are used for importing
multiple items from the same module, each item must go on its own line.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260927104528.103881-1-mohamed.osama189110@gmail.com?part=1
next prev parent reply other threads:[~2026-09-27 10:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Dch07wH15t-1WtaVQW4vdfmtJuwC_4-JLvrWSB8Pk4vfEHO6mQk1FpYG-tCYBllTB3RbpOXpdyNZp84w4PFl1A==@protonmail.internalid>
2026-09-27 10:45 ` [PATCH v4 0/4] rust: introduce DropGuard Mohamed Osama
2026-09-27 10:45 ` [PATCH 1/4] rust: mem: add DropGuard Mohamed Osama
2026-09-27 10:52 ` sashiko-bot [this message]
2026-09-27 10:45 ` [PATCH 2/4] rust: block: gen_disk: use DropGuard Mohamed Osama
2026-09-27 10:51 ` sashiko-bot
2026-09-27 10:45 ` [PATCH 3/4] rust: serdev: " Mohamed Osama
2026-09-27 10:56 ` sashiko-bot
2026-09-27 10:45 ` [PATCH 4/4] rust: sync: lock: " Mohamed Osama
2026-09-27 10:51 ` sashiko-bot
2026-09-28 9:03 ` Boqun Feng
2026-09-28 9:48 ` [PATCH v4 0/4] rust: introduce DropGuard Andreas Hindborg
2026-09-28 9:50 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927105258.5D8631F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-serial@vger.kernel.org \
--cc=mohamed.osama189110@gmail.com \
--cc=ojeda@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox