From: sashiko-bot@kernel.org
To: "Mohamed Osama" <mohamed.osama189110@gmail.com>
Cc: ojeda@kernel.org, linux-serial@vger.kernel.org, gary@garyguo.net
Subject: Re: [PATCH 3/4] rust: serdev: use DropGuard
Date: Sun, 27 Sep 2026 10:56:09 +0000 [thread overview]
Message-ID: <20260927105610.189A01F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260927104528.103881-4-mohamed.osama189110@gmail.com>
> Replace the ScopeGuard usage in the serial device bus implementation
> with DropGuard.
>
> Use DropGuard::dismiss() when ownership of the private data needs to be
> transferred without running the cleanup callback.
>
> Signed-off-by: Mohamed Osama <mohamed.osama189110@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260927104528.103881-1-mohamed.osama189110@gmail.com?part=3
next prev parent reply other threads:[~2026-09-27 10:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Dch07wH15t-1WtaVQW4vdfmtJuwC_4-JLvrWSB8Pk4vfEHO6mQk1FpYG-tCYBllTB3RbpOXpdyNZp84w4PFl1A==@protonmail.internalid>
2026-09-27 10:45 ` [PATCH v4 0/4] rust: introduce DropGuard Mohamed Osama
2026-09-27 10:45 ` [PATCH 1/4] rust: mem: add DropGuard Mohamed Osama
2026-09-27 10:52 ` sashiko-bot
2026-09-27 10:45 ` [PATCH 2/4] rust: block: gen_disk: use DropGuard Mohamed Osama
2026-09-27 10:51 ` sashiko-bot
2026-09-27 10:45 ` [PATCH 3/4] rust: serdev: " Mohamed Osama
2026-09-27 10:56 ` sashiko-bot [this message]
2026-09-27 10:45 ` [PATCH 4/4] rust: sync: lock: " Mohamed Osama
2026-09-27 10:51 ` sashiko-bot
2026-09-28 9:03 ` Boqun Feng
2026-09-28 9:48 ` [PATCH v4 0/4] rust: introduce DropGuard Andreas Hindborg
2026-09-28 9:50 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927105610.189A01F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-serial@vger.kernel.org \
--cc=mohamed.osama189110@gmail.com \
--cc=ojeda@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox