From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: lizhe <sensor1010@163.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] serial: linflexuart: remove redundant uart type PORT_LINFLEXUART
Date: Wed, 4 Jan 2023 17:08:10 +0200 (EET) [thread overview]
Message-ID: <2f726128-29c-b7dd-ad8-f8b536fbe5f@linux.intel.com> (raw)
In-Reply-To: <20230104150023.3115-1-sensor1010@163.com>
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On Wed, 4 Jan 2023, lizhe wrote:
> in linflex_config_port() the member variable type will be
> assigned again. see linflex_connfig_port()
>
> Signed-off-by: lizhe <sensor1010@163.com>
> Acked-by: Jiri Slaby <jslaby@suse.com>
> Acked-by: Ilpo Järvinen<ilpo.jarvinen@linux.intel.com>
Eh, you're not supposed to invent these Acked-by tags yourself. Don't add
any tags besides your own unless somebody explicitly gives them to you in
a reply!
And the subject was supposed to be (as per Jiri's recommendation):
serial: linflexuart: remove redundant uart type assignment
You also didn't include the history of what was changed in v3.
--
i.
prev parent reply other threads:[~2023-01-04 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 15:00 [PATCH v3] serial: linflexuart: remove redundant uart type PORT_LINFLEXUART lizhe
2023-01-04 15:08 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f726128-29c-b7dd-ad8-f8b536fbe5f@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sensor1010@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox