* [PATCH] tty: atmel_serial: Use devm_platform_ioremap_resource()
@ 2024-11-05 13:19 Mihai Sain
2024-11-05 13:31 ` Andrei Simion
2024-11-06 8:13 ` Hari.PrasathGE
0 siblings, 2 replies; 3+ messages in thread
From: Mihai Sain @ 2024-11-05 13:19 UTC (permalink / raw)
To: richard.genoud, gregkh, jirislaby, nicolas.ferre,
alexandre.belloni, claudiu.beznea, linux-kernel, linux-serial,
linux-arm-kernel, hari.prasathge
Cc: Mihai Sain
Simplify the request port function by using a single call
to devm_platform_ioremap_resource().
This will also enhance the printing from /proc/iomem:
cat /proc/iomem | grep flexcom ; cat /proc/iomem | grep serial
f0004000-f00041ff : f0004000.flexcom flexcom@f0004000
f8020000-f80201ff : f8020000.flexcom flexcom@f8020000
f0004200-f00043ff : f0004200.serial serial@200
f8020200-f80203ff : f8020200.serial serial@200
fffff200-fffff3ff : fffff200.serial serial@fffff200
Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
---
drivers/tty/serial/atmel_serial.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 09b246c9e389..e1107f14ec98 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -2419,17 +2419,11 @@ static void atmel_release_port(struct uart_port *port)
static int atmel_request_port(struct uart_port *port)
{
struct platform_device *mpdev = to_platform_device(port->dev->parent);
- int size = resource_size(mpdev->resource);
-
- if (!request_mem_region(port->mapbase, size, "atmel_serial"))
- return -EBUSY;
if (port->flags & UPF_IOREMAP) {
- port->membase = ioremap(port->mapbase, size);
- if (port->membase == NULL) {
- release_mem_region(port->mapbase, size);
- return -ENOMEM;
- }
+ port->membase = devm_platform_ioremap_resource(mpdev, 0);
+ if (IS_ERR(port->membase))
+ return PTR_ERR(port->membase);
}
return 0;
base-commit: 2e1b3cc9d7f790145a80cb705b168f05dab65df2
--
2.47.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tty: atmel_serial: Use devm_platform_ioremap_resource()
2024-11-05 13:19 [PATCH] tty: atmel_serial: Use devm_platform_ioremap_resource() Mihai Sain
@ 2024-11-05 13:31 ` Andrei Simion
2024-11-06 8:13 ` Hari.PrasathGE
1 sibling, 0 replies; 3+ messages in thread
From: Andrei Simion @ 2024-11-05 13:31 UTC (permalink / raw)
To: mihai.sain
Cc: alexandre.belloni, claudiu.beznea, gregkh, hari.prasathge,
jirislaby, linux-arm-kernel, linux-kernel, linux-serial,
nicolas.ferre, richard.genoud, Andrei Simion
On 05.11.2024 15:19, Mihai Sain wrote:
> Simplify the request port function by using a single call
> to devm_platform_ioremap_resource().
>
> This will also enhance the printing from /proc/iomem:
>
> cat /proc/iomem | grep flexcom ; cat /proc/iomem | grep serial
>
> f0004000-f00041ff : f0004000.flexcom flexcom@f0004000
> f8020000-f80201ff : f8020000.flexcom flexcom@f8020000
> f0004200-f00043ff : f0004200.serial serial@200
> f8020200-f80203ff : f8020200.serial serial@200
> fffff200-fffff3ff : fffff200.serial serial@fffff200
>
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
Hi,
Tested-by: Andrei Simion <andrei.simion@microchip.com>
Best Regards,
Andrei
> ---
> drivers/tty/serial/atmel_serial.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 09b246c9e389..e1107f14ec98 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -2419,17 +2419,11 @@ static void atmel_release_port(struct uart_port *port)
> static int atmel_request_port(struct uart_port *port)
> {
> struct platform_device *mpdev = to_platform_device(port->dev->parent);
> - int size = resource_size(mpdev->resource);
> -
> - if (!request_mem_region(port->mapbase, size, "atmel_serial"))
> - return -EBUSY;
>
> if (port->flags & UPF_IOREMAP) {
> - port->membase = ioremap(port->mapbase, size);
> - if (port->membase == NULL) {
> - release_mem_region(port->mapbase, size);
> - return -ENOMEM;
> - }
> + port->membase = devm_platform_ioremap_resource(mpdev, 0);
> + if (IS_ERR(port->membase))
> + return PTR_ERR(port->membase);
> }
>
> return 0;
>
> base-commit: 2e1b3cc9d7f790145a80cb705b168f05dab65df2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tty: atmel_serial: Use devm_platform_ioremap_resource()
2024-11-05 13:19 [PATCH] tty: atmel_serial: Use devm_platform_ioremap_resource() Mihai Sain
2024-11-05 13:31 ` Andrei Simion
@ 2024-11-06 8:13 ` Hari.PrasathGE
1 sibling, 0 replies; 3+ messages in thread
From: Hari.PrasathGE @ 2024-11-06 8:13 UTC (permalink / raw)
To: Mihai.Sain, richard.genoud, gregkh, jirislaby, Nicolas.Ferre,
alexandre.belloni, claudiu.beznea, linux-kernel, linux-serial,
linux-arm-kernel
On 11/5/24 6:49 PM, Mihai Sain wrote:
> Simplify the request port function by using a single call
> to devm_platform_ioremap_resource().
>
> This will also enhance the printing from /proc/iomem:
>
Thanks Mihai.
Reviewed-by: Hari Prasath Gujulan Elango <hari.prasathge@microchip.com>
> cat /proc/iomem | grep flexcom ; cat /proc/iomem | grep serial
>
> f0004000-f00041ff : f0004000.flexcom flexcom@f0004000
> f8020000-f80201ff : f8020000.flexcom flexcom@f8020000
> f0004200-f00043ff : f0004200.serial serial@200
> f8020200-f80203ff : f8020200.serial serial@200
> fffff200-fffff3ff : fffff200.serial serial@fffff200
>
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
> drivers/tty/serial/atmel_serial.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 09b246c9e389..e1107f14ec98 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -2419,17 +2419,11 @@ static void atmel_release_port(struct uart_port *port)
> static int atmel_request_port(struct uart_port *port)
> {
> struct platform_device *mpdev = to_platform_device(port->dev->parent);
> - int size = resource_size(mpdev->resource);
> -
> - if (!request_mem_region(port->mapbase, size, "atmel_serial"))
> - return -EBUSY;
>
> if (port->flags & UPF_IOREMAP) {
> - port->membase = ioremap(port->mapbase, size);
> - if (port->membase == NULL) {
> - release_mem_region(port->mapbase, size);
> - return -ENOMEM;
> - }
> + port->membase = devm_platform_ioremap_resource(mpdev, 0);
> + if (IS_ERR(port->membase))
> + return PTR_ERR(port->membase);
> }
>
> return 0;
>
> base-commit: 2e1b3cc9d7f790145a80cb705b168f05dab65df2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-06 8:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-05 13:19 [PATCH] tty: atmel_serial: Use devm_platform_ioremap_resource() Mihai Sain
2024-11-05 13:31 ` Andrei Simion
2024-11-06 8:13 ` Hari.PrasathGE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox