From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Wadim Mueller <wafgo01@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Chester Lin" <chester62515@gmail.com>,
"Andreas Färber" <afaerber@suse.de>,
"Matthias Brugger" <mbrugger@suse.com>,
"NXP S32 Linux Team" <s32@nxp.com>,
"Tim Harvey" <tharvey@gateworks.com>,
"Alexander Stein" <alexander.stein@ew.tq-group.com>,
"Marek Vasut" <marex@denx.de>,
"Gregor Herburger" <gregor.herburger@ew.tq-group.com>,
"Joao Paulo Goncalves" <joao.goncalves@toradex.com>,
"Marco Felsch" <m.felsch@pengutronix.de>,
"Markus Niebel" <Markus.Niebel@ew.tq-group.com>,
"Matthias Schiffer" <matthias.schiffer@tq-group.com>,
"Stefan Wahren" <stefan.wahren@chargebyte.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Philippe Schenker" <philippe.schenker@toradex.com>,
"Yannic Moog" <y.moog@phytec.de>, "Li Yang" <leoyang.li@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: arm: fsl: Document NXP S32G3 board
Date: Thu, 21 Mar 2024 18:52:02 +0100 [thread overview]
Message-ID: <3a3bf0ef-61d6-4b4c-8259-277b15394c98@linaro.org> (raw)
In-Reply-To: <20240321154108.146223-2-wafgo01@gmail.com>
On 21/03/2024 16:41, Wadim Mueller wrote:
> The NXP S32G3 Reference Design Board 3 (S32G-VNP-RDB3) [1]
> is not documented.
Is not documented, so it means that you document existing board from
DTS? I think not, so please describe what you are doing accurately. Use
imperative mood. See longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
"Document foo bar".
Or "Add bindings for foo bar"
No need to resend just to fix this, that's generic comment.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-21 17:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 15:41 [PATCH v3 0/4] NXP S32G3 SoC initial bring-up Wadim Mueller
2024-03-21 15:41 ` [PATCH v3 1/4] dt-bindings: arm: fsl: Document NXP S32G3 board Wadim Mueller
2024-03-21 17:52 ` Krzysztof Kozlowski [this message]
2024-03-21 15:41 ` [PATCH v3 2/4] dt-bindings: serial: fsl-linflexuart: add compatible for S32G3 Wadim Mueller
2024-03-21 17:52 ` Krzysztof Kozlowski
2024-03-21 15:41 ` [PATCH v3 3/4] dt-bindings: mmc: fsl-imx-esdhc: add NXP S32G3 support Wadim Mueller
2024-03-21 17:53 ` Krzysztof Kozlowski
2024-03-22 9:45 ` Wadim Mueller
2024-03-22 15:02 ` Krzysztof Kozlowski
2024-03-21 15:41 ` [PATCH v3 4/4] arm64: dts: S32G3: Introduce device tree for S32G-VNP-RDB3 Wadim Mueller
2024-03-21 17:54 ` Krzysztof Kozlowski
2024-03-22 14:52 ` Ghennadi Procopciuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a3bf0ef-61d6-4b4c-8259-277b15394c98@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=afaerber@suse.de \
--cc=alexander.stein@ew.tq-group.com \
--cc=bhelgaas@google.com \
--cc=chester62515@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregor.herburger@ew.tq-group.com \
--cc=jirislaby@kernel.org \
--cc=joao.goncalves@toradex.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=marex@denx.de \
--cc=matthias.schiffer@tq-group.com \
--cc=mbrugger@suse.com \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
--cc=stefan.wahren@chargebyte.com \
--cc=tharvey@gateworks.com \
--cc=ulf.hansson@linaro.org \
--cc=wafgo01@gmail.com \
--cc=y.moog@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox