From: James Hogan <james.hogan@imgtec.com>
To: John Crispin <blogic@openwrt.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-mips@linux-mips.org,
Thomas Langer <thomas.langer@lantiq.com>
Subject: Re: [PATCH 2/2] serial: MIPS: lantiq: make driver use pinctrl
Date: Thu, 8 Aug 2013 15:50:08 +0100 [thread overview]
Message-ID: <5203B020.1080909@imgtec.com> (raw)
In-Reply-To: <1375968687-8704-2-git-send-email-blogic@openwrt.org>
On 08/08/13 14:31, John Crispin wrote:
> From: Thomas Langer <thomas.langer@lantiq.com>
>
> Add use of devm_pinctrl_get_select_default to active default pinctrl settings.
>
> Signed-off-by: Thomas Langer <thomas.langer@lantiq.com>
> Acked-by: John Crispin <blogic@openwrt.org>
> ---
> drivers/tty/serial/lantiq.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> @@ -719,6 +722,10 @@ lqasc_probe(struct platform_device *pdev)
> port->irq = irqres[0].start;
> port->mapbase = mmres->start;
>
> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> + if (IS_ERR(pinctrl))
> + dev_warn(&pdev->dev, "pins are not configured from the driver\n");
I believe since v3.9 (specifically commit ab78029) this happens
automatically.
Cheers
James
next prev parent reply other threads:[~2013-08-08 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 13:31 [PATCH 1/2] serial: MIPS: lantiq: add clk_enable() call to driver John Crispin
2013-08-08 13:31 ` [PATCH 2/2] serial: MIPS: lantiq: make driver use pinctrl John Crispin
2013-08-08 14:50 ` James Hogan [this message]
2013-08-08 14:47 ` [PATCH 1/2] serial: MIPS: lantiq: add clk_enable() call to driver James Hogan
2013-08-08 14:56 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203B020.1080909@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=blogic@openwrt.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=thomas.langer@lantiq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox