Re: [PATCH 1/2] serial: MIPS: lantiq: add clk_enable() call to driver

[John Crispin <blogic@openwrt.org>]

On 08/08/13 16:47, James Hogan wrote:
> On 08/08/13 14:31, John Crispin wrote:
>> From: Thomas Langer<thomas.langer@lantiq.com>
>>
>> Enable the clock if one is present when setting up the console.
>>
>> Signed-off-by: Thomas Langer<thomas.langer@lantiq.com>
>> Acked-by: John Crispin<blogic@openwrt.org>
>> ---
>>   drivers/tty/serial/lantiq.c |    3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c
>> index 15733da..ce1ea35 100644
>> --- a/drivers/tty/serial/lantiq.c
>> +++ b/drivers/tty/serial/lantiq.c
>> @@ -636,6 +636,9 @@ lqasc_console_setup(struct console *co, char *options)
>>
>>   	port =&ltq_port->port;
>>
>> +	if (ltq_port->clk)
> I think that should be !IS_ERR(ltq_port->clk)? The same problem appears
> to be elsewhere in that file too.
>
> Cheers
> James
>
>


Thanks, i will send an updated series