public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: todd.e.brandt@linux.intel.com, pmladek@suse.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	senozhatsky@chromium.org, rostedt@goodmis.org
Subject: Re: PNP0501 serial driver takes almost 2 seconds to suspend/resume (printk issue)
Date: Sat, 09 Jul 2022 22:47:21 +0206	[thread overview]
Message-ID: <87tu7qvx1q.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <045ebee30af2b80aaeace1dab18ecd113e3f17c7.camel@linux.intel.com>

On 2022-07-08, Todd Brandt <todd.e.brandt@linux.intel.com> wrote:
> The dmesg logs are in the html timelines themselves, just click the
> "dmesg" button in the upper right hand corner. The log button shows
> all kinds of system info as well.

Since the beginning of the kernel log is missing, I still do not see
information about which serial driver you are using. But since it is
x86, I'll assume it is an 8250.

Looking at freeze-5.19.0-rc1-bad.html, at 3431.221039 we see that
suspend_console() was called. The additional 1-second delay you are
referring to would be 3432.436187, where serial is suspended. pr_flush()
would have been satisfied when the message at 3431.221039 was
printed. So the question is, why is there still printing going on?

@Todd: I assume you actually see all the messages up to and including
3431.506391 when it suspends? But the next message does not appear on
suspend?

I wonder if the console_lock()/console_unlock() within __pr_flush() is
allowing extra printing to occur, for example if another CPU was calling
printk.

@Todd: Could you build your kernel with CONFIG_PRINTK_CALLER enabled?
Also, please provide the last line you _see_ after a suspend. And
finally, please make sure you are using the latest 5.19-rc. Thanks!

John Ogness

  reply	other threads:[~2022-07-09 20:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 20:31 PNP0501 serial driver takes almost 2 seconds to suspend/resume (printk issue) Todd Brandt
2022-07-07 20:45 ` Todd Brandt
2022-07-08  8:01   ` John Ogness
2022-07-08 21:35     ` Todd Brandt
2022-07-09 20:41       ` John Ogness [this message]
2022-07-10 19:39         ` Andy Shevchenko
2022-07-10 20:04           ` John Ogness
2022-07-11  8:13             ` Petr Mladek
2022-07-11 10:10               ` Sergey Senozhatsky
2022-07-13  9:51                 ` John Ogness
2022-07-13 14:24                   ` Todd Brandt
2022-07-13 17:11                   ` Todd Brandt
2022-07-13 18:23                     ` Todd Brandt
2022-07-13 21:22                       ` John Ogness
2022-07-13 22:01                         ` John Ogness
2022-07-14 22:16                         ` Todd Brandt
2022-07-15  6:14                           ` John Ogness

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu7qvx1q.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=todd.e.brandt@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox