public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Todd Brandt <todd.e.brandt@linux.intel.com>
To: John Ogness <john.ogness@linutronix.de>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Petr Mladek <pmladek@suse.com>,
	rafael.j.wysocki@intel.com, len.brown@intel.com
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: PNP0501 serial driver takes almost 2 seconds to suspend/resume (printk issue)
Date: Wed, 13 Jul 2022 10:11:22 -0700	[thread overview]
Message-ID: <c60f5634e8605cb4c2ef4646b6e511e6135bea48.camel@linux.intel.com> (raw)
In-Reply-To: <87ilo1wdac.fsf@jogness.linutronix.de>

I've updated the bugzilla entry with new data:
https://bugzilla.kernel.org/show_bug.cgi?id=216216

I just added 3 new tests for 5.19.0-rc6 on 3 machines that see this
issue: otcpl-asus-e200-cht (cherry trail), otcpl-aml-y (amber lake),
and otcpl-whl-u (whiskey lake). The kernel has the CONFIG_PRINTK_CALLER
option enabled.

The test is a S2idle and is run thusly:
%> sleepgraph -dev -m freeze -rtcwake 15

I've included the dmesg boot logs for all three. The dmesg
suspend/resume logs are included in the html timelines by clicking the
"dmesg" button in the upper right hand corner of the timeline. There's
a "log" button as well that shows other system into.

These files are attached to the bugzilla entry.
otcpl-aml-y-5.19.0-rc6-boot-dmesg.txt
otcpl-aml-y-5.19.0-rc6-freeze.html
otcpl-asus-e200-cht-5.19.0-rc6-boot-dmesg.txt
otcpl-asus-e200-cht-5.19.0-rc6-freeze.html
otcpl-whl-u-5.19.0-rc6-boot-dmesg.txt
otcpl-whl-u-5.19.0-rc6-freeze.html

If possible can we move this thread to the bugzilla comment section?


On Wed, 2022-07-13 at 11:57 +0206, John Ogness wrote:
> On 2022-07-11, Sergey Senozhatsky <senozhatsky@chromium.org> wrote:
> > > It seems that __pr_flush() does not check whether all consoles
> > > are
> > > suspended. In this case the progress is not possible and it has
> > > to
> > > wait the entire timeout.
> > 
> > But isn't console_suspended set after pr_flush() call?
> 
> There should not be any printing after the suspend_console() message.
> If
> Todd's report is coming from 5.19-rc1, then it is likely a kthread
> issue, where the kthread is not respecting @console_suspended. (This
> would still need to be fixed for the kthreads, but would not be
> relevant
> for 5.19.)
> 
> John


  parent reply	other threads:[~2022-07-13 17:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 20:31 PNP0501 serial driver takes almost 2 seconds to suspend/resume (printk issue) Todd Brandt
2022-07-07 20:45 ` Todd Brandt
2022-07-08  8:01   ` John Ogness
2022-07-08 21:35     ` Todd Brandt
2022-07-09 20:41       ` John Ogness
2022-07-10 19:39         ` Andy Shevchenko
2022-07-10 20:04           ` John Ogness
2022-07-11  8:13             ` Petr Mladek
2022-07-11 10:10               ` Sergey Senozhatsky
2022-07-13  9:51                 ` John Ogness
2022-07-13 14:24                   ` Todd Brandt
2022-07-13 17:11                   ` Todd Brandt [this message]
2022-07-13 18:23                     ` Todd Brandt
2022-07-13 21:22                       ` John Ogness
2022-07-13 22:01                         ` John Ogness
2022-07-14 22:16                         ` Todd Brandt
2022-07-15  6:14                           ` John Ogness

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c60f5634e8605cb4c2ef4646b6e511e6135bea48.camel@linux.intel.com \
    --to=todd.e.brandt@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=john.ogness@linutronix.de \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox