From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Eric Tremblay" <etremblay@distech-controls.com>,
"Wander Lairson Costa" <wander@redhat.com>,
linux-serial <linux-serial@vger.kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Fabrizio Castro" <fabrizio.castro.jz@renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/3] serial: 8250: Identify Renesas RZ/V2M 16750 UART
Date: Thu, 9 Feb 2023 23:52:56 +0200 [thread overview]
Message-ID: <Y+VrOGR+7LbBMahz@smile.fi.intel.com> (raw)
In-Reply-To: <OS0PR01MB5922AC5FF10FFF5F8590B8AA86D99@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On Thu, Feb 09, 2023 at 02:28:55PM +0000, Biju Das wrote:
> > From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > Sent: Thursday, February 9, 2023 2:09 PM
> > On Thu, 9 Feb 2023, Biju Das wrote:
> > > + [PORT_16750] = {
> > > + .name = "Renesas RZ/V2M 16750",
> > > + .fifo_size = 64,
> > > + .tx_loadsz = 64,
> > > + .fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10 |
> > > + UART_FCR7_64BYTE,
> > > + .rxtrig_bytes = {1, 16, 32, 56},
> > > + .flags = UART_CAP_FIFO | UART_CAP_AFE,
> > > + },
> >
> > Eh, how can you reuse [PORT_16750] again in the initializer like that?
>
> Oops. Missed it. Is it ok to introduce PORT_RENESAS_16750_F64 instead
> as PORT_16750 is used by TI16750?
What the difference to the 16750 from TI that prevents you from using it?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-09 21:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 13:26 [PATCH 0/3] Add Identification and 64 bit fifo support to Renesas RZ/V2M 16750 UART Biju Das
2023-02-09 13:26 ` [PATCH 1/3] serial: 8250: Identify " Biju Das
2023-02-09 14:08 ` Ilpo Järvinen
2023-02-09 14:28 ` Biju Das
2023-02-09 21:52 ` Andy Shevchenko [this message]
2023-02-10 7:14 ` Biju Das
2023-02-10 10:59 ` Andy Shevchenko
2023-02-10 11:53 ` Biju Das
2023-02-10 15:56 ` Andy Shevchenko
2023-02-09 13:26 ` [PATCH 2/3] serial: 8250_em: Use dev_err_probe() Biju Das
2023-02-09 17:49 ` Geert Uytterhoeven
2023-02-10 12:19 ` Biju Das
2023-02-09 13:26 ` [PATCH 3/3] serial: 8250_em: Add serial8250_rzv2m_reg_update() Biju Das
2023-02-09 14:29 ` Ilpo Järvinen
2023-02-10 13:47 ` Biju Das
2023-02-09 17:53 ` Geert Uytterhoeven
2023-02-10 13:49 ` Biju Das
2023-02-10 13:56 ` Ilpo Järvinen
2023-02-10 14:51 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+VrOGR+7LbBMahz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=etremblay@distech-controls.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox