From: Deepak R Varma <drv@mailo.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Saurabh Singh Sengar <ssengar@microsoft.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH v2] tty: serial: dz: convert atomic_* to refcount_* APIs for irq_guard
Date: Sat, 24 Dec 2022 14:10:02 +0530 [thread overview]
Message-ID: <Y6a64uR1uYxq3Qi/@qemulion> (raw)
In-Reply-To: <Y6a6VyNwJ8yM44Rq@kroah.com>
On Sat, Dec 24, 2022 at 09:37:43AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Dec 24, 2022 at 01:47:12PM +0530, Deepak R Varma wrote:
> > The refcount_* APIs are designed to address known issues with the
> > atomic_t APIs for reference counting. They provide following distinct
> > advantages:
> > - protect the reference counters from overflow/underflow
> > - avoid use-after-free errors
> > - provide improved memory ordering guarantee schemes
> > - neater and safer.
> > Hence, replace the atomic_* APIs by their equivalent refcount_t
> > API functions.
> >
> > This patch proposal address the following warnings generated by
> > the atomic_as_refcounter.cocci coccinelle script
> > atomic_add_return(-1, ...)
> >
> > Signed-off-by: Deepak R Varma <drv@mailo.com>
> > ---
>
> This depends on the previous patch you sent, so why wasn't this a patch
> series? Always send patches as a series, otherwise I would have
> attempted to apply this one first and it would have failed. You will
> recieve 0-day reports about that happening over the next few days as our
> testing infrastructure will also be confused.
My apologies. I will send in the patches in a series and highlight the
dependency as well. Sorry.
./drv
>
> Please fix and resend all changes you wish to have done to this driver
> together.
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2022-12-24 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 8:17 [PATCH v2] tty: serial: dz: convert atomic_* to refcount_* APIs for irq_guard Deepak R Varma
2022-12-24 8:37 ` Greg Kroah-Hartman
2022-12-24 8:40 ` Deepak R Varma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6a64uR1uYxq3Qi/@qemulion \
--to=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=ssengar@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox