* [PATCH] serial: sh-sci: Use dev_dbg() for frame and parity errors
@ 2021-12-04 13:46 Magnus Damm
2021-12-04 15:30 ` Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Magnus Damm @ 2021-12-04 13:46 UTC (permalink / raw)
To: linux-serial
Cc: Magnus Damm, geert+renesas, gregkh, linux-renesas-soc,
wsa+renesas, jirislaby
From: Magnus Damm <damm+renesas@opensource.se>
Adjust the console printout handling for frame and parity errors to the same
style as for break errors by using dev_dbg() instead of dev_notice().
This reduces the amount of console printouts generated by the defconfig kernel
on ARM R-Car Gen3 for certain use cases.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
drivers/tty/serial/sh-sci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- 0001/drivers/tty/serial/sh-sci.c
+++ work/drivers/tty/serial/sh-sci.c 2021-12-04 22:07:39.760407200 +0900
@@ -895,11 +895,11 @@ static void sci_receive_chars(struct uar
if (status & SCxSR_FER(port)) {
flag = TTY_FRAME;
port->icount.frame++;
- dev_notice(port->dev, "frame error\n");
+ dev_dbg(port->dev, "frame error\n");
} else if (status & SCxSR_PER(port)) {
flag = TTY_PARITY;
port->icount.parity++;
- dev_notice(port->dev, "parity error\n");
+ dev_dbg(port->dev, "parity error\n");
} else
flag = TTY_NORMAL;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] serial: sh-sci: Use dev_dbg() for frame and parity errors
2021-12-04 13:46 [PATCH] serial: sh-sci: Use dev_dbg() for frame and parity errors Magnus Damm
@ 2021-12-04 15:30 ` Wolfram Sang
2021-12-05 0:45 ` Magnus Damm
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2021-12-04 15:30 UTC (permalink / raw)
To: Magnus Damm
Cc: linux-serial, geert+renesas, gregkh, linux-renesas-soc, jirislaby
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
Hi Magnus,
On Sat, Dec 04, 2021 at 10:46:18PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Adjust the console printout handling for frame and parity errors to the same
> style as for break errors by using dev_dbg() instead of dev_notice().
> This reduces the amount of console printouts generated by the defconfig kernel
> on ARM R-Car Gen3 for certain use cases.
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
Could we maybe just remove them because there are dedicated counters for
this?
Have a nice weekend,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: sh-sci: Use dev_dbg() for frame and parity errors
2021-12-04 15:30 ` Wolfram Sang
@ 2021-12-05 0:45 ` Magnus Damm
2021-12-05 7:16 ` Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Magnus Damm @ 2021-12-05 0:45 UTC (permalink / raw)
To: Wolfram Sang, Magnus Damm, linux-serial, Geert Uytterhoeven,
Greg KH, Linux-Renesas, jirislaby
Hi Wolfram,
On Sun, Dec 5, 2021 at 12:30 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Hi Magnus,
>
> On Sat, Dec 04, 2021 at 10:46:18PM +0900, Magnus Damm wrote:
> > From: Magnus Damm <damm+renesas@opensource.se>
> >
> > Adjust the console printout handling for frame and parity errors to the same
> > style as for break errors by using dev_dbg() instead of dev_notice().
> > This reduces the amount of console printouts generated by the defconfig kernel
> > on ARM R-Car Gen3 for certain use cases.
> >
> > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
>
> Could we maybe just remove them because there are dedicated counters for
> this?
Sure, overrun and break also have counters so I'll prepare a patch
removing all four if you don't mind.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: sh-sci: Use dev_dbg() for frame and parity errors
2021-12-05 0:45 ` Magnus Damm
@ 2021-12-05 7:16 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2021-12-05 7:16 UTC (permalink / raw)
To: Magnus Damm
Cc: Magnus Damm, linux-serial, Geert Uytterhoeven, Greg KH,
Linux-Renesas, jirislaby
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
Hi Magnus,
> Sure, overrun and break also have counters so I'll prepare a patch
> removing all four if you don't mind.
Good idea!
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-05 7:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-04 13:46 [PATCH] serial: sh-sci: Use dev_dbg() for frame and parity errors Magnus Damm
2021-12-04 15:30 ` Wolfram Sang
2021-12-05 0:45 ` Magnus Damm
2021-12-05 7:16 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox