From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Tomasz Moń" <tomasz.mon@camlingroup.com>
Cc: linux-serial@vger.kernel.org,
"Phil Elwell" <phil@raspberrypi.com>,
"Daniel Mack" <daniel@zonque.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Krzysztof Drobiński" <k.drobinski@camlintechnologies.com>,
"Lech Perczak" <l.perczak@camlintechnologies.com>
Subject: Re: [PATCH 0/6] sc16is7xx: Hardware flow control fixes
Date: Fri, 25 Feb 2022 12:26:36 +0100 [thread overview]
Message-ID: <Yhi87AJy1RxIiFfO@kroah.com> (raw)
In-Reply-To: <YhizqKXxxVJ6lZtP@kroah.com>
On Fri, Feb 25, 2022 at 11:47:04AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Feb 25, 2022 at 10:37:01AM +0100, Tomasz Moń wrote:
> > On 25.02.2022 10:25, Greg Kroah-Hartman wrote:
> > > On Mon, Feb 21, 2022 at 11:56:12AM +0100, Tomasz Moń wrote:
> > >> sc16is7xx driver assumes that the device handles hardware flow control
> > >> automatically. This is not really true as the driver does inadvertently
> > >> clear the bits that enable hardware flow control.
> > >>
> > >> This patch series solves multiple issues present in the driver. While
> > >> the patches are fairly independent, there are some dependencies. The
> > >> "sc16is7xx: Properly resume TX after stop" adds IER bit set function
> > >> that is later used in "sc16is7xx: Set AUTOCTS and AUTORTS bits". Also
> > >> the patches that control which interrupts are enabled are dependent on
> > >> each other.
> > >>
> > >> Patches should be applied respecting the order in the series. The whole
> > >> series applies on top of "sc16is7xx: Fix for incorrect data being
> > >> transmitted" [1].
> > >
> > > The first 3 patches of this series applied. Please rebase and resend
> > > the remaining.
> >
> > The remaining patches did not apply because the "sc16is7xx: Fix for
> > incorrect data being transmitted" by Phil Elwell was not applied.
> >
> > The Phil Elwell patch was independently developed and made it to the
> > list before I sent the patch series. For that reason I based the series
> > on top of that patch and mentioned it in the cover letter.
>
> If that patch was not applied, then just rebase your series on my branch
> and resend it.
Ah, Phil's patch is in a different branch, and will be sent to Linus
later today, so you might just want to wait until Monday to resend your
remaining patches and then they will apply as my tty-next branch will
merge with that at that point in time.
thanks,
greg k-h
prev parent reply other threads:[~2022-02-25 11:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 10:56 [PATCH 0/6] sc16is7xx: Hardware flow control fixes Tomasz Moń
2022-02-21 10:56 ` [PATCH 1/6] sc16is7xx: Preserve EFR bits on update Tomasz Moń
2022-02-21 10:56 ` [PATCH 2/6] sc16is7xx: Update status lines in single call Tomasz Moń
2022-02-21 10:56 ` [PATCH 3/6] sc16is7xx: Separate GPIOs from modem control lines Tomasz Moń
2022-02-21 10:56 ` [PATCH 4/6] sc16is7xx: Properly resume TX after stop Tomasz Moń
2022-02-21 10:56 ` [PATCH 5/6] sc16is7xx: Handle modem status lines Tomasz Moń
2022-02-21 10:56 ` [PATCH 6/6] sc16is7xx: Set AUTOCTS and AUTORTS bits Tomasz Moń
2022-02-25 9:25 ` [PATCH 0/6] sc16is7xx: Hardware flow control fixes Greg Kroah-Hartman
2022-02-25 9:37 ` Tomasz Moń
2022-02-25 10:47 ` Greg Kroah-Hartman
2022-02-25 11:26 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yhi87AJy1RxIiFfO@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniel@zonque.org \
--cc=jirislaby@kernel.org \
--cc=k.drobinski@camlintechnologies.com \
--cc=l.perczak@camlintechnologies.com \
--cc=linux-serial@vger.kernel.org \
--cc=phil@raspberrypi.com \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox