From: Johan Hovold <johan@kernel.org>
To: Jonathan Woithe <jwoithe@just42.net>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
Aidan Thornton <makosoft@gmail.com>,
Grigori Goronzy <greg@chown.ath.cx>,
Michael Hanselmann <public@hansmi.ch>
Subject: Re: [Regression] CH341 USB-serial converter passes data in 32 byte chunks
Date: Mon, 18 Jul 2022 16:16:03 +0200 [thread overview]
Message-ID: <YtVrI6FRZRKKALPN@hovoldconsulting.com> (raw)
In-Reply-To: <YtUfcSOTl/ia+ahL@hovoldconsulting.com>
On Mon, Jul 18, 2022 at 10:53:06AM +0200, Johan Hovold wrote:
> From 82faf260d13c9f01e4af664f31231e5d88d7e4f1 Mon Sep 17 00:00:00 2001
> From: Johan Hovold <johan@kernel.org>
> Date: Mon, 18 Jul 2022 10:21:41 +0200
> Subject: [PATCH] USB: serial: ch341: fix disabled tx timer on older devices
>
> At least one older CH341 appears to have the TX timer enable bit
> inverted so that setting it disables the TX timer and prevents the FIFO
> from emptying until it is full.
>
> Only set the TX timer enable bit for devices with version newer than
> 0x27.
>
> Also try restoring an older init command before updating the line
> settings to see if it has any effect on a lost first byte after
> initialisation.
>
> Reported-by: Jonathan Woithe <jwoithe@just42.net>
> Link: https://lore.kernel.org/r/Ys1iPTfiZRWj2gXs@marvin.atrad.com.au
> Not-Signed-off-yet-by: Johan Hovold <johan@kernel.org>
s/TX/RX/ ...
Johan
next prev parent reply other threads:[~2022-07-18 14:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 11:59 [Regression] CH341 USB-serial converter passes data in 32 byte chunks Jonathan Woithe
2022-07-12 12:43 ` Greg KH
2022-07-12 16:53 ` Johan Hovold
2022-07-13 0:22 ` Jonathan Woithe
2022-07-18 2:49 ` Jonathan Woithe
2022-07-18 8:53 ` Johan Hovold
2022-07-18 14:16 ` Johan Hovold [this message]
2022-07-19 3:59 ` Jonathan Woithe
2022-07-19 5:53 ` Johan Hovold
2022-07-19 6:34 ` Jonathan Woithe
2022-07-19 7:20 ` Johan Hovold
2022-07-19 8:05 ` Jonathan Woithe
2022-07-19 12:18 ` Jonathan Woithe
2022-07-23 10:57 ` Johan Hovold
2022-07-25 23:45 ` Jonathan Woithe
2022-07-29 9:10 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtVrI6FRZRKKALPN@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=greg@chown.ath.cx \
--cc=gregkh@linuxfoundation.org \
--cc=jwoithe@just42.net \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=makosoft@gmail.com \
--cc=public@hansmi.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox