[tty:tty-testing 28/29] include/linux/printk.h:275:13: error: unused function 'dump_printk_buffer'

[tty:tty-testing 28/29] include/linux/printk.h:275:13: error: unused function 'dump_printk_buffer'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
head:   014e10bea593b963574d607faa34e7eaaad3c02b
commit: 558367b641b3802572132e7ed865f5eb887c41ea [28/29] printk: Add function to dump printk buffer directly to consoles
config: i386-buildonly-randconfig-006-20240207 (https://download.01.org/0day-ci/archive/20240207/202402071252.Zj78sTXN-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240207/202402071252.Zj78sTXN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402071252.Zj78sTXN-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from lib/test_bitops.c:9:
   In file included from include/linux/module.h:13:
   In file included from include/linux/stat.h:19:
   In file included from include/linux/time.h:60:
   In file included from include/linux/time32.h:13:
   In file included from include/linux/timex.h:67:
   In file included from arch/x86/include/asm/timex.h:5:
   In file included from arch/x86/include/asm/processor.h:23:
   In file included from arch/x86/include/asm/msr.h:11:
   In file included from arch/x86/include/asm/cpumask.h:5:
   In file included from include/linux/cpumask.h:10:
   In file included from include/linux/kernel.h:31:
>> include/linux/printk.h:275:13: error: unused function 'dump_printk_buffer' [-Werror,-Wunused-function]
     275 | static void dump_printk_buffer(void)
         |             ^~~~~~~~~~~~~~~~~~
   1 error generated.


vim +/dump_printk_buffer +275 include/linux/printk.h

   268	
   269	static inline void dump_stack(void)
   270	{
   271	}
   272	static inline void printk_trigger_flush(void)
   273	{
   274	}
 > 275	static void dump_printk_buffer(void)
   276	{
   277	}
   278	#endif
   279	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [tty:tty-testing 28/29] include/linux/printk.h:275:13: error: unused function 'dump_printk_buffer'

[Greg Kroah-Hartman]

On Wed, Feb 07, 2024 at 12:22:40PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> head:   014e10bea593b963574d607faa34e7eaaad3c02b
> commit: 558367b641b3802572132e7ed865f5eb887c41ea [28/29] printk: Add function to dump printk buffer directly to consoles
> config: i386-buildonly-randconfig-006-20240207 (https://download.01.org/0day-ci/archive/20240207/202402071252.Zj78sTXN-lkp@intel.com/config)
> compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240207/202402071252.Zj78sTXN-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202402071252.Zj78sTXN-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from lib/test_bitops.c:9:
>    In file included from include/linux/module.h:13:
>    In file included from include/linux/stat.h:19:
>    In file included from include/linux/time.h:60:
>    In file included from include/linux/time32.h:13:
>    In file included from include/linux/timex.h:67:
>    In file included from arch/x86/include/asm/timex.h:5:
>    In file included from arch/x86/include/asm/processor.h:23:
>    In file included from arch/x86/include/asm/msr.h:11:
>    In file included from arch/x86/include/asm/cpumask.h:5:
>    In file included from include/linux/cpumask.h:10:
>    In file included from include/linux/kernel.h:31:
> >> include/linux/printk.h:275:13: error: unused function 'dump_printk_buffer' [-Werror,-Wunused-function]
>      275 | static void dump_printk_buffer(void)
>          |             ^~~~~~~~~~~~~~~~~~
>    1 error generated.
> 
> 
> vim +/dump_printk_buffer +275 include/linux/printk.h
> 
>    268	
>    269	static inline void dump_stack(void)
>    270	{
>    271	}
>    272	static inline void printk_trigger_flush(void)
>    273	{
>    274	}
>  > 275	static void dump_printk_buffer(void)

Ah, inline was missed :(

I'll drop these from my tree for now, can you resubmit fixed patches
with all of the collected reviewed tags?

thanks,

greg k-h

Re: [tty:tty-testing 28/29] include/linux/printk.h:275:13: error: unused function 'dump_printk_buffer'

[Sreenath Vijayan]

On Wed, Feb 07, 2024 at 09:51:42AM +0000, Greg Kroah-Hartman wrote:
> On Wed, Feb 07, 2024 at 12:22:40PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> > head:   014e10bea593b963574d607faa34e7eaaad3c02b
> > commit: 558367b641b3802572132e7ed865f5eb887c41ea [28/29] printk: Add function to dump printk buffer directly to consoles
> > config: i386-buildonly-randconfig-006-20240207 (https://download.01.org/0day-ci/archive/20240207/202402071252.Zj78sTXN-lkp@intel.com/config)
> > compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240207/202402071252.Zj78sTXN-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202402071252.Zj78sTXN-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    In file included from lib/test_bitops.c:9:
> >    In file included from include/linux/module.h:13:
> >    In file included from include/linux/stat.h:19:
> >    In file included from include/linux/time.h:60:
> >    In file included from include/linux/time32.h:13:
> >    In file included from include/linux/timex.h:67:
> >    In file included from arch/x86/include/asm/timex.h:5:
> >    In file included from arch/x86/include/asm/processor.h:23:
> >    In file included from arch/x86/include/asm/msr.h:11:
> >    In file included from arch/x86/include/asm/cpumask.h:5:
> >    In file included from include/linux/cpumask.h:10:
> >    In file included from include/linux/kernel.h:31:
> > >> include/linux/printk.h:275:13: error: unused function 'dump_printk_buffer' [-Werror,-Wunused-function]
> >      275 | static void dump_printk_buffer(void)
> >          |             ^~~~~~~~~~~~~~~~~~
> >    1 error generated.
> > 
> > 
> > vim +/dump_printk_buffer +275 include/linux/printk.h
> > 
> >    268	
> >    269	static inline void dump_stack(void)
> >    270	{
> >    271	}
> >    272	static inline void printk_trigger_flush(void)
> >    273	{
> >    274	}
> >  > 275	static void dump_printk_buffer(void)
> 
> Ah, inline was missed :(
> 
> I'll drop these from my tree for now, can you resubmit fixed patches
> with all of the collected reviewed tags?
> 
> thanks,
> 
> greg k-h

Sorry for this. I will soon resubmit fixed patches with all of the
collected tags. Will add the inline as well as fix the kernel-doc
related warning reported in
https://lore.kernel.org/linux-serial/202402070957.NsPz3RBO-lkp@intel.com/T/#u

Thanks,
Sreenath