* [PATCH v1] serial: qcom-geni: fix UART_RX_PAR_EN bit position
@ 2026-04-28 4:26 Prasanna S via B4 Relay
2026-04-28 9:28 ` Konrad Dybcio
0 siblings, 1 reply; 2+ messages in thread
From: Prasanna S via B4 Relay @ 2026-04-28 4:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Sagar Dharia, Girish Mahadevan,
Karthikeyan Ramasubramanian, Doug Anderson
Cc: linux-arm-msm, linux-kernel, linux-serial, stable, Prasanna S
From: Prasanna S <prasanna.s@oss.qualcomm.com>
UART_RX_PAR_EN is incorrectly defined as bit 3, which triggers false
framing errors (S_GP_IRQ_1_EN) and causes received data to be dropped
when parity is enabled and the parity bit is 0.
Define UART_RX_PAR_EN as bit 4 of the SE_UART_RX_TRANS_CFG register, as
specified in the reference manual.
Fixes: c4f528795d1a ("tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP")
Cc: stable@vger.kernel.org
Signed-off-by: Prasanna S <prasanna.s@oss.qualcomm.com>
---
drivers/tty/serial/qcom_geni_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index b365dd5da3cb..5139a9d21b2b 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -50,7 +50,7 @@
#define TX_STOP_BIT_LEN_2 2
/* SE_UART_RX_TRANS_CFG */
-#define UART_RX_PAR_EN BIT(3)
+#define UART_RX_PAR_EN BIT(4)
/* SE_UART_RX_WORD_LEN */
#define RX_WORD_LEN_MASK GENMASK(9, 0)
---
base-commit: dd6c438c3e64a5ff0b5d7e78f7f9be547803ef1b
change-id: 20260424-serial-bit-correct-f5314b627718
Best regards,
--
Prasanna S <prasanna.s@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] serial: qcom-geni: fix UART_RX_PAR_EN bit position
2026-04-28 4:26 [PATCH v1] serial: qcom-geni: fix UART_RX_PAR_EN bit position Prasanna S via B4 Relay
@ 2026-04-28 9:28 ` Konrad Dybcio
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2026-04-28 9:28 UTC (permalink / raw)
To: prasanna.s, Greg Kroah-Hartman, Jiri Slaby, Sagar Dharia,
Girish Mahadevan, Karthikeyan Ramasubramanian, Doug Anderson
Cc: linux-arm-msm, linux-kernel, linux-serial, stable
On 4/28/26 6:26 AM, Prasanna S via B4 Relay wrote:
> From: Prasanna S <prasanna.s@oss.qualcomm.com>
>
> UART_RX_PAR_EN is incorrectly defined as bit 3, which triggers false
> framing errors (S_GP_IRQ_1_EN) and causes received data to be dropped
> when parity is enabled and the parity bit is 0.
>
> Define UART_RX_PAR_EN as bit 4 of the SE_UART_RX_TRANS_CFG register, as
> specified in the reference manual.
>
> Fixes: c4f528795d1a ("tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP")
> Cc: stable@vger.kernel.org
> Signed-off-by: Prasanna S <prasanna.s@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-28 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28 4:26 [PATCH v1] serial: qcom-geni: fix UART_RX_PAR_EN bit position Prasanna S via B4 Relay
2026-04-28 9:28 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox