From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: zjzhao <zjzhao@edatec.cn>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] serial: wk2xxx: Add WK2xxx SPI UART driver
Date: Mon, 7 Sep 2026 10:20:12 +0200 [thread overview]
Message-ID: <ap5zKvMdXmTzN__c@monoceros> (raw)
In-Reply-To: <20260904072027.67473-2-zjzhao@edatec.cn>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Fri, Sep 04, 2026 at 03:20:26PM +0800, zjzhao wrote:
> +#include <linux/mod_devicetable.h>
> ...
> +#include <linux/spi/spi.h>
Please rely on <linux/spi/spi.h> to provide spi_device_id and
of_device_id and don't include <linux/mod_devicetable.h>. (Or include
<linux/device-id/of.h> and <linux/device-id/spi.h> if you prefer.)
<linux/mod_devicetable.h> shouldn't be used as it pulls in too many
things and thus introduces many unneeded build dependencies.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-07 8:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 7:20 [PATCH 0/2] WK2xxx SPI to UART bridge driver zjzhao
2026-09-04 7:20 ` [PATCH 1/2] serial: wk2xxx: Add WK2xxx SPI UART driver zjzhao
2026-09-04 7:35 ` sashiko-bot
2026-09-04 8:17 ` Jiri Slaby
2026-09-04 9:32 ` zjzhao
2026-09-07 8:20 ` Uwe Kleine-König [this message]
2026-09-04 7:20 ` [PATCH 2/2] dt-bindings: serial: Document WK2xxx SPI UART bindings zjzhao
2026-09-04 7:28 ` sashiko-bot
2026-09-04 9:33 ` [PATCH v2 0/2] WK2xxx SPI to UART bridge driver zjzhao
2026-09-04 9:33 ` [PATCH v2 1/2] serial: wk2xxx: Add WK2xxx SPI UART driver zjzhao
2026-09-04 9:53 ` sashiko-bot
2026-09-04 9:33 ` [PATCH v2 2/2] dt-bindings: serial: Document WK2xxx SPI UART bindings zjzhao
2026-09-04 9:40 ` sashiko-bot
2026-09-05 7:31 ` Krzysztof Kozlowski
2026-09-04 10:52 ` [PATCH v3 0/2] WK2xxx SPI to UART bridge driver zjzhao
2026-09-04 10:52 ` [PATCH v3 1/2] serial: wk2xxx: Add WK2xxx SPI UART driver zjzhao
2026-09-04 11:10 ` sashiko-bot
2026-09-04 10:52 ` [PATCH v3 2/2] dt-bindings: serial: Document WK2xxx SPI UART bindings zjzhao
2026-09-04 11:12 ` sashiko-bot
2026-09-04 15:28 ` Conor Dooley
2026-09-05 7:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap5zKvMdXmTzN__c@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
--cc=zjzhao@edatec.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox