Re: [PATCH v2 4/6] serial: 8250_lpss: do not touch uninitialized line in ehl_serial_exit()

[sashiko-bot@kernel.org]

> lpss8250_probe() calls lpss->board->exit() on its error path. For the
> EHL board, that is ehl_serial_exit() and it does:
> serial8250_get_port(lpss->data.line)->dma = NULL;
> 
> But when lpss8250_dma_setup() or serial8250_register_8250_port() fails,
> lpss->data.line was never assigned. As lpss is kzalloc()ed, line is 0
> and ehl_serial_exit() clears the dma pointer of an unrelated port --
> serial8250_ports[0], i.e. ttyS0, which is often the console.
> 
> Initialize lpss->data.line to -1 in probe and skip the clearing in
> ehl_serial_exit() if no port was registered.
> 
> Fixes: 5318f70da7e8 ("serial: 8250_lpss: Balance reference count for PCI DMA device")
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791873876.git.jirislaby@kernel.org?part=4