Re: [PATCH 06/24] serial: 8250: add bounds check for line array in setup_serial()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] serial: 8250: build failure in setup_serial() due to non-existent info->line
--

commit a2e0e82dd3bc2dcce54251c9832007f4a9e30584
Author: Joshua Rogers <linux@joshua.hu>

serial: 8250: add bounds check for line array in setup_serial()

This commit adds a bounds check in setup_serial() to prevent out-of-bounds
writes when registering serial ports for a PCMCIA card.

> diff --git a/drivers/tty/serial/8250/serial_cs.c b/drivers/tty/serial/8250/serial_cs.c
> index 5dcd1544e478d..8bd88f3d6d865 100644
> --- a/drivers/tty/serial/8250/serial_cs.c
> +++ b/drivers/tty/serial/8250/serial_cs.c
> @@ -349,6 +349,11 @@ static int setup_serial(struct pcmcia_device *handle, struct serial_info *info,
>  {
>  	struct uart_8250_port uart;
>  
> +	if (info->ndev >= ARRAY_SIZE(info->line)) {
> +		dev_err(&handle->dev, "no room for more serial ports\n");
> +		return -EINVAL;
> +	}

[Severity: Low]
Does this break the build when CONFIG_SERIAL_8250_CS is enabled?

Commit d6a0791098be ("serial: 8250: make port operations work on struct
uart_8250_port") replaced line[4] with uport[4] in struct serial_info in
drivers/tty/serial/8250/serial_cs.c:

struct serial_info {
	...
	struct uart_8250_port	*uport[4];
	const struct serial_quirk *quirk;
};

and updated setup_serial() to store the registered port in info->uport:

	info->uport[info->ndev] = serial8250_register_8250_port(&uart);

Because struct serial_info no longer has a member named line, referencing
info->line in ARRAY_SIZE() fails to compile. Should this check
ARRAY_SIZE(info->uport) instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027-tty-llm-v1-0-99b0202ae546@linuxfoundation.org?part=6