Re: [PATCH 22/24] serial: samsung: put the previous baud clock

[sashiko-bot@kernel.org]

> From: Josef Bacik <josef@toxicpanda.com>
> 
> s3c24xx_serial_getclk() returns the best baud clock with the reference
> which clk_get() has taken.  s3c24xx_serial_set_termios() stores it in
> ourport->baudclk and disables the clock which was there before, but does
> not put it.
> 
> clk_get() hands out a new handle on every call, so the new clock never
> equals the old one, and every call of ->set_termios() leaks a handle: a
> struct clk and a copy of the connection name.  Whoever has the port open
> can repeat that at will with tcsetattr().
> 
> Put the old clock when it is replaced, and the new one in case it is not
> stored.
> 
> Fixes: 5f5a7a5578c5 ("serial: samsung: switch to clkdev based clock lookup")
> Cc: stable <stable@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Peter Griffin <peter.griffin@linaro.org>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Thomas Abraham <thomas.abraham@linaro.org>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027-tty-llm-v1-0-99b0202ae546@linuxfoundation.org?part=22