Intel SGX development
 help / color / mirror / Atom feed
From: "Haitao Huang" <haitao.huang@linux.intel.com>
To: "Jarkko Sakkinen" <jarkko@kernel.org>,
	dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
	linux-sgx@vger.kernel.org, "Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	"Dave Hansen" <dave.hansen@intel.com>
Cc: kai.huang@intel.com, reinette.chatre@intel.com,
	kristen@linux.intel.com, seanjc@google.com,
	stable@vger.kernel.org
Subject: Re: [PATCH] x86/sgx: fix a NULL pointer
Date: Tue, 18 Jul 2023 19:06:32 -0500	[thread overview]
Message-ID: <op.18ayk61kwjvjmi@hhuan26-mobl.amr.corp.intel.com> (raw)
In-Reply-To: <891d530f-fa84-aed7-7465-b4722e983e92@intel.com>

On Tue, 18 Jul 2023 17:05:59 -0500, Dave Hansen <dave.hansen@intel.com>  
wrote:

> On 7/18/23 14:57, Haitao Huang wrote:
>> Okay, that explains. I would consider it still triggered by high
>> pressure blips 😄
> I'm talking about a "blip" being a single allocation.  It's *LITERALLY*
> the smallest (aka. lowest) possible quantum of memory pressure.
>
> So go ahead and try to write the changelog without "high" or "low".
> But, sheesh, if you and are somehow using "high" and "low" to describe
> the exact same condition, I think that's a rather large communication or
> understanding problem somewhere.  It doesn't bode well for this simple
> patch.

Sorry that did not come across right. I'll send v3 (please skip v2) with  
the comments added as you suggested.

Thanks a lot for your time and the review.
BR
Haitao

  reply	other threads:[~2023-07-19  0:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 18:17 [PATCH] x86/sgx: fix a NULL pointer Haitao Huang
2023-07-17 18:53 ` Jarkko Sakkinen
2023-07-17 18:54   ` Jarkko Sakkinen
2023-07-17 20:29     ` Haitao Huang
2023-07-17 22:42       ` Huang, Kai
2023-07-18  0:45         ` Haitao Huang
2023-07-18  1:39           ` Huang, Kai
2023-07-18  2:42             ` Haitao Huang
2023-07-18 14:27       ` Dave Hansen
2023-07-18 18:11         ` Haitao Huang
2023-07-18 18:53           ` Dave Hansen
2023-07-18 20:32             ` Haitao Huang
2023-07-18 20:56               ` Dave Hansen
2023-07-18 21:22                 ` Haitao Huang
2023-07-18 21:36                   ` Dave Hansen
2023-07-18 21:57                     ` Haitao Huang
2023-07-18 22:05                       ` Dave Hansen
2023-07-19  0:06                         ` Haitao Huang [this message]
2023-07-19  0:14                       ` Huang, Kai
2023-07-19  0:21                         ` Dave Hansen
2023-07-19 13:53                           ` Haitao Huang
2023-07-21  0:32                             ` Huang, Kai
2023-07-21  0:52                               ` Huang, Kai
2023-07-26 16:56                                 ` Haitao Huang
2023-07-18 14:30       ` Dave Hansen
2023-07-18 16:39         ` Haitao Huang
2023-07-18 15:37       ` Jarkko Sakkinen
2023-07-18 23:11         ` Haitao Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.18ayk61kwjvjmi@hhuan26-mobl.amr.corp.intel.com \
    --to=haitao.huang@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jarkko@kernel.org \
    --cc=kai.huang@intel.com \
    --cc=kristen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sgx@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=seanjc@google.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox