Intel SGX development
 help / color / mirror / Atom feed
From: "Haitao Huang" <haitao.huang@linux.intel.com>
To: "Huang, Kai" <kai.huang@intel.com>,
	"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"jarkko@kernel.org" <jarkko@kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Dave Hansen" <dave.hansen@intel.com>
Cc: "kristen@linux.intel.com" <kristen@linux.intel.com>,
	"Chatre, Reinette" <reinette.chatre@intel.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Christopherson,, Sean" <seanjc@google.com>
Subject: Re: [PATCH] x86/sgx: fix a NULL pointer
Date: Wed, 19 Jul 2023 08:53:20 -0500	[thread overview]
Message-ID: <op.18b0u6evwjvjmi@hhuan26-mobl.amr.corp.intel.com> (raw)
In-Reply-To: <d718cdda-2d5b-9b4b-d90d-55449ec1ac75@intel.com>

Hi Dave and Kai
On Tue, 18 Jul 2023 19:21:54 -0500, Dave Hansen <dave.hansen@intel.com>  
wrote:

> On 7/18/23 17:14, Huang, Kai wrote:
>> Also perhaps the patch title is too vague.  Adding more information  
>> doesn't hurt
>> I think, e.g., mentioning it is a fix for NULL pointer dereference in  
>> the EAUG
>> flow.
>
> Yeah, let's say something like:
>
> 	x86/sgx: Resolve SECS reclaim vs. page fault race
>
The patch is not to resolve SECS vs #PF race though the race is a  
necessary condition to cause the NULL pointer. The same condition does not  
cause NULL pointer in the ELDU path of #PF, only in EAUG path of #PF.

And the issue really is the NULL pointer not checked and fix was to reuse  
the same code to reload SECS in ELDU code path for EAUG code path


How about this:

x86/sgx:  Reload reclaimed SECS for EAUG on #PF

or

x86/sgx: Fix a NULL pointer to SECS used for EAUG on #PF

BR
Haitao

  reply	other threads:[~2023-07-19 13:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 18:17 [PATCH] x86/sgx: fix a NULL pointer Haitao Huang
2023-07-17 18:53 ` Jarkko Sakkinen
2023-07-17 18:54   ` Jarkko Sakkinen
2023-07-17 20:29     ` Haitao Huang
2023-07-17 22:42       ` Huang, Kai
2023-07-18  0:45         ` Haitao Huang
2023-07-18  1:39           ` Huang, Kai
2023-07-18  2:42             ` Haitao Huang
2023-07-18 14:27       ` Dave Hansen
2023-07-18 18:11         ` Haitao Huang
2023-07-18 18:53           ` Dave Hansen
2023-07-18 20:32             ` Haitao Huang
2023-07-18 20:56               ` Dave Hansen
2023-07-18 21:22                 ` Haitao Huang
2023-07-18 21:36                   ` Dave Hansen
2023-07-18 21:57                     ` Haitao Huang
2023-07-18 22:05                       ` Dave Hansen
2023-07-19  0:06                         ` Haitao Huang
2023-07-19  0:14                       ` Huang, Kai
2023-07-19  0:21                         ` Dave Hansen
2023-07-19 13:53                           ` Haitao Huang [this message]
2023-07-21  0:32                             ` Huang, Kai
2023-07-21  0:52                               ` Huang, Kai
2023-07-26 16:56                                 ` Haitao Huang
2023-07-18 14:30       ` Dave Hansen
2023-07-18 16:39         ` Haitao Huang
2023-07-18 15:37       ` Jarkko Sakkinen
2023-07-18 23:11         ` Haitao Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.18b0u6evwjvjmi@hhuan26-mobl.amr.corp.intel.com \
    --to=haitao.huang@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jarkko@kernel.org \
    --cc=kai.huang@intel.com \
    --cc=kristen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sgx@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=seanjc@google.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox