SUPERH platform development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh-pfc: sh_pfc_probe() sizeof() fix
Date: Thu, 14 Feb 2013 12:26:42 +0000	[thread overview]
Message-ID: <136086880.YvIUptHpB2@avalon> (raw)
In-Reply-To: <20130214122347.20778.10789.sendpatchset@w520>

Hi Magnus,

Thanks for the patch.

On Thursday 14 February 2013 21:23:47 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Fix sizeof() usage in sh-pfc/core.c to allocate space
> for the full data structure instead of a pointer.

Oops :-)

This is v3.9 material. Simon, could you please take this and push it upstream 
for v3.9 ?

> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  Written against -next in renesas.git
> 
>  drivers/pinctrl/sh-pfc/core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- 0001/drivers/pinctrl/sh-pfc/core.c
> +++ work/drivers/pinctrl/sh-pfc/core.c	2013-02-14 21:04:20.000000000 +0900
> @@ -495,7 +495,7 @@ static int sh_pfc_probe(struct platform_
>  	if (info = NULL)
>  		return -ENODEV;
> 
> -	pfc = devm_kzalloc(&pdev->dev, sizeof(pfc), GFP_KERNEL);
> +	pfc = devm_kzalloc(&pdev->dev, sizeof(*pfc), GFP_KERNEL);
>  	if (pfc = NULL)
>  		return -ENOMEM;
-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2013-02-14 12:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14 12:23 [PATCH] sh-pfc: sh_pfc_probe() sizeof() fix Magnus Damm
2013-02-14 12:26 ` Laurent Pinchart [this message]
2013-02-14 12:27 ` Magnus Damm
2013-02-14 12:27 ` Laurent Pinchart
2013-02-14 15:56 ` Simon Horman
2013-02-15  1:47 ` Magnus Damm
2013-02-15 19:46 ` Linus Walleij
2013-02-16  6:14 ` Simon Horman
  -- strict thread matches above, loose matches on Subject: below --
2013-02-16  2:25 GIT PULL] Renesas ARM-based SoC pinmux for v3.9 #2 Simon Horman
2013-02-16  2:25 ` [PATCH] sh-pfc: sh_pfc_probe() sizeof() fix Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=136086880.YvIUptHpB2@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox