* [PATCH] clk: shmobile: Add r8a7793 support @ 2014-12-08 10:42 Yoshihiro Kaneko 2014-12-08 11:13 ` Geert Uytterhoeven 0 siblings, 1 reply; 8+ messages in thread From: Yoshihiro Kaneko @ 2014-12-08 10:42 UTC (permalink / raw) To: linux-arm-kernel From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver. Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> --- This patch is based on renesas/devel. drivers/clk/shmobile/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/shmobile/Makefile b/drivers/clk/shmobile/Makefile index 960bf22..3cc716d 100644 --- a/drivers/clk/shmobile/Makefile +++ b/drivers/clk/shmobile/Makefile @@ -4,6 +4,7 @@ obj-$(CONFIG_ARCH_R8A7740) += clk-r8a7740.o obj-$(CONFIG_ARCH_R8A7779) += clk-r8a7779.o obj-$(CONFIG_ARCH_R8A7790) += clk-rcar-gen2.o obj-$(CONFIG_ARCH_R8A7791) += clk-rcar-gen2.o +obj-$(CONFIG_ARCH_R8A7793) += clk-rcar-gen2.o obj-$(CONFIG_ARCH_R8A7794) += clk-rcar-gen2.o obj-$(CONFIG_ARCH_SHMOBILE_MULTI) += clk-div6.o obj-$(CONFIG_ARCH_SHMOBILE_MULTI) += clk-mstp.o -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] clk: shmobile: Add r8a7793 support 2014-12-08 10:42 [PATCH] clk: shmobile: Add r8a7793 support Yoshihiro Kaneko @ 2014-12-08 11:13 ` Geert Uytterhoeven 2014-12-08 11:53 ` Yoshihiro Kaneko 0 siblings, 1 reply; 8+ messages in thread From: Geert Uytterhoeven @ 2014-12-08 11:13 UTC (permalink / raw) To: linux-arm-kernel Hi Kaneko-san, On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > > R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver. Thanks for your patch! > Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Can you please also send a patch to update the binding documentation in Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt? Thanks again! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clk: shmobile: Add r8a7793 support 2014-12-08 11:13 ` Geert Uytterhoeven @ 2014-12-08 11:53 ` Yoshihiro Kaneko 2014-12-08 13:30 ` Geert Uytterhoeven 0 siblings, 1 reply; 8+ messages in thread From: Yoshihiro Kaneko @ 2014-12-08 11:53 UTC (permalink / raw) To: linux-arm-kernel Hi Geert-san, 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>: > Hi Kaneko-san, > > On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: >> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> >> >> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver. > > Thanks for your patch! > >> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> >> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Can you please also send a patch to update the binding documentation in > Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt? This patch updates Makefile only, not added dtsi for r8a7793. Is the update of the document necessary? Thanks, Kaneko > > Thanks again! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clk: shmobile: Add r8a7793 support 2014-12-08 11:53 ` Yoshihiro Kaneko @ 2014-12-08 13:30 ` Geert Uytterhoeven 2014-12-09 0:23 ` Simon Horman 0 siblings, 1 reply; 8+ messages in thread From: Geert Uytterhoeven @ 2014-12-08 13:30 UTC (permalink / raw) To: linux-arm-kernel Hi Kaneko-san, On Mon, Dec 8, 2014 at 12:53 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>: >> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: >>> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> >>> >>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver. >> >> Thanks for your patch! >> >>> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> >>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> Can you please also send a patch to update the binding documentation in >> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt? > > This patch updates Makefile only, not added dtsi for r8a7793. > Is the update of the document necessary? Not at this moment. I was just trying to be proactive ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clk: shmobile: Add r8a7793 support 2014-12-08 13:30 ` Geert Uytterhoeven @ 2014-12-09 0:23 ` Simon Horman 2014-12-09 12:26 ` Yoshihiro Kaneko 0 siblings, 1 reply; 8+ messages in thread From: Simon Horman @ 2014-12-09 0:23 UTC (permalink / raw) To: linux-arm-kernel On Mon, Dec 08, 2014 at 02:30:14PM +0100, Geert Uytterhoeven wrote: > Hi Kaneko-san, > > On Mon, Dec 8, 2014 at 12:53 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > > 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>: > >> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > >>> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > >>> > >>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver. > >> > >> Thanks for your patch! > >> > >>> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > >>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > >> > >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> > >> Can you please also send a patch to update the binding documentation in > >> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt? > > > > This patch updates Makefile only, not added dtsi for r8a7793. > > Is the update of the document necessary? > > Not at this moment. I was just trying to be proactive ;-) Kaneko-san, I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a one line change. I can prepare a patch if you prefer not to. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clk: shmobile: Add r8a7793 support 2014-12-09 0:23 ` Simon Horman @ 2014-12-09 12:26 ` Yoshihiro Kaneko 2014-12-10 0:18 ` Simon Horman 0 siblings, 1 reply; 8+ messages in thread From: Yoshihiro Kaneko @ 2014-12-09 12:26 UTC (permalink / raw) To: linux-arm-kernel Hi Simon-san, 2014-12-09 9:23 GMT+09:00 Simon Horman <horms@verge.net.au>: > On Mon, Dec 08, 2014 at 02:30:14PM +0100, Geert Uytterhoeven wrote: >> Hi Kaneko-san, >> >> On Mon, Dec 8, 2014 at 12:53 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: >> > 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>: >> >> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: >> >>> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> >> >>> >> >>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver. >> >> >> >> Thanks for your patch! >> >> >> >>> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> >> >>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> >> >> >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> >> >> Can you please also send a patch to update the binding documentation in >> >> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt? >> > >> > This patch updates Makefile only, not added dtsi for r8a7793. >> > Is the update of the document necessary? >> >> Not at this moment. I was just trying to be proactive ;-) > > Kaneko-san, > > I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a > one line change. I can prepare a patch if you prefer not to. Yes, I know that the update is very small. But "renesas,r8a7793-cpg-clocks" which will be added to the documentation was not found anywhere in the source tree. For example, "renesas,r8a7794-cpg-clocks" is found in arch/arm/boot/dts/r8a7794.dtsi. Is r8a7793.dtsi not necessary to update the document? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clk: shmobile: Add r8a7793 support 2014-12-09 12:26 ` Yoshihiro Kaneko @ 2014-12-10 0:18 ` Simon Horman 2014-12-10 11:25 ` Yoshihiro Kaneko 0 siblings, 1 reply; 8+ messages in thread From: Simon Horman @ 2014-12-10 0:18 UTC (permalink / raw) To: linux-arm-kernel On Tue, Dec 09, 2014 at 09:26:09PM +0900, Yoshihiro Kaneko wrote: > Hi Simon-san, > > 2014-12-09 9:23 GMT+09:00 Simon Horman <horms@verge.net.au>: > > On Mon, Dec 08, 2014 at 02:30:14PM +0100, Geert Uytterhoeven wrote: > >> Hi Kaneko-san, > >> > >> On Mon, Dec 8, 2014 at 12:53 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > >> > 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>: > >> >> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > >> >>> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > >> >>> > >> >>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver. > >> >> > >> >> Thanks for your patch! > >> >> > >> >>> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > >> >>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > >> >> > >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> >> > >> >> Can you please also send a patch to update the binding documentation in > >> >> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt? > >> > > >> > This patch updates Makefile only, not added dtsi for r8a7793. > >> > Is the update of the document necessary? > >> > >> Not at this moment. I was just trying to be proactive ;-) > > > > Kaneko-san, > > > > I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a > > one line change. I can prepare a patch if you prefer not to. > > Yes, I know that the update is very small. > But "renesas,r8a7793-cpg-clocks" which will be added to the documentation > was not found anywhere in the source tree. For example, > "renesas,r8a7794-cpg-clocks" > is found in arch/arm/boot/dts/r8a7794.dtsi. > Is r8a7793.dtsi not necessary to update the document? In theory (though not always in practice) bindings should be documented before they are used. So unless I misunderstand things, yes, I think renesas,rcar-gen2-cpg-clocks.txt should be updated even though arch/arm/boot/dts/r8a7794.dtsi is (not yet) updated. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clk: shmobile: Add r8a7793 support 2014-12-10 0:18 ` Simon Horman @ 2014-12-10 11:25 ` Yoshihiro Kaneko 0 siblings, 0 replies; 8+ messages in thread From: Yoshihiro Kaneko @ 2014-12-10 11:25 UTC (permalink / raw) To: linux-arm-kernel 2014-12-10 9:18 GMT+09:00 Simon Horman <horms@verge.net.au>: > On Tue, Dec 09, 2014 at 09:26:09PM +0900, Yoshihiro Kaneko wrote: >> Hi Simon-san, >> >> 2014-12-09 9:23 GMT+09:00 Simon Horman <horms@verge.net.au>: >> > On Mon, Dec 08, 2014 at 02:30:14PM +0100, Geert Uytterhoeven wrote: >> >> Hi Kaneko-san, >> >> >> >> On Mon, Dec 8, 2014 at 12:53 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: >> >> > 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>: >> >> >> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: >> >> >>> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> >> >> >>> >> >> >>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver. >> >> >> >> >> >> Thanks for your patch! >> >> >> >> >> >>> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> >> >> >>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> >> >> >> >> >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> >> >> >> >> Can you please also send a patch to update the binding documentation in >> >> >> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt? >> >> > >> >> > This patch updates Makefile only, not added dtsi for r8a7793. >> >> > Is the update of the document necessary? >> >> >> >> Not at this moment. I was just trying to be proactive ;-) >> > >> > Kaneko-san, >> > >> > I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a >> > one line change. I can prepare a patch if you prefer not to. >> >> Yes, I know that the update is very small. >> But "renesas,r8a7793-cpg-clocks" which will be added to the documentation >> was not found anywhere in the source tree. For example, >> "renesas,r8a7794-cpg-clocks" >> is found in arch/arm/boot/dts/r8a7794.dtsi. >> Is r8a7793.dtsi not necessary to update the document? > > In theory (though not always in practice) bindings should > be documented before they are used. So unless I misunderstand things, > yes, I think renesas,rcar-gen2-cpg-clocks.txt should be updated > even though arch/arm/boot/dts/r8a7794.dtsi is (not yet) updated. I got it. I can prepare a patch which updates the binding document. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-12-10 11:25 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-12-08 10:42 [PATCH] clk: shmobile: Add r8a7793 support Yoshihiro Kaneko 2014-12-08 11:13 ` Geert Uytterhoeven 2014-12-08 11:53 ` Yoshihiro Kaneko 2014-12-08 13:30 ` Geert Uytterhoeven 2014-12-09 0:23 ` Simon Horman 2014-12-09 12:26 ` Yoshihiro Kaneko 2014-12-10 0:18 ` Simon Horman 2014-12-10 11:25 ` Yoshihiro Kaneko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox