From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC][PATCH] sh-pfc: r8a7779: tidyup intc_irq3_b typo
Date: Mon, 08 Apr 2013 09:41:05 +0000 [thread overview]
Message-ID: <1526271.cx8ciUsg4Q@avalon> (raw)
In-Reply-To: <87obdpohxx.wl%kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
On Sunday 07 April 2013 19:49:17 Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>
> >> Laurent
>
> Now, I'm studying about sh pinctrol code.
> So, I can't have firm belief about this patch.
> But maybe it was typo
It's definitely a typo, thank you for pointing it out.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Simon, this is a bug fix, could you please push it to v3.10 ?
> drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c index 62dcdcd..791a671 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> @@ -2552,7 +2552,7 @@ static const char * const intc_groups[] = {
> "intc_irq2",
> "intc_irq2_b",
> "intc_irq3",
> - "intc_irq4_b",
> + "intc_irq3_b",
> };
>
> static const char * const lbsc_groups[] = {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-04-08 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 2:49 [RFC][PATCH] sh-pfc: r8a7779: tidyup intc_irq3_b typo Kuninori Morimoto
2013-04-08 9:41 ` Laurent Pinchart [this message]
2013-04-09 8:48 ` Simon Horman
2013-04-09 8:53 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526271.cx8ciUsg4Q@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox