SUPERH platform development
 help / color / mirror / Atom feed
* [RFC][PATCH] sh-pfc: r8a7779: tidyup intc_irq3_b typo
@ 2013-04-08  2:49 Kuninori Morimoto
  2013-04-08  9:41 ` Laurent Pinchart
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2013-04-08  2:49 UTC (permalink / raw)
  To: linux-sh

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
>> Laurent

Now, I'm studying about sh pinctrol code.
So, I can't have firm belief about this patch.
But maybe it was typo

 drivers/pinctrl/sh-pfc/pfc-r8a7779.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
index 62dcdcd..791a671 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
@@ -2552,7 +2552,7 @@ static const char * const intc_groups[] = {
 	"intc_irq2",
 	"intc_irq2_b",
 	"intc_irq3",
-	"intc_irq4_b",
+	"intc_irq3_b",
 };
 
 static const char * const lbsc_groups[] = {
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [RFC][PATCH] sh-pfc: r8a7779: tidyup intc_irq3_b typo
  2013-04-08  2:49 [RFC][PATCH] sh-pfc: r8a7779: tidyup intc_irq3_b typo Kuninori Morimoto
@ 2013-04-08  9:41 ` Laurent Pinchart
  2013-04-09  8:48 ` Simon Horman
  2013-04-09  8:53 ` Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2013-04-08  9:41 UTC (permalink / raw)
  To: linux-sh

Hi Morimoto-san,

On Sunday 07 April 2013 19:49:17 Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> 
> >> Laurent
> 
> Now, I'm studying about sh pinctrol code.
> So, I can't have firm belief about this patch.
> But maybe it was typo

It's definitely a typo, thank you for pointing it out.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Simon, this is a bug fix, could you please push it to v3.10 ?

>  drivers/pinctrl/sh-pfc/pfc-r8a7779.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c index 62dcdcd..791a671 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> @@ -2552,7 +2552,7 @@ static const char * const intc_groups[] = {
>  	"intc_irq2",
>  	"intc_irq2_b",
>  	"intc_irq3",
> -	"intc_irq4_b",
> +	"intc_irq3_b",
>  };
> 
>  static const char * const lbsc_groups[] = {

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFC][PATCH] sh-pfc: r8a7779: tidyup intc_irq3_b typo
  2013-04-08  2:49 [RFC][PATCH] sh-pfc: r8a7779: tidyup intc_irq3_b typo Kuninori Morimoto
  2013-04-08  9:41 ` Laurent Pinchart
@ 2013-04-09  8:48 ` Simon Horman
  2013-04-09  8:53 ` Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2013-04-09  8:48 UTC (permalink / raw)
  To: linux-sh

On Mon, Apr 08, 2013 at 11:41:05AM +0200, Laurent Pinchart wrote:
> Hi Morimoto-san,
> 
> On Sunday 07 April 2013 19:49:17 Kuninori Morimoto wrote:
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > 
> > >> Laurent
> > 
> > Now, I'm studying about sh pinctrol code.
> > So, I can't have firm belief about this patch.
> > But maybe it was typo
> 
> It's definitely a typo, thank you for pointing it out.
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Simon, this is a bug fix, could you please push it to v3.10 ?

Sure. I have queued it up in the pinmux branch which currently contains
no other changes that aren't in arm-soc. I will send a pull request in
the not to distant future, most likely tomorrow.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFC][PATCH] sh-pfc: r8a7779: tidyup intc_irq3_b typo
  2013-04-08  2:49 [RFC][PATCH] sh-pfc: r8a7779: tidyup intc_irq3_b typo Kuninori Morimoto
  2013-04-08  9:41 ` Laurent Pinchart
  2013-04-09  8:48 ` Simon Horman
@ 2013-04-09  8:53 ` Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2013-04-09  8:53 UTC (permalink / raw)
  To: linux-sh

On Tue, Apr 09, 2013 at 05:48:28PM +0900, Simon Horman wrote:
> On Mon, Apr 08, 2013 at 11:41:05AM +0200, Laurent Pinchart wrote:
> > Hi Morimoto-san,
> > 
> > On Sunday 07 April 2013 19:49:17 Kuninori Morimoto wrote:
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > > 
> > > >> Laurent
> > > 
> > > Now, I'm studying about sh pinctrol code.
> > > So, I can't have firm belief about this patch.
> > > But maybe it was typo
> > 
> > It's definitely a typo, thank you for pointing it out.
> > 
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > Simon, this is a bug fix, could you please push it to v3.10 ?
> 
> Sure. I have queued it up in the pinmux branch which currently contains
> no other changes that aren't in arm-soc. I will send a pull request in
> the not to distant future, most likely tomorrow.

s/pinmux/pinmux-fixes/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-04-09  8:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-08  2:49 [RFC][PATCH] sh-pfc: r8a7779: tidyup intc_irq3_b typo Kuninori Morimoto
2013-04-08  9:41 ` Laurent Pinchart
2013-04-09  8:48 ` Simon Horman
2013-04-09  8:53 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox