SUPERH platform development
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: shmobile: r8a7740: Add TPU clock entry for DT platforms
@ 2013-07-25 22:50 Laurent Pinchart
  2013-07-30  2:26 ` Simon Horman
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-07-25 22:50 UTC (permalink / raw)
  To: linux-sh

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm/mach-shmobile/clock-r8a7740.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c b/arch/arm/mach-shmobile/clock-r8a7740.c
index f4265e5..c826bca 100644
--- a/arch/arm/mach-shmobile/clock-r8a7740.c
+++ b/arch/arm/mach-shmobile/clock-r8a7740.c
@@ -597,6 +597,7 @@ static struct clk_lookup lookups[] = {
 	CLKDEV_DEV_ID("r8a7740-gether",		&mstp_clks[MSTP309]),
 	CLKDEV_DEV_ID("e9a00000.sh-eth",	&mstp_clks[MSTP309]),
 	CLKDEV_DEV_ID("renesas-tpu-pwm",	&mstp_clks[MSTP304]),
+	CLKDEV_DEV_ID("e6600000.pwm",		&mstp_clks[MSTP304]),
 
 	CLKDEV_DEV_ID("sh_mobile_sdhi.2",	&mstp_clks[MSTP415]),
 	CLKDEV_DEV_ID("e6870000.sdhi",          &mstp_clks[MSTP415]),
-- 
1.8.1.5


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: shmobile: r8a7740: Add TPU clock entry for DT platforms
  2013-07-25 22:50 [PATCH 1/2] ARM: shmobile: r8a7740: Add TPU clock entry for DT platforms Laurent Pinchart
@ 2013-07-30  2:26 ` Simon Horman
  2013-07-30  9:21 ` Laurent Pinchart
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-07-30  2:26 UTC (permalink / raw)
  To: linux-sh

On Fri, Jul 26, 2013 at 12:50:59AM +0200, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  arch/arm/mach-shmobile/clock-r8a7740.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c b/arch/arm/mach-shmobile/clock-r8a7740.c
> index f4265e5..c826bca 100644
> --- a/arch/arm/mach-shmobile/clock-r8a7740.c
> +++ b/arch/arm/mach-shmobile/clock-r8a7740.c
> @@ -597,6 +597,7 @@ static struct clk_lookup lookups[] = {
>  	CLKDEV_DEV_ID("r8a7740-gether",		&mstp_clks[MSTP309]),
>  	CLKDEV_DEV_ID("e9a00000.sh-eth",	&mstp_clks[MSTP309]),
>  	CLKDEV_DEV_ID("renesas-tpu-pwm",	&mstp_clks[MSTP304]),

In my tree I seem to have "renesas_tpu_pwm" instead of "renesas-tpu-pwm".
Which is correct?

> +	CLKDEV_DEV_ID("e6600000.pwm",		&mstp_clks[MSTP304]),
>  
>  	CLKDEV_DEV_ID("sh_mobile_sdhi.2",	&mstp_clks[MSTP415]),
>  	CLKDEV_DEV_ID("e6870000.sdhi",          &mstp_clks[MSTP415]),
> -- 
> 1.8.1.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: shmobile: r8a7740: Add TPU clock entry for DT platforms
  2013-07-25 22:50 [PATCH 1/2] ARM: shmobile: r8a7740: Add TPU clock entry for DT platforms Laurent Pinchart
  2013-07-30  2:26 ` Simon Horman
@ 2013-07-30  9:21 ` Laurent Pinchart
  2013-07-31  1:37 ` Simon Horman
  2013-07-31  1:46 ` Simon Horman
  3 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-07-30  9:21 UTC (permalink / raw)
  To: linux-sh

Hi Simon,

On Tuesday 30 July 2013 11:26:22 Simon Horman wrote:
> On Fri, Jul 26, 2013 at 12:50:59AM +0200, Laurent Pinchart wrote:
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm/mach-shmobile/clock-r8a7740.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c
> > b/arch/arm/mach-shmobile/clock-r8a7740.c index f4265e5..c826bca 100644
> > --- a/arch/arm/mach-shmobile/clock-r8a7740.c
> > +++ b/arch/arm/mach-shmobile/clock-r8a7740.c
> > @@ -597,6 +597,7 @@ static struct clk_lookup lookups[] = {
> > 
> >  	CLKDEV_DEV_ID("r8a7740-gether",		&mstp_clks[MSTP309]),
> >  	CLKDEV_DEV_ID("e9a00000.sh-eth",	&mstp_clks[MSTP309]),
> >  	CLKDEV_DEV_ID("renesas-tpu-pwm",	&mstp_clks[MSTP304]),
> 
> In my tree I seem to have "renesas_tpu_pwm" instead of "renesas-tpu-pwm".
> Which is correct?

The correct one is "renesas-tpu-pwm" (http://gitorious.org/linux-pwm/linux-pwm/blobs/for-next/drivers/pwm/pwm-renesas-tpu.c#line464).

> > +	CLKDEV_DEV_ID("e6600000.pwm",		&mstp_clks[MSTP304]),
> > 
> >  	CLKDEV_DEV_ID("sh_mobile_sdhi.2",	&mstp_clks[MSTP415]),
> >  	CLKDEV_DEV_ID("e6870000.sdhi",          &mstp_clks[MSTP415]),

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: shmobile: r8a7740: Add TPU clock entry for DT platforms
  2013-07-25 22:50 [PATCH 1/2] ARM: shmobile: r8a7740: Add TPU clock entry for DT platforms Laurent Pinchart
  2013-07-30  2:26 ` Simon Horman
  2013-07-30  9:21 ` Laurent Pinchart
@ 2013-07-31  1:37 ` Simon Horman
  2013-07-31  1:46 ` Simon Horman
  3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-07-31  1:37 UTC (permalink / raw)
  To: linux-sh

On Tue, Jul 30, 2013 at 11:21:54AM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Tuesday 30 July 2013 11:26:22 Simon Horman wrote:
> > On Fri, Jul 26, 2013 at 12:50:59AM +0200, Laurent Pinchart wrote:
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > > ---
> > > 
> > >  arch/arm/mach-shmobile/clock-r8a7740.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c
> > > b/arch/arm/mach-shmobile/clock-r8a7740.c index f4265e5..c826bca 100644
> > > --- a/arch/arm/mach-shmobile/clock-r8a7740.c
> > > +++ b/arch/arm/mach-shmobile/clock-r8a7740.c
> > > @@ -597,6 +597,7 @@ static struct clk_lookup lookups[] = {
> > > 
> > >  	CLKDEV_DEV_ID("r8a7740-gether",		&mstp_clks[MSTP309]),
> > >  	CLKDEV_DEV_ID("e9a00000.sh-eth",	&mstp_clks[MSTP309]),
> > >  	CLKDEV_DEV_ID("renesas-tpu-pwm",	&mstp_clks[MSTP304]),
> > 
> > In my tree I seem to have "renesas_tpu_pwm" instead of "renesas-tpu-pwm".
> > Which is correct?
> 
> The correct one is "renesas-tpu-pwm" (http://gitorious.org/linux-pwm/linux-pwm/blobs/for-next/drivers/pwm/pwm-renesas-tpu.c#line464).

Thanks, I see this is resolved in
"ARM: shmobile: r8a7740: Fix TPU clock name".
I do have that in my tree but not in the tpu-pwm branch,
which is where I was looking.

> > > +	CLKDEV_DEV_ID("e6600000.pwm",		&mstp_clks[MSTP304]),
> > > 
> > >  	CLKDEV_DEV_ID("sh_mobile_sdhi.2",	&mstp_clks[MSTP415]),
> > >  	CLKDEV_DEV_ID("e6870000.sdhi",          &mstp_clks[MSTP415]),
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: shmobile: r8a7740: Add TPU clock entry for DT platforms
  2013-07-25 22:50 [PATCH 1/2] ARM: shmobile: r8a7740: Add TPU clock entry for DT platforms Laurent Pinchart
                   ` (2 preceding siblings ...)
  2013-07-31  1:37 ` Simon Horman
@ 2013-07-31  1:46 ` Simon Horman
  3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-07-31  1:46 UTC (permalink / raw)
  To: linux-sh

On Wed, Jul 31, 2013 at 10:37:56AM +0900, Simon Horman wrote:
> On Tue, Jul 30, 2013 at 11:21:54AM +0200, Laurent Pinchart wrote:
> > Hi Simon,
> > 
> > On Tuesday 30 July 2013 11:26:22 Simon Horman wrote:
> > > On Fri, Jul 26, 2013 at 12:50:59AM +0200, Laurent Pinchart wrote:
> > > > Signed-off-by: Laurent Pinchart
> > > > <laurent.pinchart+renesas@ideasonboard.com>
> > > > ---
> > > > 
> > > >  arch/arm/mach-shmobile/clock-r8a7740.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c
> > > > b/arch/arm/mach-shmobile/clock-r8a7740.c index f4265e5..c826bca 100644
> > > > --- a/arch/arm/mach-shmobile/clock-r8a7740.c
> > > > +++ b/arch/arm/mach-shmobile/clock-r8a7740.c
> > > > @@ -597,6 +597,7 @@ static struct clk_lookup lookups[] = {
> > > > 
> > > >  	CLKDEV_DEV_ID("r8a7740-gether",		&mstp_clks[MSTP309]),
> > > >  	CLKDEV_DEV_ID("e9a00000.sh-eth",	&mstp_clks[MSTP309]),
> > > >  	CLKDEV_DEV_ID("renesas-tpu-pwm",	&mstp_clks[MSTP304]),
> > > 
> > > In my tree I seem to have "renesas_tpu_pwm" instead of "renesas-tpu-pwm".
> > > Which is correct?
> > 
> > The correct one is "renesas-tpu-pwm" (http://gitorious.org/linux-pwm/linux-pwm/blobs/for-next/drivers/pwm/pwm-renesas-tpu.c#line464).
> 
> Thanks, I see this is resolved in
> "ARM: shmobile: r8a7740: Fix TPU clock name".
> I do have that in my tree but not in the tpu-pwm branch,
> which is where I was looking.

I will merge renesas-fixes-for-v3.12 into the tpu-pwm branch
and queue this patch up for v3.12 there.

> 
> > > > +	CLKDEV_DEV_ID("e6600000.pwm",		&mstp_clks[MSTP304]),
> > > > 
> > > >  	CLKDEV_DEV_ID("sh_mobile_sdhi.2",	&mstp_clks[MSTP415]),
> > > >  	CLKDEV_DEV_ID("e6870000.sdhi",          &mstp_clks[MSTP415]),
> > 
> > -- 
> > Regards,
> > 
> > Laurent Pinchart
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-07-31  1:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-25 22:50 [PATCH 1/2] ARM: shmobile: r8a7740: Add TPU clock entry for DT platforms Laurent Pinchart
2013-07-30  2:26 ` Simon Horman
2013-07-30  9:21 ` Laurent Pinchart
2013-07-31  1:37 ` Simon Horman
2013-07-31  1:46 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox