[PATCH 0/3] Renesas serial sh-sci DT fixes

[PATCH 0/3] Renesas serial sh-sci DT fixes

[Laurent Pinchart]

Hello,

These three patches fix issues with the sh-sci DT support.

The first patch fixes a typo in the DT bindings documentation example. The two
other patches fix issues in the r8a7790 serial port DT nodes caused by merging
work in progress version of DT support instead of the latest available one.

The first two patches are candidates for v3.14-rc. I'd like to third patch to
join them if possible.

Simon, could you please pick them up ? The first patch touches DT bindings
documentation so I've CC'ed the devicetree mailing list, but the fix is so
trivial that I don't think the DT bindings maintainers' Ack is required.

Laurent Pinchart (3):
  serial: sh-sci: Fix compatible string in DT bindings example
  ARM: shmobile: r8a7790: Fix serial ports DT compatible strings
  ARM: shmobile: r8a7790: Replace IRQ type numerical values with macros

 .../bindings/serial/renesas,sci-serial.txt         |  2 +-
 arch/arm/boot/dts/r8a7790.dtsi                     | 40 +++++++++++-----------
 2 files changed, 21 insertions(+), 21 deletions(-)

-- 
Regards,

Laurent Pinchart

[PATCH 1/3] serial: sh-sci: Fix compatible string in DT bindings example

[Laurent Pinchart]

Remove the -generic suffix from the compatible string in the serial port
DT bindings example.

Cc: devicetree@vger.kernel.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
index f372cf2..53e6c17 100644
--- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
+++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
@@ -37,7 +37,7 @@ Example:
 	};
 
 	scifa0: serial@e6c40000 {
-		compatible = "renesas,scifa-r8a7790", "renesas,scifa-generic";
+		compatible = "renesas,scifa-r8a7790", "renesas,scifa";
 		reg = <0 0xe6c40000 0 64>;
 		interrupt-parent = <&gic>;
 		interrupts = <0 144 IRQ_TYPE_LEVEL_HIGH>;
-- 
1.8.3.2

Re: [PATCH 0/3] Renesas serial sh-sci DT fixes

[Simon Horman]

On Tue, Jan 21, 2014 at 01:48:36PM +0100, Laurent Pinchart wrote:
> Hello,
> 
> These three patches fix issues with the sh-sci DT support.
> 
> The first patch fixes a typo in the DT bindings documentation example. The two
> other patches fix issues in the r8a7790 serial port DT nodes caused by merging
> work in progress version of DT support instead of the latest available one.
> 
> The first two patches are candidates for v3.14-rc. I'd like to third patch to
> join them if possible.

Forgive me for blase but these changes seem to be more on the
cosmetic side than on the fixing problems side. I'm more inclined to
queue them up for v3.15 than v3.14-rc.

> 
> Simon, could you please pick them up ? The first patch touches DT bindings
> documentation so I've CC'ed the devicetree mailing list, but the fix is so
> trivial that I don't think the DT bindings maintainers' Ack is required.

Agreed.

Re: [PATCH 0/3] Renesas serial sh-sci DT fixes

[Laurent Pinchart]

Hi Simon,

On Wednesday 22 January 2014 09:34:56 Simon Horman wrote:
> On Tue, Jan 21, 2014 at 01:48:36PM +0100, Laurent Pinchart wrote:
> > Hello,
> > 
> > These three patches fix issues with the sh-sci DT support.
> > 
> > The first patch fixes a typo in the DT bindings documentation example. The
> > two other patches fix issues in the r8a7790 serial port DT nodes caused
> > by merging work in progress version of DT support instead of the latest
> > available one.
> > 
> > The first two patches are candidates for v3.14-rc. I'd like to third patch
> > to join them if possible.
> 
> Forgive me for blase

I'll try to forgive you :-)

> but these changes seem to be more on the cosmetic side than on the fixing
> problems side. I'm more inclined to queue them up for v3.15 than v3.14-rc.

Given that the serial devices are disabled the problems shouldn't cause any 
issue, indeed. I was more concerned about someone enabling them and having 
incorrect DTs in the wild, but I suppose that's not likely.

> > Simon, could you please pick them up ? The first patch touches DT bindings
> > documentation so I've CC'ed the devicetree mailing list, but the fix is so
> > trivial that I don't think the DT bindings maintainers' Ack is required.
> 
> Agreed.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/3] Renesas serial sh-sci DT fixes

[Simon Horman]

On Wed, Jan 22, 2014 at 10:51:38AM +0100, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Wednesday 22 January 2014 09:34:56 Simon Horman wrote:
> > On Tue, Jan 21, 2014 at 01:48:36PM +0100, Laurent Pinchart wrote:
> > > Hello,
> > > 
> > > These three patches fix issues with the sh-sci DT support.
> > > 
> > > The first patch fixes a typo in the DT bindings documentation example. The
> > > two other patches fix issues in the r8a7790 serial port DT nodes caused
> > > by merging work in progress version of DT support instead of the latest
> > > available one.
> > > 
> > > The first two patches are candidates for v3.14-rc. I'd like to third patch
> > > to join them if possible.
> > 
> > Forgive me for blase
> 
> I'll try to forgive you :-)
> 
> > but these changes seem to be more on the cosmetic side than on the fixing
> > problems side. I'm more inclined to queue them up for v3.15 than v3.14-rc.
> 
> Given that the serial devices are disabled the problems shouldn't cause any 
> issue, indeed. I was more concerned about someone enabling them and having 
> incorrect DTs in the wild, but I suppose that's not likely.

Agreed.

I have queued up this series for v3.15.