[PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator

SUPERH platform development
 help / color / mirror / Atom feed

* [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator
@ 2013-04-29 11:12 Laurent Pinchart
  2013-05-03  7:42 ` Linus Walleij
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Laurent Pinchart @ 2013-04-29 11:12 UTC (permalink / raw)
  To: linux-sh

Hello,

The sh73a0 has an internal power gate on the VCCQ power supply for the SDHI0
device that is controlled (for some strange reason) by a bit in a PFC
register.

This patch set exposes the power gate as a regulator. As the only currently
supported board (kzm9g) has the VCCQ_MC0 pins directly connected to an always
on 3.3V supply, the code assumes that the external VCCQ power supply can't be
controlled. This could be fixed later by setting the regulator supply name.

As this series turns the power off when not needed it might bring additional
power saving, but this hasn't been measured. If the patches are considered too
complex a simpler approach would be to turn the power gate on when the SDHI
function is selected.

The patches are based on Simon's pinmux branch minus the first 4 commits that
contain v2 of this series (commit 285c84732bd6f71946d3d2c4514c43cefd77f567 -
"ARM: shmobile: sh73a0 pinmux platform device cleanup"). Simon, please tell me
if you would prefer a follow-up patch on your pinmux branch instead.

Changes compared to v2:

- Renamed the cleanup operation to exit

Changes compared to v1:

- Renamed __sh73a0_vccq_mc0_enable to sh73a0_vccq_mc0_endisable
- Fix the reported voltage value (3.3V instead of 1.8V)
- Make patch 2/4 commit message more explicit

Laurent Pinchart (4):
  sh-pfc: Add support for SoC-specific initialization
  sh-pfc: sh73a0: Add VCCQ MC0 regulator
  ARM: shmobile: kzm9g: Remove the VCCQ MC0 function GPIO
  ARM: shmobile: kzm9g-reference: Remove the VCCQ MC0 function GPIO

 arch/arm/mach-shmobile/board-kzm9g-reference.c |   1 -
 arch/arm/mach-shmobile/board-kzm9g.c           |   3 -
 drivers/pinctrl/sh-pfc/Kconfig                 |   1 +
 drivers/pinctrl/sh-pfc/core.c                  |  16 ++-
 drivers/pinctrl/sh-pfc/core.h                  |   1 +
 drivers/pinctrl/sh-pfc/pfc-sh73a0.c            | 134 +++++++++++++++++++++++++
 drivers/pinctrl/sh-pfc/sh_pfc.h                |   2 +
 7 files changed, 153 insertions(+), 5 deletions(-)

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator
  2013-04-29 11:12 [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator Laurent Pinchart
@ 2013-05-03  7:42 ` Linus Walleij
  2013-05-03  9:56 ` Laurent Pinchart
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2013-05-03  7:42 UTC (permalink / raw)
  To: linux-sh

On Mon, Apr 29, 2013 at 1:12 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:

> Changes compared to v2:
>
> - Renamed the cleanup operation to exit

This is fine.
The series:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator
  2013-04-29 11:12 [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator Laurent Pinchart
  2013-05-03  7:42 ` Linus Walleij
@ 2013-05-03  9:56 ` Laurent Pinchart
  2013-05-07 11:29 ` Simon Horman
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2013-05-03  9:56 UTC (permalink / raw)
  To: linux-sh

Hi Linus,

On Friday 03 May 2013 09:42:56 Linus Walleij wrote:
> On Mon, Apr 29, 2013 at 1:12 PM, Laurent Pinchart wrote:
> > Changes compared to v2:
> > 
> > - Renamed the cleanup operation to exit
> 
> This is fine.
> The series:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thank you.

Simon, I've picked the acks and pushed the series to

	git://linuxtv.org/pinchartl/fbdev.git pinmux/3.9/sh73a0

Could you please pull it ?

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator
  2013-04-29 11:12 [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator Laurent Pinchart
  2013-05-03  7:42 ` Linus Walleij
  2013-05-03  9:56 ` Laurent Pinchart
@ 2013-05-07 11:29 ` Simon Horman
  2013-05-09  0:14 ` Simon Horman
  2013-05-09  4:40 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-05-07 11:29 UTC (permalink / raw)
  To: linux-sh

On Fri, May 03, 2013 at 11:56:42AM +0200, Laurent Pinchart wrote:
> Hi Linus,
> 
> On Friday 03 May 2013 09:42:56 Linus Walleij wrote:
> > On Mon, Apr 29, 2013 at 1:12 PM, Laurent Pinchart wrote:
> > > Changes compared to v2:
> > > 
> > > - Renamed the cleanup operation to exit
> > 
> > This is fine.
> > The series:
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Thank you.
> 
> Simon, I've picked the acks and pushed the series to
> 
> 	git://linuxtv.org/pinchartl/fbdev.git pinmux/3.9/sh73a0
> 
> Could you please pull it ?

Sure, will do.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator
  2013-04-29 11:12 [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator Laurent Pinchart
                   ` (2 preceding siblings ...)
  2013-05-07 11:29 ` Simon Horman
@ 2013-05-09  0:14 ` Simon Horman
  2013-05-09  4:40 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-05-09  0:14 UTC (permalink / raw)
  To: linux-sh

On Tue, May 07, 2013 at 08:29:42PM +0900, Simon Horman wrote:
> On Fri, May 03, 2013 at 11:56:42AM +0200, Laurent Pinchart wrote:
> > Hi Linus,
> > 
> > On Friday 03 May 2013 09:42:56 Linus Walleij wrote:
> > > On Mon, Apr 29, 2013 at 1:12 PM, Laurent Pinchart wrote:
> > > > Changes compared to v2:
> > > > 
> > > > - Renamed the cleanup operation to exit
> > > 
> > > This is fine.
> > > The series:
> > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > 
> > Thank you.
> > 
> > Simon, I've picked the acks and pushed the series to
> > 
> > 	git://linuxtv.org/pinchartl/fbdev.git pinmux/3.9/sh73a0
> > 
> > Could you please pull it ?
> 
> Sure, will do.

Sorry for the delay, I should get to this tomorrow.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator
  2013-04-29 11:12 [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator Laurent Pinchart
                   ` (3 preceding siblings ...)
  2013-05-09  0:14 ` Simon Horman
@ 2013-05-09  4:40 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-05-09  4:40 UTC (permalink / raw)
  To: linux-sh

On Thu, May 09, 2013 at 09:14:08AM +0900, Simon Horman wrote:
> On Tue, May 07, 2013 at 08:29:42PM +0900, Simon Horman wrote:
> > On Fri, May 03, 2013 at 11:56:42AM +0200, Laurent Pinchart wrote:
> > > Hi Linus,
> > > 
> > > On Friday 03 May 2013 09:42:56 Linus Walleij wrote:
> > > > On Mon, Apr 29, 2013 at 1:12 PM, Laurent Pinchart wrote:
> > > > > Changes compared to v2:
> > > > > 
> > > > > - Renamed the cleanup operation to exit
> > > > 
> > > > This is fine.
> > > > The series:
> > > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > > 
> > > Thank you.
> > > 
> > > Simon, I've picked the acks and pushed the series to
> > > 
> > > 	git://linuxtv.org/pinchartl/fbdev.git pinmux/3.9/sh73a0
> > > 
> > > Could you please pull it ?
> > 
> > Sure, will do.
> 
> Sorry for the delay, I should get to this tomorrow.

Done. It is in the pinmux branch as of renesas-next-20130509

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-05-09  4:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-29 11:12 [PATCH v3 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator Laurent Pinchart
2013-05-03  7:42 ` Linus Walleij
2013-05-03  9:56 ` Laurent Pinchart
2013-05-07 11:29 ` Simon Horman
2013-05-09  0:14 ` Simon Horman
2013-05-09  4:40 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox