Re: [PATCH 07/11] ARM: shmobile: bockw: add pins and clock to ethernet controller in DT

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Ulrich,

On Wednesday 21 January 2015 19:51:16 Sergei Shtylyov wrote:
> On 01/21/2015 07:20 PM, Ulrich Hecht wrote:
> > Completes the Ethernet controller DT entry with pin control and clock
> > information.
> > 
> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> > ---
> > 
> >   arch/arm/boot/dts/r8a7778-bockw.dts | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7778-bockw.dts
> > b/arch/arm/boot/dts/r8a7778-bockw.dts index 280a922..52086fe 100644
> > --- a/arch/arm/boot/dts/r8a7778-bockw.dts
> > +++ b/arch/arm/boot/dts/r8a7778-bockw.dts
> > @@ -47,8 +47,12 @@
> >   	};
> >   	
> >   	ethernet@18300000 {
> > +		pinctrl-0 = <&ether_pins>;
> > +		pinctrl-names = "default";
> > +
> 
> What Ether pins? This is an external LAN controller!

The external LAN9220 is connected to the LBSC bus controller. You should thus 
add a DT node for the bus controller, and move the ethernet controller node as 
a child of that node. See Geert's "[PATCH 5/9] ARM: shmobile: r8a73a4 dtsi: 
Add Bus State Controller node" and "[PATCH 6/9] ARM: shmobile: ape6evm dts: 
Move Ethernet node to BSC".

> >   		compatible = "smsc,lan9220", "smsc,lan9115";
> 
> See this "compatible"?
> 
> >   		reg = <0x18300000 0x1000>;
> > 
> > +		clocks = <&mstp1_clks R8A7778_CLK_ETHER>;
> 
> What, again?

At least it's consistent ;-)

-- 
Regards,

Laurent Pinchart