SUPERH platform development
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 07/11] ARM: shmobile: bockw: add pins and clock to ethernet controller in DT
Date: Wed, 21 Jan 2015 16:51:16 +0000	[thread overview]
Message-ID: <54BFD904.70003@cogentembedded.com> (raw)
In-Reply-To: <1421857262-16607-8-git-send-email-ulrich.hecht+renesas@gmail.com>

Hello.

On 01/21/2015 07:20 PM, Ulrich Hecht wrote:

> Completes the Ethernet controller DT entry with pin control and clock
> information.

> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>   arch/arm/boot/dts/r8a7778-bockw.dts | 9 +++++++++
>   1 file changed, 9 insertions(+)

> diff --git a/arch/arm/boot/dts/r8a7778-bockw.dts b/arch/arm/boot/dts/r8a7778-bockw.dts
> index 280a922..52086fe 100644
> --- a/arch/arm/boot/dts/r8a7778-bockw.dts
> +++ b/arch/arm/boot/dts/r8a7778-bockw.dts
> @@ -47,8 +47,12 @@
>   	};
>
>   	ethernet@18300000 {
> +		pinctrl-0 = <&ether_pins>;
> +		pinctrl-names = "default";
> +

    What Ether pins? This is an external LAN controller!

>   		compatible = "smsc,lan9220", "smsc,lan9115";

    See this "compatible"?

>   		reg = <0x18300000 0x1000>;
> +		clocks = <&mstp1_clks R8A7778_CLK_ETHER>;

    What, again?

WBR, Sergei


  reply	other threads:[~2015-01-21 16:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21 16:20 [PATCH 07/11] ARM: shmobile: bockw: add pins and clock to ethernet controller in DT Ulrich Hecht
2015-01-21 16:51 ` Sergei Shtylyov [this message]
2015-01-21 23:57 ` Laurent Pinchart
2015-01-22 12:05 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BFD904.70003@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox