[PATCH 0/5] R-Car Gen2 removal and cleanups

[PATCH 0/5] R-Car Gen2 removal and cleanups

[Laurent Pinchart]

Hello,

This patch series remove the Lager legacy and reference board files from the
kernel. It builds upon two patches previously posted by Magnus and updated to
removal left-overs.

The rationale for the change, beside keeping the ARM SoC maintainers happy, is
that the Lager board is now correctly supported using DT boot and generic code
only, so there's no reason to keep board files along.

The second reason to repost the patches is to include a pet peeve of mine that
I've been carrying in my local branches for too long. The last two patches
update the Lager and Koelsch DT files to finally rename the two serial ports
to ttySC0 and ttySC1.

The patches are targeted at v3.20, as they depend on the "ARM: shmobile:
lager: Remove DU platform device" patch scheduled for merge in v3.19-rc1
through the DRM tree.

Laurent Pinchart (3):
  ARM: shmobile: r8a7790: Remove legacy code
  ARM: shmobile: lager: Rename SCIFA[01] serial ports to ttySC[01]
  ARM: shmobile: koelsch: Rename SCIF[01] serial ports to ttySC[01]

Magnus Damm (2):
  ARM: shmobile: lager-reference: DTS-only board support
  ARM: shmobile: lager: Remove legacy board support

 MAINTAINERS                                    |   1 -
 arch/arm/boot/dts/Makefile                     |   1 -
 arch/arm/boot/dts/r8a7790-lager.dts            |   6 +-
 arch/arm/boot/dts/r8a7791-koelsch.dts          |   4 +-
 arch/arm/configs/lager_defconfig               | 150 -----
 arch/arm/configs/shmobile_defconfig            |   1 -
 arch/arm/mach-shmobile/Kconfig                 |  20 -
 arch/arm/mach-shmobile/Makefile                |   3 -
 arch/arm/mach-shmobile/Makefile.boot           |   1 -
 arch/arm/mach-shmobile/board-lager-reference.c |  39 --
 arch/arm/mach-shmobile/board-lager.c           | 827 -------------------------
 arch/arm/mach-shmobile/clock-r8a7790.c         | 459 --------------
 arch/arm/mach-shmobile/r8a7790.h               |  28 -
 arch/arm/mach-shmobile/setup-r8a7790.c         | 284 +--------
 14 files changed, 6 insertions(+), 1818 deletions(-)
 delete mode 100644 arch/arm/configs/lager_defconfig
 delete mode 100644 arch/arm/mach-shmobile/board-lager-reference.c
 delete mode 100644 arch/arm/mach-shmobile/board-lager.c
 delete mode 100644 arch/arm/mach-shmobile/clock-r8a7790.c

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/5] R-Car Gen2 removal and cleanups

[Geert Uytterhoeven]

Hi Laurent,

On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> This patch series remove the Lager legacy and reference board files from the
> kernel. It builds upon two patches previously posted by Magnus and updated to
> removal left-overs.
>
> The rationale for the change, beside keeping the ARM SoC maintainers happy, is
> that the Lager board is now correctly supported using DT boot and generic code
> only, so there's no reason to keep board files along.

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

> The second reason to repost the patches is to include a pet peeve of mine that
> I've been carrying in my local branches for too long. The last two patches
> update the Lager and Koelsch DT files to finally rename the two serial ports
> to ttySC0 and ttySC1.

I'm not opposed to this change.

> The patches are targeted at v3.20, as they depend on the "ARM: shmobile:
> lager: Remove DU platform device" patch scheduled for merge in v3.19-rc1
> through the DRM tree.

Given the issues with armadillo-legacy (and perhaps some other -legacy
platform(s)?) in -next (https://lkml.org/lkml/2014/12/2/339), we may have to
accelerate kicking out -legacy...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/5] R-Car Gen2 removal and cleanups

[Laurent Pinchart]

Hi Geert,

On Tuesday 02 December 2014 22:06:49 Geert Uytterhoeven wrote:
> On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart wrote:
> > This patch series remove the Lager legacy and reference board files from
> > the kernel. It builds upon two patches previously posted by Magnus and
> > updated to removal left-overs.
> > 
> > The rationale for the change, beside keeping the ARM SoC maintainers
> > happy, is that the Lager board is now correctly supported using DT boot
> > and generic code only, so there's no reason to keep board files along.
> 
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> > The second reason to repost the patches is to include a pet peeve of mine
> > that I've been carrying in my local branches for too long. The last two
> > patches update the Lager and Koelsch DT files to finally rename the two
> > serial ports to ttySC0 and ttySC1.
> 
> I'm not opposed to this change.
> 
> > The patches are targeted at v3.20, as they depend on the "ARM: shmobile:
> > lager: Remove DU platform device" patch scheduled for merge in v3.19-rc1
> > through the DRM tree.
> 
> Given the issues with armadillo-legacy (and perhaps some other -legacy
> platform(s)?) in -next (https://lkml.org/lkml/2014/12/2/339), we may have to
> accelerate kicking out -legacy...

We've known for a long time that -legacy is doomed. Now it's a question of 
priorities :-)

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/5] R-Car Gen2 removal and cleanups

[Simon Horman]

On Tue, Dec 02, 2014 at 11:44:29PM +0200, Laurent Pinchart wrote:
> Hi Geert,
> 
> On Tuesday 02 December 2014 22:06:49 Geert Uytterhoeven wrote:
> > On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart wrote:
> > > This patch series remove the Lager legacy and reference board files from
> > > the kernel. It builds upon two patches previously posted by Magnus and
> > > updated to removal left-overs.
> > > 
> > > The rationale for the change, beside keeping the ARM SoC maintainers
> > > happy, is that the Lager board is now correctly supported using DT boot
> > > and generic code only, so there's no reason to keep board files along.
> > 
> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > 
> > > The second reason to repost the patches is to include a pet peeve of mine
> > > that I've been carrying in my local branches for too long. The last two
> > > patches update the Lager and Koelsch DT files to finally rename the two
> > > serial ports to ttySC0 and ttySC1.
> > 
> > I'm not opposed to this change.

IIRC, this has been a contentious issue in the past.
I will confer with Magnus to make sure we are all happy with this change.

> > > The patches are targeted at v3.20, as they depend on the "ARM: shmobile:
> > > lager: Remove DU platform device" patch scheduled for merge in v3.19-rc1
> > > through the DRM tree.
> > 
> > Given the issues with armadillo-legacy (and perhaps some other -legacy
> > platform(s)?) in -next (https://lkml.org/lkml/2014/12/2/339), we may have to
> > accelerate kicking out -legacy...
> 
> We've known for a long time that -legacy is doomed. Now it's a question of 
> priorities :-)

Zero argument there.

Re: [PATCH 0/5] R-Car Gen2 removal and cleanups

[Laurent Pinchart]

Hi Simon,

On Thursday 04 December 2014 15:47:31 Simon Horman wrote:
> On Tue, Dec 02, 2014 at 11:44:29PM +0200, Laurent Pinchart wrote:
> > On Tuesday 02 December 2014 22:06:49 Geert Uytterhoeven wrote:
> >> On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart wrote:
> >>> This patch series remove the Lager legacy and reference board files
> >>> from the kernel. It builds upon two patches previously posted by
> >>> Magnus and updated to removal left-overs.
> >>> 
> >>> The rationale for the change, beside keeping the ARM SoC maintainers
> >>> happy, is that the Lager board is now correctly supported using DT
> >>> boot and generic code only, so there's no reason to keep board files
> >>> along.
> >> 
> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> 
> >>> The second reason to repost the patches is to include a pet peeve of
> >>> mine that I've been carrying in my local branches for too long. The
> >>> last two patches update the Lager and Koelsch DT files to finally
> >>> rename the two serial ports to ttySC0 and ttySC1.
> >> 
> >> I'm not opposed to this change.
> 
> IIRC, this has been a contentious issue in the past.
> I will confer with Magnus to make sure we are all happy with this change.

If I recall correctly the major issue back then was synchronization of serial 
port names between legacy and DT boot. Now that Lager and Koelsch legacy have 
been removed, there should at least be no synchronization issue anymore. I'll 
wait for feedback from Magnus of course.

> >>> The patches are targeted at v3.20, as they depend on the "ARM:
> >>> shmobile:
> >>> lager: Remove DU platform device" patch scheduled for merge in
> >>> v3.19-rc1 through the DRM tree.
> >> 
> >> Given the issues with armadillo-legacy (and perhaps some other -legacy
> >> platform(s)?) in -next (https://lkml.org/lkml/2014/12/2/339), we may
> >> have to accelerate kicking out -legacy...
> > 
> > We've known for a long time that -legacy is doomed. Now it's a question of
> > priorities :-)
> 
> Zero argument there.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/5] R-Car Gen2 removal and cleanups

[Magnus Damm]

Hi Laurent,

On Thu, Dec 4, 2014 at 4:32 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Hi Simon,
>
> On Thursday 04 December 2014 15:47:31 Simon Horman wrote:
>> On Tue, Dec 02, 2014 at 11:44:29PM +0200, Laurent Pinchart wrote:
>> > On Tuesday 02 December 2014 22:06:49 Geert Uytterhoeven wrote:
>> >> On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart wrote:
>> >>> This patch series remove the Lager legacy and reference board files
>> >>> from the kernel. It builds upon two patches previously posted by
>> >>> Magnus and updated to removal left-overs.
>> >>>
>> >>> The rationale for the change, beside keeping the ARM SoC maintainers
>> >>> happy, is that the Lager board is now correctly supported using DT
>> >>> boot and generic code only, so there's no reason to keep board files
>> >>> along.
>> >>
>> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> >>
>> >>> The second reason to repost the patches is to include a pet peeve of
>> >>> mine that I've been carrying in my local branches for too long. The
>> >>> last two patches update the Lager and Koelsch DT files to finally
>> >>> rename the two serial ports to ttySC0 and ttySC1.
>> >>
>> >> I'm not opposed to this change.
>>
>> IIRC, this has been a contentious issue in the past.
>> I will confer with Magnus to make sure we are all happy with this change.
>
> If I recall correctly the major issue back then was synchronization of serial
> port names between legacy and DT boot. Now that Lager and Koelsch legacy have
> been removed, there should at least be no synchronization issue anymore. I'll
> wait for feedback from Magnus of course.

You're right. I have no issues merging this now.

Cheers,

/ magnus

Re: [PATCH 0/5] R-Car Gen2 removal and cleanups

[Simon Horman]

On Thu, Dec 04, 2014 at 09:32:49AM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Thursday 04 December 2014 15:47:31 Simon Horman wrote:
> > On Tue, Dec 02, 2014 at 11:44:29PM +0200, Laurent Pinchart wrote:
> > > On Tuesday 02 December 2014 22:06:49 Geert Uytterhoeven wrote:
> > >> On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart wrote:
> > >>> This patch series remove the Lager legacy and reference board files
> > >>> from the kernel. It builds upon two patches previously posted by
> > >>> Magnus and updated to removal left-overs.
> > >>> 
> > >>> The rationale for the change, beside keeping the ARM SoC maintainers
> > >>> happy, is that the Lager board is now correctly supported using DT
> > >>> boot and generic code only, so there's no reason to keep board files
> > >>> along.
> > >> 
> > >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >> 
> > >>> The second reason to repost the patches is to include a pet peeve of
> > >>> mine that I've been carrying in my local branches for too long. The
> > >>> last two patches update the Lager and Koelsch DT files to finally
> > >>> rename the two serial ports to ttySC0 and ttySC1.
> > >> 
> > >> I'm not opposed to this change.
> > 
> > IIRC, this has been a contentious issue in the past.
> > I will confer with Magnus to make sure we are all happy with this change.
> 
> If I recall correctly the major issue back then was synchronization of serial 
> port names between legacy and DT boot. Now that Lager and Koelsch legacy have 
> been removed, there should at least be no synchronization issue anymore. I'll 
> wait for feedback from Magnus of course.

My recollection is the same as yours :)

BTW, do you want to the lager patch on top of Geert's patch
to remove console= from bootargs? If so feel free to repost the series
with his patch included.

> > >>> The patches are targeted at v3.20, as they depend on the "ARM:
> > >>> shmobile:
> > >>> lager: Remove DU platform device" patch scheduled for merge in
> > >>> v3.19-rc1 through the DRM tree.
> > >> 
> > >> Given the issues with armadillo-legacy (and perhaps some other -legacy
> > >> platform(s)?) in -next (https://lkml.org/lkml/2014/12/2/339), we may
> > >> have to accelerate kicking out -legacy...
> > > 
> > > We've known for a long time that -legacy is doomed. Now it's a question of
> > > priorities :-)
> > 
> > Zero argument there.
> 
> -- 
> Regards,
> 
> Laurent Pinchart

Re: [PATCH 0/5] R-Car Gen2 removal and cleanups

[Simon Horman]

On Thu, Dec 04, 2014 at 04:44:38PM +0900, Simon Horman wrote:
> On Thu, Dec 04, 2014 at 09:32:49AM +0200, Laurent Pinchart wrote:
> > Hi Simon,
> > 
> > On Thursday 04 December 2014 15:47:31 Simon Horman wrote:
> > > On Tue, Dec 02, 2014 at 11:44:29PM +0200, Laurent Pinchart wrote:
> > > > On Tuesday 02 December 2014 22:06:49 Geert Uytterhoeven wrote:
> > > >> On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart wrote:
> > > >>> This patch series remove the Lager legacy and reference board files
> > > >>> from the kernel. It builds upon two patches previously posted by
> > > >>> Magnus and updated to removal left-overs.
> > > >>> 
> > > >>> The rationale for the change, beside keeping the ARM SoC maintainers
> > > >>> happy, is that the Lager board is now correctly supported using DT
> > > >>> boot and generic code only, so there's no reason to keep board files
> > > >>> along.
> > > >> 
> > > >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >> 
> > > >>> The second reason to repost the patches is to include a pet peeve of
> > > >>> mine that I've been carrying in my local branches for too long. The
> > > >>> last two patches update the Lager and Koelsch DT files to finally
> > > >>> rename the two serial ports to ttySC0 and ttySC1.
> > > >> 
> > > >> I'm not opposed to this change.
> > > 
> > > IIRC, this has been a contentious issue in the past.
> > > I will confer with Magnus to make sure we are all happy with this change.
> > 
> > If I recall correctly the major issue back then was synchronization of serial 
> > port names between legacy and DT boot. Now that Lager and Koelsch legacy have 
> > been removed, there should at least be no synchronization issue anymore. I'll 
> > wait for feedback from Magnus of course.
> 
> My recollection is the same as yours :)

I have confirmed with Magnus that he is happy with the change (now) :)

> BTW, do you want to the lager patch on top of Geert's patch
> to remove console= from bootargs? If so feel free to repost the series
> with his patch included.

I'll hold off until I get a response to this one.

> > > >>> The patches are targeted at v3.20, as they depend on the "ARM:
> > > >>> shmobile:
> > > >>> lager: Remove DU platform device" patch scheduled for merge in
> > > >>> v3.19-rc1 through the DRM tree.
> > > >> 
> > > >> Given the issues with armadillo-legacy (and perhaps some other -legacy
> > > >> platform(s)?) in -next (https://lkml.org/lkml/2014/12/2/339), we may
> > > >> have to accelerate kicking out -legacy...
> > > > 
> > > > We've known for a long time that -legacy is doomed. Now it's a question of
> > > > priorities :-)
> > > 
> > > Zero argument there.
> > 
> > -- 
> > Regards,
> > 
> > Laurent Pinchart

Re: [PATCH 0/5] R-Car Gen2 removal and cleanups

[Geert Uytterhoeven]

Hi Simon,

On Thu, Dec 4, 2014 at 8:45 AM, Simon Horman <horms@verge.net.au> wrote:
>> BTW, do you want to the lager patch on top of Geert's patch
>> to remove console= from bootargs? If so feel free to repost the series
>> with his patch included.
>
> I'll hold off until I get a response to this one.

I don't mind if you apply Laurent's series first. That way I only have to repost
1 patch, versus a series for Laurent.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/5] R-Car Gen2 removal and cleanups

[Laurent Pinchart]

Hi Simon,

On Thursday 04 December 2014 16:44:39 Simon Horman wrote:
> On Thu, Dec 04, 2014 at 09:32:49AM +0200, Laurent Pinchart wrote:
> > On Thursday 04 December 2014 15:47:31 Simon Horman wrote:
> > > On Tue, Dec 02, 2014 at 11:44:29PM +0200, Laurent Pinchart wrote:
> > > > On Tuesday 02 December 2014 22:06:49 Geert Uytterhoeven wrote:
> > > >> On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart wrote:
> > > >>> This patch series remove the Lager legacy and reference board files
> > > >>> from the kernel. It builds upon two patches previously posted by
> > > >>> Magnus and updated to removal left-overs.
> > > >>> 
> > > >>> The rationale for the change, beside keeping the ARM SoC maintainers
> > > >>> happy, is that the Lager board is now correctly supported using DT
> > > >>> boot and generic code only, so there's no reason to keep board files
> > > >>> along.
> > > >> 
> > > >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >> 
> > > >>> The second reason to repost the patches is to include a pet peeve of
> > > >>> mine that I've been carrying in my local branches for too long. The
> > > >>> last two patches update the Lager and Koelsch DT files to finally
> > > >>> rename the two serial ports to ttySC0 and ttySC1.
> > > >> 
> > > >> I'm not opposed to this change.
> > > 
> > > IIRC, this has been a contentious issue in the past.
> > > I will confer with Magnus to make sure we are all happy with this
> > > change.
> > 
> > If I recall correctly the major issue back then was synchronization of
> > serial port names between legacy and DT boot. Now that Lager and Koelsch
> > legacy have been removed, there should at least be no synchronization
> > issue anymore. I'll wait for feedback from Magnus of course.
> 
> My recollection is the same as yours :)
> 
> BTW, do you want to the lager patch on top of Geert's patch
> to remove console= from bootargs? If so feel free to repost the series
> with his patch included.

I've rebased Geert's patch and applied it to my tree 
(git://linuxtv.org/pinchartl/fbdev.git arch/next), but I'm also fine if you 
prefer Geert's patch to go in first.

> >> >>> The patches are targeted at v3.20, as they depend on the "ARM:
> >> >>> shmobile:
> >> >>> lager: Remove DU platform device" patch scheduled for merge in
> >> >>> v3.19-rc1 through the DRM tree.
> >> >> 
> >> >> Given the issues with armadillo-legacy (and perhaps some other
> >> >> -legacy
> >> >> platform(s)?) in -next (https://lkml.org/lkml/2014/12/2/339), we may
> >> >> have to accelerate kicking out -legacy...
> >> > 
> >> > We've known for a long time that -legacy is doomed. Now it's a
> >> > question of
> >> > priorities :-)
> >> 
> >> Zero argument there.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/5] R-Car Gen2 removal and cleanups

[Simon Horman]

On Thu, Dec 04, 2014 at 11:12:25AM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Thursday 04 December 2014 16:44:39 Simon Horman wrote:
> > On Thu, Dec 04, 2014 at 09:32:49AM +0200, Laurent Pinchart wrote:
> > > On Thursday 04 December 2014 15:47:31 Simon Horman wrote:
> > > > On Tue, Dec 02, 2014 at 11:44:29PM +0200, Laurent Pinchart wrote:
> > > > > On Tuesday 02 December 2014 22:06:49 Geert Uytterhoeven wrote:
> > > > >> On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart wrote:
> > > > >>> This patch series remove the Lager legacy and reference board files
> > > > >>> from the kernel. It builds upon two patches previously posted by
> > > > >>> Magnus and updated to removal left-overs.
> > > > >>> 
> > > > >>> The rationale for the change, beside keeping the ARM SoC maintainers
> > > > >>> happy, is that the Lager board is now correctly supported using DT
> > > > >>> boot and generic code only, so there's no reason to keep board files
> > > > >>> along.
> > > > >> 
> > > > >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > >> 
> > > > >>> The second reason to repost the patches is to include a pet peeve of
> > > > >>> mine that I've been carrying in my local branches for too long. The
> > > > >>> last two patches update the Lager and Koelsch DT files to finally
> > > > >>> rename the two serial ports to ttySC0 and ttySC1.
> > > > >> 
> > > > >> I'm not opposed to this change.
> > > > 
> > > > IIRC, this has been a contentious issue in the past.
> > > > I will confer with Magnus to make sure we are all happy with this
> > > > change.
> > > 
> > > If I recall correctly the major issue back then was synchronization of
> > > serial port names between legacy and DT boot. Now that Lager and Koelsch
> > > legacy have been removed, there should at least be no synchronization
> > > issue anymore. I'll wait for feedback from Magnus of course.
> > 
> > My recollection is the same as yours :)
> > 
> > BTW, do you want to the lager patch on top of Geert's patch
> > to remove console= from bootargs? If so feel free to repost the series
> > with his patch included.
> 
> I've rebased Geert's patch and applied it to my tree 
> (git://linuxtv.org/pinchartl/fbdev.git arch/next), but I'm also fine if you 
> prefer Geert's patch to go in first.

Thanks, I have picked up the patches from there.