SUPERH platform development
 help / color / mirror / Atom feed
* [PATCH] serial: sh-sci: fix DMA build by including dma-mapping.h
@ 2011-08-02  9:42 Magnus Damm
  2011-08-03  3:28 ` Simon Horman
  2011-08-03  3:37 ` Paul Mundt
  0 siblings, 2 replies; 3+ messages in thread
From: Magnus Damm @ 2011-08-02  9:42 UTC (permalink / raw)
  To: linux-sh

From: Magnus Damm <damm@opensource.se>

Include dma-mapping.h to fix build of the sh-sci driver on
SH-Mobile ARM (sh73a0) when CONFIG_SERIAL_SH_SCI_DMA=y:

drivers/tty/serial/sh-sci.c: In function 'sci_rx_dma_release':
drivers/tty/serial/sh-sci.c:1182:3: error: implicit declaration of function 'dma_free_coherent'
drivers/tty/serial/sh-sci.c: In function 'work_fn_tx':
drivers/tty/serial/sh-sci.c:1333:2: error: implicit declaration of function 'dma_sync_sg_for_device'
drivers/tty/serial/sh-sci.c: In function 'sci_request_dma':
drivers/tty/serial/sh-sci.c:1498:3: error: implicit declaration of function 'dma_map_sg'
drivers/tty/serial/sh-sci.c:1527:3: error: implicit declaration of function 'dma_alloc_coherent'
drivers/tty/serial/sh-sci.c:1527:10: warning: assignment makes pointer from integer without a cast
make[3]: *** [drivers/tty/serial/sh-sci.o] Error 1
make[2]: *** [drivers/tty/serial] Error 2
make[1]: *** [drivers/tty] Error 2
make: *** [drivers] Error 2

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 drivers/tty/serial/sh-sci.c |    1 +
 1 file changed, 1 insertion(+)

--- 0001/drivers/tty/serial/sh-sci.c
+++ work/drivers/tty/serial/sh-sci.c	2011-08-02 17:41:43.000000000 +0900
@@ -47,6 +47,7 @@
 #include <linux/ctype.h>
 #include <linux/err.h>
 #include <linux/dmaengine.h>
+#include <linux/dma-mapping.h>
 #include <linux/scatterlist.h>
 #include <linux/slab.h>
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] serial: sh-sci: fix DMA build by including dma-mapping.h
  2011-08-02  9:42 [PATCH] serial: sh-sci: fix DMA build by including dma-mapping.h Magnus Damm
@ 2011-08-03  3:28 ` Simon Horman
  2011-08-03  3:37 ` Paul Mundt
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2011-08-03  3:28 UTC (permalink / raw)
  To: linux-sh

On Tue, Aug 02, 2011 at 06:42:54PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Include dma-mapping.h to fix build of the sh-sci driver on
> SH-Mobile ARM (sh73a0) when CONFIG_SERIAL_SH_SCI_DMA=y:
> 
> drivers/tty/serial/sh-sci.c: In function 'sci_rx_dma_release':
> drivers/tty/serial/sh-sci.c:1182:3: error: implicit declaration of function 'dma_free_coherent'
> drivers/tty/serial/sh-sci.c: In function 'work_fn_tx':
> drivers/tty/serial/sh-sci.c:1333:2: error: implicit declaration of function 'dma_sync_sg_for_device'
> drivers/tty/serial/sh-sci.c: In function 'sci_request_dma':
> drivers/tty/serial/sh-sci.c:1498:3: error: implicit declaration of function 'dma_map_sg'
> drivers/tty/serial/sh-sci.c:1527:3: error: implicit declaration of function 'dma_alloc_coherent'
> drivers/tty/serial/sh-sci.c:1527:10: warning: assignment makes pointer from integer without a cast
> make[3]: *** [drivers/tty/serial/sh-sci.o] Error 1
> make[2]: *** [drivers/tty/serial] Error 2
> make[1]: *** [drivers/tty] Error 2
> make: *** [drivers] Error 2

Tested-by: Simon Horman <horms@verge.net.au>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] serial: sh-sci: fix DMA build by including dma-mapping.h
  2011-08-02  9:42 [PATCH] serial: sh-sci: fix DMA build by including dma-mapping.h Magnus Damm
  2011-08-03  3:28 ` Simon Horman
@ 2011-08-03  3:37 ` Paul Mundt
  1 sibling, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2011-08-03  3:37 UTC (permalink / raw)
  To: linux-sh

On Wed, Aug 03, 2011 at 12:28:09PM +0900, Simon Horman wrote:
> On Tue, Aug 02, 2011 at 06:42:54PM +0900, Magnus Damm wrote:
> > From: Magnus Damm <damm@opensource.se>
> > 
> > Include dma-mapping.h to fix build of the sh-sci driver on
> > SH-Mobile ARM (sh73a0) when CONFIG_SERIAL_SH_SCI_DMA=y:
> > 
> > drivers/tty/serial/sh-sci.c: In function 'sci_rx_dma_release':
> > drivers/tty/serial/sh-sci.c:1182:3: error: implicit declaration of function 'dma_free_coherent'
> > drivers/tty/serial/sh-sci.c: In function 'work_fn_tx':
> > drivers/tty/serial/sh-sci.c:1333:2: error: implicit declaration of function 'dma_sync_sg_for_device'
> > drivers/tty/serial/sh-sci.c: In function 'sci_request_dma':
> > drivers/tty/serial/sh-sci.c:1498:3: error: implicit declaration of function 'dma_map_sg'
> > drivers/tty/serial/sh-sci.c:1527:3: error: implicit declaration of function 'dma_alloc_coherent'
> > drivers/tty/serial/sh-sci.c:1527:10: warning: assignment makes pointer from integer without a cast
> > make[3]: *** [drivers/tty/serial/sh-sci.o] Error 1
> > make[2]: *** [drivers/tty/serial] Error 2
> > make[1]: *** [drivers/tty] Error 2
> > make: *** [drivers] Error 2
> 
> Tested-by: Simon Horman <horms@verge.net.au>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-03  3:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-02  9:42 [PATCH] serial: sh-sci: fix DMA build by including dma-mapping.h Magnus Damm
2011-08-03  3:28 ` Simon Horman
2011-08-03  3:37 ` Paul Mundt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox