From: Felipe Balbi <balbi@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib
Date: Thu, 11 Aug 2011 14:15:31 +0000 [thread overview]
Message-ID: <20110811141528.GL28500@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <E1QqhM1-0003af-U5@rmk-PC.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 2864 bytes --]
On Tue, Aug 09, 2011 at 09:08:01AM +0100, Russell King - ARM Linux wrote:
> Consolidate 24 trivial gpiolib implementions out of mach/gpio.h
> into asm/gpio.h. This is basically the include of asm-generic/gpio.h
> and the definition of gpio_get_value, gpio_set_value, and gpio_cansleep
> as described in Documentation/gpio.txt
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> arch/arm/include/asm/gpio.h | 10 ++++++++++
> arch/arm/mach-at91/include/mach/gpio.h | 5 +----
> arch/arm/mach-ep93xx/include/mach/gpio.h | 7 +------
> arch/arm/mach-exynos4/include/mach/gpio.h | 5 +----
> arch/arm/mach-gemini/include/mach/gpio.h | 5 +----
> arch/arm/mach-ks8695/include/mach/gpio.h | 11 ++---------
> arch/arm/mach-lpc32xx/include/mach/gpio.h | 17 +----------------
> arch/arm/mach-msm/include/mach/gpio.h | 5 +----
> arch/arm/mach-mxs/include/mach/gpio.h | 6 +-----
> arch/arm/mach-realview/include/mach/gpio.h | 6 +-----
> arch/arm/mach-s3c2410/include/mach/gpio.h | 5 +----
> arch/arm/mach-s3c64xx/include/mach/gpio.h | 6 +-----
> arch/arm/mach-s5p64x0/include/mach/gpio.h | 6 +-----
> arch/arm/mach-s5pc100/include/mach/gpio.h | 6 +-----
> arch/arm/mach-s5pv210/include/mach/gpio.h | 6 +-----
> arch/arm/mach-shmobile/include/mach/gpio.h | 15 +--------------
> arch/arm/mach-tegra/include/mach/gpio.h | 6 +-----
> arch/arm/mach-versatile/include/mach/gpio.h | 6 +-----
> arch/arm/mach-vt8500/include/mach/gpio.h | 6 +-----
> arch/arm/mach-w90x900/include/mach/gpio.h | 5 +----
> arch/arm/plat-mxc/include/mach/gpio.h | 5 +----
> arch/arm/plat-nomadik/include/plat/gpio.h | 11 +----------
> arch/arm/plat-omap/include/plat/gpio.h | 15 +--------------
> arch/arm/plat-orion/include/plat/gpio.h | 6 ++----
> arch/arm/plat-spear/include/plat/gpio.h | 6 +-----
> 25 files changed, 36 insertions(+), 151 deletions(-)
>
> diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h
> index 166a7a3..15e8970 100644
> --- a/arch/arm/include/asm/gpio.h
> +++ b/arch/arm/include/asm/gpio.h
> @@ -4,4 +4,14 @@
> /* not all ARM platforms necessarily support this API ... */
> #include <mach/gpio.h>
>
> +#ifdef __ARM_GPIOLIB_TRIVIAL
> +/* Note: this may rely upon the value of ARCH_NR_GPIOS set in mach/gpio.h */
> +#include <asm-generic/gpio.h>
> +
> +/* The trivial gpiolib dispatchers */
> +#define gpio_get_value __gpio_get_value
> +#define gpio_set_value __gpio_set_value
> +#define gpio_cansleep __gpio_cansleep
> +#endif
could that be a selectable symbol ? Something like:
CONFIG_HAS_ARM_TRIVIAL_GPIO
then on Kconfig you just:
select HAS_ARM_TIVIAL_GPIO or something ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-08-11 14:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 8:04 [PATCH 00/13] Clean up mach/gpio.h headers Russell King - ARM Linux
2011-08-09 8:04 ` [PATCH 01/13] ARM: gpio: at91: remove redundant include of Russell King - ARM Linux
2011-08-09 8:05 ` [PATCH 02/13] ARM: gpio: convert includes of mach/gpio.h and Russell King - ARM Linux
2011-08-09 8:05 ` [PATCH 03/13] ARM: gpio: omap: convert drivers to use asm/gpio.h Russell King - ARM Linux
2011-08-29 18:20 ` [PATCH 03/13] ARM: gpio: omap: convert drivers to use asm/gpio.h rather than mach/gpio.h Kevin Hilman
2011-08-09 8:05 ` [PATCH 04/13] ARM: gpio: at91: convert drivers to use asm/gpio.h Russell King - ARM Linux
2011-08-09 8:06 ` [PATCH 05/13] ARM: gpio: nomadik: " Russell King - ARM Linux
2011-08-09 8:06 ` [PATCH 06/13] ARM: gpio: davinci: " Russell King - ARM Linux
2011-08-09 12:06 ` Sergei Shtylyov
2011-08-09 19:45 ` [PATCH 06/13] ARM: gpio: davinci: convert drivers to use Russell King - ARM Linux
2011-08-09 8:06 ` [PATCH 07/13] ARM: gpio: pnx4008: convert drivers to use asm/gpio.h Russell King - ARM Linux
2011-08-09 8:07 ` [PATCH 08/13] ARM: gpio: ixp2000: " Russell King - ARM Linux
2011-08-09 8:07 ` [PATCH 09/13] ARM: gpio: tegra: " Russell King - ARM Linux
2011-08-09 8:07 ` [PATCH 10/13] ARM: gpio: pxa: " Russell King - ARM Linux
2011-08-09 8:08 ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations Russell King - ARM Linux
2011-08-09 17:02 ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib H Hartley Sweeten
2011-08-09 17:59 ` David Brown
2011-08-10 7:54 ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations Linus Walleij
2011-08-11 11:47 ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib Kukjin Kim
2011-08-11 15:08 ` Russell King - ARM Linux
2011-08-11 16:24 ` David Brown
2011-08-11 14:15 ` Felipe Balbi [this message]
2011-08-11 15:07 ` Russell King - ARM Linux
2011-08-11 18:50 ` Felipe Balbi
2011-08-12 5:54 ` Shawn Guo
2011-08-29 18:23 ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations Kevin Hilman
2011-08-09 8:08 ` [PATCH 12/13] ARM: gpio: consolidate gpio_to_irq Russell King - ARM Linux
2011-08-11 11:58 ` Kukjin Kim
2011-08-09 8:08 ` [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation the Russell King - ARM Linux
2011-08-09 17:04 ` [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation H Hartley Sweeten
2011-08-11 12:02 ` [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation the Kukjin Kim
2011-08-09 9:58 ` [PATCH 00/13] Clean up mach/gpio.h headers Jamie Iles
2011-08-09 21:00 ` Grant Likely
2011-08-09 21:32 ` Russell King - ARM Linux
2011-08-09 21:50 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811141528.GL28500@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox