* Re: [PATCH] ARM: mach-shmobile: fix A3SP suspend method
@ 2012-01-12 23:48 Rafael J. Wysocki
2012-01-13 9:45 ` Magnus Damm
0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2012-01-12 23:48 UTC (permalink / raw)
To: linux-sh
On Thursday, January 12, 2012, Guennadi Liakhovetski wrote:
> Fix the reverted condition in sh7372_a3sp_suspend().
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> diff --git a/arch/arm/mach-shmobile/pm-sh7372.c b/arch/arm/mach-shmobile/pm-sh7372.c
> index 77b8fc1..43baa97 100644
> --- a/arch/arm/mach-shmobile/pm-sh7372.c
> +++ b/arch/arm/mach-shmobile/pm-sh7372.c
> @@ -276,7 +276,7 @@ static int sh7372_a3sp_suspend(void)
> * Serial consoles make use of SCIF hardware located in A3SP,
> * keep such power domain on if "no_console_suspend" is set.
> */
> - return console_suspend_enabled ? -EBUSY : 0;
> + return console_suspend_enabled ? 0 : -EBUSY;
> }
>
> struct sh7372_pm_domain sh7372_a3sp = {
Magnus, the patch is correct, but I need your ACK here.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: mach-shmobile: fix A3SP suspend method
2012-01-12 23:48 [PATCH] ARM: mach-shmobile: fix A3SP suspend method Rafael J. Wysocki
@ 2012-01-13 9:45 ` Magnus Damm
0 siblings, 0 replies; 2+ messages in thread
From: Magnus Damm @ 2012-01-13 9:45 UTC (permalink / raw)
To: linux-sh
On Fri, Jan 13, 2012 at 8:48 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Thursday, January 12, 2012, Guennadi Liakhovetski wrote:
>> Fix the reverted condition in sh7372_a3sp_suspend().
>>
>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>> ---
>> diff --git a/arch/arm/mach-shmobile/pm-sh7372.c b/arch/arm/mach-shmobile/pm-sh7372.c
>> index 77b8fc1..43baa97 100644
>> --- a/arch/arm/mach-shmobile/pm-sh7372.c
>> +++ b/arch/arm/mach-shmobile/pm-sh7372.c
>> @@ -276,7 +276,7 @@ static int sh7372_a3sp_suspend(void)
>> * Serial consoles make use of SCIF hardware located in A3SP,
>> * keep such power domain on if "no_console_suspend" is set.
>> */
>> - return console_suspend_enabled ? -EBUSY : 0;
>> + return console_suspend_enabled ? 0 : -EBUSY;
>> }
>>
>> struct sh7372_pm_domain sh7372_a3sp = {
>
> Magnus, the patch is correct, but I need your ACK here.
Yes, it indeed seems like a correct fix.
Acked-by: Magnus Damm <damm@opensource.se>
Thanks to you and Guennadi for fixing this.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-13 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-12 23:48 [PATCH] ARM: mach-shmobile: fix A3SP suspend method Rafael J. Wysocki
2012-01-13 9:45 ` Magnus Damm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox