From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: mach-shmobile: tidyup: sound card detection order
Date: Tue, 29 May 2012 06:46:25 +0000 [thread overview]
Message-ID: <20120529064621.GB6166@verge.net.au> (raw)
In-Reply-To: <87mx4rmqzd.wl%kuninori.morimoto.gx@renesas.com>
On Mon, May 28, 2012 at 11:38:34PM -0700, Kuninori Morimoto wrote:
> Current sound card is using snd-simple-card,
> but it requests probe deferral when boot, since the detection
> timing of snd-simple-card is earlier than sh.
>
> Because of this behavior, if platform has some sound cards,
> the postponed probe order was changed
> and it breaks ALSA device list order.
>
> This patch makes it consistent on mackerel/ap4evb
Hi Morimoto-san,
Is the problem that a previous patch altered the order of the
ALSA index of the sound cards? And this patch restores the previous order?
If so, I wonder if this is really necessary as is should
be possible to set the index using a module parameter if one
is relying on it.
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/mach-shmobile/board-ap4evb.c | 2 +-
> arch/arm/mach-shmobile/board-mackerel.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/board-ap4evb.c b/arch/arm/mach-shmobile/board-ap4evb.c
> index d7417f3..2a1e9b5 100644
> --- a/arch/arm/mach-shmobile/board-ap4evb.c
> +++ b/arch/arm/mach-shmobile/board-ap4evb.c
> @@ -1064,8 +1064,8 @@ static struct platform_device *ap4evb_devices[] __initdata = {
> &sdhi1_device,
> &usb1_host_device,
> &fsi_device,
> - &fsi_ak4643_device,
> &fsi_hdmi_device,
> + &fsi_ak4643_device,
> &sh_mmcif_device,
> &hdmi_device,
> &lcdc_device,
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 798be2b..2313a6f 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -1300,8 +1300,8 @@ static struct platform_device *mackerel_devices[] __initdata = {
> &usbhs0_device,
> &leds_device,
> &fsi_device,
> - &fsi_ak4643_device,
> &fsi_hdmi_device,
> + &fsi_ak4643_device,
> &nand_flash_device,
> &sdhi0_device,
> #if !defined(CONFIG_MMC_SH_MMCIF) && !defined(CONFIG_MMC_SH_MMCIF_MODULE)
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-05-29 6:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 6:38 [PATCH] ARM: mach-shmobile: tidyup: sound card detection order Kuninori Morimoto
2012-05-29 6:46 ` Simon Horman [this message]
2012-05-29 7:04 ` Paul Mundt
2012-05-29 7:33 ` Simon Horman
2012-05-29 7:40 ` Kuninori Morimoto
2012-05-29 9:11 ` Simon Horman
2012-05-30 0:25 ` Kuninori Morimoto
2012-05-30 1:09 ` Kuninori Morimoto
2012-05-30 1:30 ` Simon Horman
2012-05-30 1:34 ` Kuninori Morimoto
2012-05-30 1:46 ` [PATCH] driver core: fixup reversed deferred probe order Kuninori Morimoto
2012-06-12 23:17 ` Greg Kroah-Hartman
2012-06-13 0:03 ` Kuninori Morimoto
2012-06-13 0:33 ` Greg Kroah-Hartman
2012-07-09 21:56 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529064621.GB6166@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox