* Re: [PATCH] gpio: em: Use irq_domain_add_simple() to fix runtime error
2013-02-12 15:56 [PATCH] gpio: em: Use irq_domain_add_simple() to fix runtime error Magnus Damm
@ 2013-02-13 8:11 ` Simon Horman
2013-02-14 12:30 ` Magnus Damm
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-02-13 8:11 UTC (permalink / raw)
To: linux-sh
On Wed, Feb 13, 2013 at 12:56:13AM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Adjust the gpio-em.c driver to reconsider the pdata->irq_base
> variable. Non-DT board code like for instance board-kzm9d.c
> needs to operate of a static IRQ range for platform devices.
>
> So this patch is updating the code to make use of the function
> irq_domain_add_simple() instead of irq_domain_add_linear().
>
> Fixes a EMEV2 / KZM9D runtime error caused by the following commit:
> 7385500 gpio/em: convert to linear IRQ domain
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Simon Horman <horms+renesas@verge.net.au>
Reported-by: Simon Horman <horms+renesas@verge.net.au>
This appears to be a regression between v3.7 and v3.8-rc1 which
(possibly amongst other things) prevents the NIC on the KZM9D
from functioning.
> ---
>
> drivers/gpio/gpio-em.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- 0001/drivers/gpio/gpio-em.c
> +++ work/drivers/gpio/gpio-em.c 2013-02-12 22:40:16.000000000 +0900
> @@ -299,8 +299,9 @@ static int em_gio_probe(struct platform_
> irq_chip->irq_set_type = em_gio_irq_set_type;
> irq_chip->flags = IRQCHIP_SKIP_SET_WAKE;
>
> - p->irq_domain = irq_domain_add_linear(pdev->dev.of_node,
> + p->irq_domain = irq_domain_add_simple(pdev->dev.of_node,
> pdata->number_of_pins,
> + pdata->irq_base,
> &em_gio_irq_domain_ops, p);
> if (!p->irq_domain) {
> ret = -ENXIO;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpio: em: Use irq_domain_add_simple() to fix runtime error
2013-02-12 15:56 [PATCH] gpio: em: Use irq_domain_add_simple() to fix runtime error Magnus Damm
2013-02-13 8:11 ` Simon Horman
@ 2013-02-14 12:30 ` Magnus Damm
2013-02-14 15:55 ` Simon Horman
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Magnus Damm @ 2013-02-14 12:30 UTC (permalink / raw)
To: linux-sh
Hi Simon,
On Wed, Feb 13, 2013 at 5:11 PM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Feb 13, 2013 at 12:56:13AM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@opensource.se>
>>
>> Adjust the gpio-em.c driver to reconsider the pdata->irq_base
>> variable. Non-DT board code like for instance board-kzm9d.c
>> needs to operate of a static IRQ range for platform devices.
>>
>> So this patch is updating the code to make use of the function
>> irq_domain_add_simple() instead of irq_domain_add_linear().
>>
>> Fixes a EMEV2 / KZM9D runtime error caused by the following commit:
>> 7385500 gpio/em: convert to linear IRQ domain
>>
>> Signed-off-by: Magnus Damm <damm@opensource.se>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
>
> Tested-by: Simon Horman <horms+renesas@verge.net.au>
> Reported-by: Simon Horman <horms+renesas@verge.net.au>
>
> This appears to be a regression between v3.7 and v3.8-rc1 which
> (possibly amongst other things) prevents the NIC on the KZM9D
> from functioning.
Thanks, Simon. I forgot to add you on the Reported-by. Good to see
that you've tested the patch.
So how can we merge this one? From my point of view, if v3.8 is
difficult timing wise then v3.9 is fine.
Thanks,
/ magnus
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpio: em: Use irq_domain_add_simple() to fix runtime error
2013-02-12 15:56 [PATCH] gpio: em: Use irq_domain_add_simple() to fix runtime error Magnus Damm
2013-02-13 8:11 ` Simon Horman
2013-02-14 12:30 ` Magnus Damm
@ 2013-02-14 15:55 ` Simon Horman
2013-02-14 16:45 ` Linus Walleij
2013-02-14 23:22 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-02-14 15:55 UTC (permalink / raw)
To: linux-sh
On Thu, Feb 14, 2013 at 09:30:12PM +0900, Magnus Damm wrote:
> Hi Simon,
>
> On Wed, Feb 13, 2013 at 5:11 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Feb 13, 2013 at 12:56:13AM +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> Adjust the gpio-em.c driver to reconsider the pdata->irq_base
> >> variable. Non-DT board code like for instance board-kzm9d.c
> >> needs to operate of a static IRQ range for platform devices.
> >>
> >> So this patch is updating the code to make use of the function
> >> irq_domain_add_simple() instead of irq_domain_add_linear().
> >>
> >> Fixes a EMEV2 / KZM9D runtime error caused by the following commit:
> >> 7385500 gpio/em: convert to linear IRQ domain
> >>
> >> Signed-off-by: Magnus Damm <damm@opensource.se>
> >> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >
> >
> > Tested-by: Simon Horman <horms+renesas@verge.net.au>
> > Reported-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > This appears to be a regression between v3.7 and v3.8-rc1 which
> > (possibly amongst other things) prevents the NIC on the KZM9D
> > from functioning.
>
> Thanks, Simon. I forgot to add you on the Reported-by. Good to see
> that you've tested the patch.
>
> So how can we merge this one? From my point of view, if v3.8 is
> difficult timing wise then v3.9 is fine.
I assumed it would go through the GIPO tree.
But I can handle it through the renesas tree if
that is preferred.
In any case I guess it should go into v3.9 and 3.8-stable.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gpio: em: Use irq_domain_add_simple() to fix runtime error
2013-02-12 15:56 [PATCH] gpio: em: Use irq_domain_add_simple() to fix runtime error Magnus Damm
` (2 preceding siblings ...)
2013-02-14 15:55 ` Simon Horman
@ 2013-02-14 16:45 ` Linus Walleij
2013-02-14 23:22 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2013-02-14 16:45 UTC (permalink / raw)
To: linux-sh
On Thu, Feb 14, 2013 at 1:30 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> [Simon]
>> This appears to be a regression between v3.7 and v3.8-rc1 which
>> (possibly amongst other things) prevents the NIC on the KZM9D
>> from functioning.
>
> Thanks, Simon. I forgot to add you on the Reported-by. Good to see
> that you've tested the patch.
>
> So how can we merge this one? From my point of view, if v3.8 is
> difficult timing wise then v3.9 is fine.
I've applied it to for-next with an Cc: stable tag.
Thanks,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpio: em: Use irq_domain_add_simple() to fix runtime error
2013-02-12 15:56 [PATCH] gpio: em: Use irq_domain_add_simple() to fix runtime error Magnus Damm
` (3 preceding siblings ...)
2013-02-14 16:45 ` Linus Walleij
@ 2013-02-14 23:22 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-02-14 23:22 UTC (permalink / raw)
To: linux-sh
On Thu, Feb 14, 2013 at 05:45:46PM +0100, Linus Walleij wrote:
> On Thu, Feb 14, 2013 at 1:30 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > [Simon]
> >> This appears to be a regression between v3.7 and v3.8-rc1 which
> >> (possibly amongst other things) prevents the NIC on the KZM9D
> >> from functioning.
> >
> > Thanks, Simon. I forgot to add you on the Reported-by. Good to see
> > that you've tested the patch.
> >
> > So how can we merge this one? From my point of view, if v3.8 is
> > difficult timing wise then v3.9 is fine.
>
> I've applied it to for-next with an Cc: stable tag.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread