From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 5/8] ARM: shmobile: add sh73a0-specific timer initialisation to kzm9g-reference
Date: Wed, 13 Feb 2013 11:00:39 +0000 [thread overview]
Message-ID: <20130213110039.GC22623@verge.net.au> (raw)
In-Reply-To: <1360348712-29255-6-git-send-email-g.liakhovetski@gmx.de>
On Wed, Feb 13, 2013 at 11:08:57AM +0100, Guennadi Liakhovetski wrote:
> Hi Simon
>
> On Wed, 13 Feb 2013, Simon Horman wrote:
>
> > On Fri, Feb 08, 2013 at 07:38:29PM +0100, Guennadi Liakhovetski wrote:
> > > This patch fixes failing boot of the kzm9g-reference kernel.
> >
> > Magnus specifically asked for the DT reference code not to use
> > early timers.
> >
> > As you have no doubt observed the current code doesn't work with SMP.
>
> Sorry, which current code? Actually my kzm9g is running with CONFUG_SMP=y
> and both CPUs show in cpuinfo, in dmesg, and CPU1 even gets some
> interrupts in /proc/interrupts (ok, not usual device interrupts, only twd
> and some IPI). What am I missing?
The code that exists without the patch below.
> > I have not been able to find a solution that does work with CONFIG_SMP
> > enabled without using early timers. I would welcome some ideas
> > on how to resolve this problem without using early timers.
> >
> > >
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > > ---
> > >
> > > Also a fix.
> > >
> > > arch/arm/mach-shmobile/board-kzm9g-reference.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-shmobile/board-kzm9g-reference.c b/arch/arm/mach-shmobile/board-kzm9g-reference.c
> > > index 534eee6..9f5cab757 100644
> > > --- a/arch/arm/mach-shmobile/board-kzm9g-reference.c
> > > +++ b/arch/arm/mach-shmobile/board-kzm9g-reference.c
> > > @@ -112,7 +112,7 @@ DT_MACHINE_START(KZM9G_DT, "kzm9g-reference")
> > > .init_irq = sh73a0_init_irq_dt,
> > > .init_machine = kzm_init,
> > > .init_late = shmobile_init_late,
> > > - .init_time = shmobile_timer_init,
> > > + .init_time = sh73a0_earlytimer_init,
> > > .restart = kzm9g_restart,
> > > .dt_compat = kzm9g_boards_compat_dt,
> > > MACHINE_END
> > > --
> > > 1.7.2.5
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > >
> >
>
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
>
next prev parent reply other threads:[~2013-02-13 11:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 18:38 [PATCH v2 5/8] ARM: shmobile: add sh73a0-specific timer initialisation to kzm9g-reference Guennadi Liakhovetski
2013-02-13 3:46 ` Simon Horman
2013-02-13 4:15 ` Magnus Damm
2013-02-13 4:41 ` Simon Horman
2013-02-13 5:04 ` Magnus Damm
2013-02-13 5:37 ` Simon Horman
2013-02-13 10:08 ` Guennadi Liakhovetski
2013-02-13 11:00 ` Simon Horman [this message]
2013-02-13 14:22 ` Magnus Damm
2013-02-18 5:44 ` Magnus Damm
2013-02-18 6:51 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213110039.GC22623@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox