SUPERH platform development
 help / color / mirror / Atom feed
* [PATCH] ARM: shmobile: Make sh73a0 INTC irqpin platform data static
@ 2013-03-06  6:08 Magnus Damm
  2013-03-06  7:55 ` Simon Horman
  0 siblings, 1 reply; 2+ messages in thread
From: Magnus Damm @ 2013-03-06  6:08 UTC (permalink / raw)
  To: linux-sh

From: Magnus Damm <damm@opensource.se>

The platform data for the INTC irq pin driver
seems to be global symbols, make it static to
allow multi-soc build.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 arch/arm/mach-shmobile/setup-sh73a0.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- 0001/arch/arm/mach-shmobile/setup-sh73a0.c
+++ work/arch/arm/mach-shmobile/setup-sh73a0.c	2013-03-06 15:03:05.000000000 +0900
@@ -782,7 +782,7 @@ static struct platform_device pmu_device
 	.resource	= pmu_resources,
 };
 
-struct renesas_intc_irqpin_config irqpin0_platform_data = {
+static struct renesas_intc_irqpin_config irqpin0_platform_data = {
 	.irq_base = irq_pin(0), /* IRQ0 -> IRQ7 */
 };
 
@@ -812,7 +812,7 @@ static struct platform_device irqpin0_de
 	},
 };
 
-struct renesas_intc_irqpin_config irqpin1_platform_data = {
+static struct renesas_intc_irqpin_config irqpin1_platform_data = {
 	.irq_base = irq_pin(8), /* IRQ8 -> IRQ15 */
 	.control_parent = true, /* Disable spurious IRQ10 */
 };
@@ -843,7 +843,7 @@ static struct platform_device irqpin1_de
 	},
 };
 
-struct renesas_intc_irqpin_config irqpin2_platform_data = {
+static struct renesas_intc_irqpin_config irqpin2_platform_data = {
 	.irq_base = irq_pin(16), /* IRQ16 -> IRQ23 */
 };
 
@@ -873,7 +873,7 @@ static struct platform_device irqpin2_de
 	},
 };
 
-struct renesas_intc_irqpin_config irqpin3_platform_data = {
+static struct renesas_intc_irqpin_config irqpin3_platform_data = {
 	.irq_base = irq_pin(24), /* IRQ24 -> IRQ31 */
 };
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: shmobile: Make sh73a0 INTC irqpin platform data static
  2013-03-06  6:08 [PATCH] ARM: shmobile: Make sh73a0 INTC irqpin platform data static Magnus Damm
@ 2013-03-06  7:55 ` Simon Horman
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2013-03-06  7:55 UTC (permalink / raw)
  To: linux-sh

On Wed, Mar 06, 2013 at 03:08:31PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> The platform data for the INTC irq pin driver
> seems to be global symbols, make it static to
> allow multi-soc build.

I have added this to topic/intc-external-irq with the related patches.
The holding-pen for INTC.

I'm also fine with you sending a v2 of revisions to unmerged patches.

> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  arch/arm/mach-shmobile/setup-sh73a0.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> --- 0001/arch/arm/mach-shmobile/setup-sh73a0.c
> +++ work/arch/arm/mach-shmobile/setup-sh73a0.c	2013-03-06 15:03:05.000000000 +0900
> @@ -782,7 +782,7 @@ static struct platform_device pmu_device
>  	.resource	= pmu_resources,
>  };
>  
> -struct renesas_intc_irqpin_config irqpin0_platform_data = {
> +static struct renesas_intc_irqpin_config irqpin0_platform_data = {
>  	.irq_base = irq_pin(0), /* IRQ0 -> IRQ7 */
>  };
>  
> @@ -812,7 +812,7 @@ static struct platform_device irqpin0_de
>  	},
>  };
>  
> -struct renesas_intc_irqpin_config irqpin1_platform_data = {
> +static struct renesas_intc_irqpin_config irqpin1_platform_data = {
>  	.irq_base = irq_pin(8), /* IRQ8 -> IRQ15 */
>  	.control_parent = true, /* Disable spurious IRQ10 */
>  };
> @@ -843,7 +843,7 @@ static struct platform_device irqpin1_de
>  	},
>  };
>  
> -struct renesas_intc_irqpin_config irqpin2_platform_data = {
> +static struct renesas_intc_irqpin_config irqpin2_platform_data = {
>  	.irq_base = irq_pin(16), /* IRQ16 -> IRQ23 */
>  };
>  
> @@ -873,7 +873,7 @@ static struct platform_device irqpin2_de
>  	},
>  };
>  
> -struct renesas_intc_irqpin_config irqpin3_platform_data = {
> +static struct renesas_intc_irqpin_config irqpin3_platform_data = {
>  	.irq_base = irq_pin(24), /* IRQ24 -> IRQ31 */
>  };
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-06  7:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-06  6:08 [PATCH] ARM: shmobile: Make sh73a0 INTC irqpin platform data static Magnus Damm
2013-03-06  7:55 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox