APE6EVM and Runtime PM

APE6EVM and Runtime PM

[Simon Horman]

Hi Magnus,

in the course of looking look at consolidating our defconfigs I
noticed that SMSC ethernet and rcar_thermal seem seem to not work when
runtime PM is enabled.

I'm wondering if you have any ideas of what might be the cause of this
or if you could give me some guidance on investigating this problem.

I assume that it relates to a clock or clocks not being enabled.

Re: APE6EVM and Runtime PM

[Kuninori Morimoto]

Hi Simon

> in the course of looking look at consolidating our defconfigs I
> noticed that SMSC ethernet and rcar_thermal seem seem to not work when
> runtime PM is enabled.
> 
> I'm wondering if you have any ideas of what might be the cause of this
> or if you could give me some guidance on investigating this problem.
> 
> I assume that it relates to a clock or clocks not being enabled.

About rcar_thermal, it needs my patch which was sent to PM ML.
I got email from Zhang that he accepted my patch (pm_runtime support for thermal).
But it seems he didn't push his branch yet...
I guess I explained this on my [PATCH 0/x] email.

Best regards
---
Kuninori Morimoto

Re: APE6EVM and Runtime PM

[Simon Horman]

On Wed, Apr 03, 2013 at 08:26:39PM -0700, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > in the course of looking look at consolidating our defconfigs I
> > noticed that SMSC ethernet and rcar_thermal seem seem to not work when
> > runtime PM is enabled.
> > 
> > I'm wondering if you have any ideas of what might be the cause of this
> > or if you could give me some guidance on investigating this problem.
> > 
> > I assume that it relates to a clock or clocks not being enabled.
> 
> About rcar_thermal, it needs my patch which was sent to PM ML.
> I got email from Zhang that he accepted my patch (pm_runtime support for thermal).
> But it seems he didn't push his branch yet...
> I guess I explained this on my [PATCH 0/x] email.

Thanks, sorry for missing that.

I guess we are down to just SMSC then.

Re: APE6EVM and Runtime PM

[Kuninori Morimoto]

Dear Simon

> > > in the course of looking look at consolidating our defconfigs I
> > > noticed that SMSC ethernet and rcar_thermal seem seem to not work when
> > > runtime PM is enabled.
> > > 
> > > I'm wondering if you have any ideas of what might be the cause of this
> > > or if you could give me some guidance on investigating this problem.
> > > 
> > > I assume that it relates to a clock or clocks not being enabled.
> > 
> > About rcar_thermal, it needs my patch which was sent to PM ML.
> > I got email from Zhang that he accepted my patch (pm_runtime support for thermal).
> > But it seems he didn't push his branch yet...
> > I guess I explained this on my [PATCH 0/x] email.
> 
> Thanks, sorry for missing that.
> 
> I guess we are down to just SMSC then.

I didn't check real board,
but I guess current SMSC IRQ came from IRQC,
and this IRQC needs MSTP 407.
But IRQC driver seems doesn't support PM_RUNTIME at this point.

Does your issue solve by adding MSTP 407 with CLK_ENABLE_ON_INIT ?
I'm not sure this is good solution, but quick-hack

Best regards
--
Kuninori Morimoto
 

Re: APE6EVM and Runtime PM

[Simon Horman]

On Thu, Apr 04, 2013 at 02:28:38PM +0900, Kuninori Morimoto wrote:
> 
> Dear Simon
> 
> > > > in the course of looking look at consolidating our defconfigs I
> > > > noticed that SMSC ethernet and rcar_thermal seem seem to not work when
> > > > runtime PM is enabled.
> > > > 
> > > > I'm wondering if you have any ideas of what might be the cause of this
> > > > or if you could give me some guidance on investigating this problem.
> > > > 
> > > > I assume that it relates to a clock or clocks not being enabled.
> > > 
> > > About rcar_thermal, it needs my patch which was sent to PM ML.
> > > I got email from Zhang that he accepted my patch (pm_runtime support for thermal).
> > > But it seems he didn't push his branch yet...
> > > I guess I explained this on my [PATCH 0/x] email.
> > 
> > Thanks, sorry for missing that.
> > 
> > I guess we are down to just SMSC then.
> 
> I didn't check real board,
> but I guess current SMSC IRQ came from IRQC,
> and this IRQC needs MSTP 407.
> But IRQC driver seems doesn't support PM_RUNTIME at this point.
> 
> Does your issue solve by adding MSTP 407 with CLK_ENABLE_ON_INIT ?
> I'm not sure this is good solution, but quick-hack

Thanks!

I will post a patch to add pm_runtime support to the IRQC Driver.
It seems to allow SMSC + RUNTIME_PM to function on the APE6EVM.

Re: APE6EVM and Runtime PM

[Simon Horman]

On Thu, Apr 04, 2013 at 03:14:33PM +0900, Simon Horman wrote:
> On Thu, Apr 04, 2013 at 02:28:38PM +0900, Kuninori Morimoto wrote:
> > 
> > Dear Simon
> > 
> > > > > in the course of looking look at consolidating our defconfigs I
> > > > > noticed that SMSC ethernet and rcar_thermal seem seem to not work when
> > > > > runtime PM is enabled.
> > > > > 
> > > > > I'm wondering if you have any ideas of what might be the cause of this
> > > > > or if you could give me some guidance on investigating this problem.
> > > > > 
> > > > > I assume that it relates to a clock or clocks not being enabled.
> > > > 
> > > > About rcar_thermal, it needs my patch which was sent to PM ML.
> > > > I got email from Zhang that he accepted my patch (pm_runtime support for thermal).
> > > > But it seems he didn't push his branch yet...
> > > > I guess I explained this on my [PATCH 0/x] email.
> > > 
> > > Thanks, sorry for missing that.
> > > 
> > > I guess we are down to just SMSC then.
> > 
> > I didn't check real board,
> > but I guess current SMSC IRQ came from IRQC,
> > and this IRQC needs MSTP 407.
> > But IRQC driver seems doesn't support PM_RUNTIME at this point.
> > 
> > Does your issue solve by adding MSTP 407 with CLK_ENABLE_ON_INIT ?
> > I'm not sure this is good solution, but quick-hack
> 
> Thanks!
> 
> I will post a patch to add pm_runtime support to the IRQC Driver.
> It seems to allow SMSC + RUNTIME_PM to function on the APE6EVM.

For reference, I have posted "irqchip: irqc: Add runtime PM support"

Re: APE6EVM and Runtime PM

[Kuninori Morimoto]

Hi Simon

> > I didn't check real board,
> > but I guess current SMSC IRQ came from IRQC,
> > and this IRQC needs MSTP 407.
> > But IRQC driver seems doesn't support PM_RUNTIME at this point.
> > 
> > Does your issue solve by adding MSTP 407 with CLK_ENABLE_ON_INIT ?
> > I'm not sure this is good solution, but quick-hack
> 
> Thanks!
> 
> I will post a patch to add pm_runtime support to the IRQC Driver.
> It seems to allow SMSC + RUNTIME_PM to function on the APE6EVM.

Cool !!
Thanks

Best regards
---
Kuninori Morimoto