[RFC][PATCH 3/4] ARM: shmobile: r8a7778: Register PFC drivce

[RFC][PATCH 3/4] ARM: shmobile: r8a7778: Register PFC drivce

[Kuninori Morimoto]

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm/mach-shmobile/include/mach/r8a7778.h |    1 +
 arch/arm/mach-shmobile/setup-r8a7778.c        |   13 +++++++++++++
 2 files changed, 14 insertions(+)

diff --git a/arch/arm/mach-shmobile/include/mach/r8a7778.h b/arch/arm/mach-shmobile/include/mach/r8a7778.h
index 951149e..68053fc 100644
--- a/arch/arm/mach-shmobile/include/mach/r8a7778.h
+++ b/arch/arm/mach-shmobile/include/mach/r8a7778.h
@@ -28,5 +28,6 @@ extern void r8a7778_init_irq(void);
 extern void r8a7778_init_irq_dt(void);
 extern void r8a7778_clock_init(void);
 extern void r8a7778_init_irq_extpin(int irlm);
+extern void r8a7778_pinmux_init(void);
 
 #endif /* __ASM_R8A7778_H__ */
diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c b/arch/arm/mach-shmobile/setup-r8a7778.c
index d6ee521..6c1cc80 100644
--- a/arch/arm/mach-shmobile/setup-r8a7778.c
+++ b/arch/arm/mach-shmobile/setup-r8a7778.c
@@ -102,6 +102,19 @@ void __init r8a7778_add_ether_device(struct sh_eth_plat_data *pdata)
 					  pdata, sizeof(*pdata));
 }
 
+/* PFC */
+static struct resource pfc_resources[] = {
+	DEFINE_RES_MEM(0xfffc0000, 0x118),
+};
+
+void __init r8a7778_pinmux_init(void)
+{
+	platform_device_register_simple(
+		"pfc-r8a7778", -1,
+		pfc_resources,
+		ARRAY_SIZE(pfc_resources));
+}
+
 void __init r8a7778_add_standard_devices(void)
 {
 	int i;
-- 
1.7.9.5

Re: [RFC][PATCH 3/4] ARM: shmobile: r8a7778: Register PFC drivce

[Sergei Shtylyov]

Hello.

On 09-04-2013 9:33, Kuninori Morimoto wrote:

    Typo in the subject: s/drivce/device/

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

WBR, Sergei

Re: [RFC][PATCH 3/4] ARM: shmobile: r8a7778: Register PFC drivce

[Laurent Pinchart]

Hi Morimoto-san,

Thank you for the patch.

On Monday 08 April 2013 22:33:56 Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

With the drivce replaced by device in the subject line,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/mach-shmobile/include/mach/r8a7778.h |    1 +
>  arch/arm/mach-shmobile/setup-r8a7778.c        |   13 +++++++++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/arch/arm/mach-shmobile/include/mach/r8a7778.h
> b/arch/arm/mach-shmobile/include/mach/r8a7778.h index 951149e..68053fc
> 100644
> --- a/arch/arm/mach-shmobile/include/mach/r8a7778.h
> +++ b/arch/arm/mach-shmobile/include/mach/r8a7778.h
> @@ -28,5 +28,6 @@ extern void r8a7778_init_irq(void);
>  extern void r8a7778_init_irq_dt(void);
>  extern void r8a7778_clock_init(void);
>  extern void r8a7778_init_irq_extpin(int irlm);
> +extern void r8a7778_pinmux_init(void);
> 
>  #endif /* __ASM_R8A7778_H__ */
> diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c
> b/arch/arm/mach-shmobile/setup-r8a7778.c index d6ee521..6c1cc80 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7778.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7778.c
> @@ -102,6 +102,19 @@ void __init r8a7778_add_ether_device(struct
> sh_eth_plat_data *pdata) pdata, sizeof(*pdata));
>  }
> 
> +/* PFC */
> +static struct resource pfc_resources[] = {
> +	DEFINE_RES_MEM(0xfffc0000, 0x118),
> +};
> +
> +void __init r8a7778_pinmux_init(void)
> +{
> +	platform_device_register_simple(
> +		"pfc-r8a7778", -1,
> +		pfc_resources,
> +		ARRAY_SIZE(pfc_resources));
> +}
> +
>  void __init r8a7778_add_standard_devices(void)
>  {
>  	int i;
-- 
Regards,

Laurent Pinchart

Re: [RFC][PATCH 3/4] ARM: shmobile: r8a7778: Register PFC drivce

[Simon Horman]

On Tue, Apr 09, 2013 at 04:24:19PM +0200, Laurent Pinchart wrote:
> Hi Morimoto-san,
> 
> Thank you for the patch.
> 
> On Monday 08 April 2013 22:33:56 Kuninori Morimoto wrote:
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> With the drivce replaced by device in the subject line,
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks, I have queued this up in the soc-r7a7778 branch with the subject
corrected.

> > ---
> >  arch/arm/mach-shmobile/include/mach/r8a7778.h |    1 +
> >  arch/arm/mach-shmobile/setup-r8a7778.c        |   13 +++++++++++++
> >  2 files changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm/mach-shmobile/include/mach/r8a7778.h
> > b/arch/arm/mach-shmobile/include/mach/r8a7778.h index 951149e..68053fc
> > 100644
> > --- a/arch/arm/mach-shmobile/include/mach/r8a7778.h
> > +++ b/arch/arm/mach-shmobile/include/mach/r8a7778.h
> > @@ -28,5 +28,6 @@ extern void r8a7778_init_irq(void);
> >  extern void r8a7778_init_irq_dt(void);
> >  extern void r8a7778_clock_init(void);
> >  extern void r8a7778_init_irq_extpin(int irlm);
> > +extern void r8a7778_pinmux_init(void);
> > 
> >  #endif /* __ASM_R8A7778_H__ */
> > diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c
> > b/arch/arm/mach-shmobile/setup-r8a7778.c index d6ee521..6c1cc80 100644
> > --- a/arch/arm/mach-shmobile/setup-r8a7778.c
> > +++ b/arch/arm/mach-shmobile/setup-r8a7778.c
> > @@ -102,6 +102,19 @@ void __init r8a7778_add_ether_device(struct
> > sh_eth_plat_data *pdata) pdata, sizeof(*pdata));
> >  }
> > 
> > +/* PFC */
> > +static struct resource pfc_resources[] = {
> > +	DEFINE_RES_MEM(0xfffc0000, 0x118),
> > +};
> > +
> > +void __init r8a7778_pinmux_init(void)
> > +{
> > +	platform_device_register_simple(
> > +		"pfc-r8a7778", -1,
> > +		pfc_resources,
> > +		ARRAY_SIZE(pfc_resources));
> > +}
> > +
> >  void __init r8a7778_add_standard_devices(void)
> >  {
> >  	int i;
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [RFC][PATCH 3/4] ARM: shmobile: r8a7778: Register PFC drivce

[Simon Horman]

On Wed, Apr 10, 2013 at 11:17:57AM +0900, Simon Horman wrote:
> On Tue, Apr 09, 2013 at 04:24:19PM +0200, Laurent Pinchart wrote:
> > Hi Morimoto-san,
> > 
> > Thank you for the patch.
> > 
> > On Monday 08 April 2013 22:33:56 Kuninori Morimoto wrote:
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > With the drivce replaced by device in the subject line,
> > 
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Thanks, I have queued this up in the soc-r7a7778 branch with the subject
> corrected.

Actually, scratch that.
There is a run-time dependency on an earlier patch in the series, right?

> > > ---
> > >  arch/arm/mach-shmobile/include/mach/r8a7778.h |    1 +
> > >  arch/arm/mach-shmobile/setup-r8a7778.c        |   13 +++++++++++++
> > >  2 files changed, 14 insertions(+)
> > > 
> > > diff --git a/arch/arm/mach-shmobile/include/mach/r8a7778.h
> > > b/arch/arm/mach-shmobile/include/mach/r8a7778.h index 951149e..68053fc
> > > 100644
> > > --- a/arch/arm/mach-shmobile/include/mach/r8a7778.h
> > > +++ b/arch/arm/mach-shmobile/include/mach/r8a7778.h
> > > @@ -28,5 +28,6 @@ extern void r8a7778_init_irq(void);
> > >  extern void r8a7778_init_irq_dt(void);
> > >  extern void r8a7778_clock_init(void);
> > >  extern void r8a7778_init_irq_extpin(int irlm);
> > > +extern void r8a7778_pinmux_init(void);
> > > 
> > >  #endif /* __ASM_R8A7778_H__ */
> > > diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c
> > > b/arch/arm/mach-shmobile/setup-r8a7778.c index d6ee521..6c1cc80 100644
> > > --- a/arch/arm/mach-shmobile/setup-r8a7778.c
> > > +++ b/arch/arm/mach-shmobile/setup-r8a7778.c
> > > @@ -102,6 +102,19 @@ void __init r8a7778_add_ether_device(struct
> > > sh_eth_plat_data *pdata) pdata, sizeof(*pdata));
> > >  }
> > > 
> > > +/* PFC */
> > > +static struct resource pfc_resources[] = {
> > > +	DEFINE_RES_MEM(0xfffc0000, 0x118),
> > > +};
> > > +
> > > +void __init r8a7778_pinmux_init(void)
> > > +{
> > > +	platform_device_register_simple(
> > > +		"pfc-r8a7778", -1,
> > > +		pfc_resources,
> > > +		ARRAY_SIZE(pfc_resources));
> > > +}
> > > +
> > >  void __init r8a7778_add_standard_devices(void)
> > >  {
> > >  	int i;
> > -- 
> > Regards,
> > 
> > Laurent Pinchart
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [RFC][PATCH 3/4] ARM: shmobile: r8a7778: Register PFC drivce

[Kuninori Morimoto]

Hi Simon

> On Wed, Apr 10, 2013 at 11:17:57AM +0900, Simon Horman wrote:
> > On Tue, Apr 09, 2013 at 04:24:19PM +0200, Laurent Pinchart wrote:
> > > Hi Morimoto-san,
> > > 
> > > Thank you for the patch.
> > > 
> > > On Monday 08 April 2013 22:33:56 Kuninori Morimoto wrote:
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > 
> > > With the drivce replaced by device in the subject line,
> > > 
> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > Thanks, I have queued this up in the soc-r7a7778 branch with the subject
> > corrected.
> 
> Actually, scratch that.
> There is a run-time dependency on an earlier patch in the series, right?

This patch depends on [1/x] patch, and I will send v2 patch today


Best regards
---
Kuninori Morimoto

Re: [RFC][PATCH 3/4] ARM: shmobile: r8a7778: Register PFC drivce

[Simon Horman]

On Tue, Apr 09, 2013 at 07:26:01PM -0700, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > On Wed, Apr 10, 2013 at 11:17:57AM +0900, Simon Horman wrote:
> > > On Tue, Apr 09, 2013 at 04:24:19PM +0200, Laurent Pinchart wrote:
> > > > Hi Morimoto-san,
> > > > 
> > > > Thank you for the patch.
> > > > 
> > > > On Monday 08 April 2013 22:33:56 Kuninori Morimoto wrote:
> > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > 
> > > > With the drivce replaced by device in the subject line,
> > > > 
> > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > 
> > > Thanks, I have queued this up in the soc-r7a7778 branch with the subject
> > > corrected.
> > 
> > Actually, scratch that.
> > There is a run-time dependency on an earlier patch in the series, right?
> 
> This patch depends on [1/x] patch, and I will send v2 patch today

Thanks, understood.

Could you note that in the changelog, perhaps under a "---"?
It might help me to avoid the same mistake a second time.

Re: [RFC][PATCH 3/4] ARM: shmobile: r8a7778: Register PFC drivce

[Kuninori Morimoto]

Hi Simon

> > > Actually, scratch that.
> > > There is a run-time dependency on an earlier patch in the series, right?
> > 
> > This patch depends on [1/x] patch, and I will send v2 patch today
> 
> Thanks, understood.
> 
> Could you note that in the changelog, perhaps under a "---"?
> It might help me to avoid the same mistake a second time.

Hmm...
I guess "[3/4] depends on [1/4]" is normal ?

But, whole this series depends on Laurent's

Subject: [PATCH v2 1/3] gpio-rcar: Add RCAR_GP_PIN macro
Date:	Mon,  8 Apr 2013 12:05:30 +0200

Please see [0/4] comment


Best regards
---
Kuninori Morimoto

Re: [RFC][PATCH 3/4] ARM: shmobile: r8a7778: Register PFC drivce

[Simon Horman]

On Tue, Apr 09, 2013 at 10:25:12PM -0700, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > > Actually, scratch that.
> > > > There is a run-time dependency on an earlier patch in the series, right?
> > > 
> > > This patch depends on [1/x] patch, and I will send v2 patch today
> > 
> > Thanks, understood.
> > 
> > Could you note that in the changelog, perhaps under a "---"?
> > It might help me to avoid the same mistake a second time.
> 
> Hmm...
> I guess "[3/4] depends on [1/4]" is normal ?

Yes, I guess so :^)

> But, whole this series depends on Laurent's
> 
> Subject: [PATCH v2 1/3] gpio-rcar: Add RCAR_GP_PIN macro
> Date:	Mon,  8 Apr 2013 12:05:30 +0200
> 
> Please see [0/4] comment

Thanks for clearing up my confusion.