SUPERH platform development
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ARM: shmobile: r8a7779: Wait for status on selected MSTP clocks
Date: Tue, 26 Nov 2013 00:26:04 +0000	[thread overview]
Message-ID: <20131126002603.GF15227@verge.net.au> (raw)
In-Reply-To: <1384357973-27365-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

On Mon, Nov 25, 2013 at 03:19:23PM +0100, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Monday 25 November 2013 12:36:31 Simon Horman wrote:
> > On Sun, Nov 24, 2013 at 04:23:50PM -0800, Kuninori Morimoto wrote:
> > > Hi Laurent, Simon
> > > 
> > > > > > I've removed them as they're unused. This could be split to a
> > > > > > separate patch if preferred, I've just thought it would be overkill.
> > > > > 
> > > > > Yes, they are not used, but it doesn't have relationship to this
> > > > > patch.
> > > > 
> > > > I've considered the change to be related, at this patch fixes the MSTP
> > > > clock definitions. Of course if you disagree I'm fine with removing
> > > > this change.
> > > > >
> > > > > (and, do we really need to remove these ?)
> > > > 
> > > > They're not used, so I thought it would be good to remove them.
> > > > 
> > > > > This is not super big deal,
> > > > > but I was ordered many times not to do such things at other ML.
> > > > > 
> > > > > Let's follow the opinion of Simon.
> > > > 
> > > > Sounds good to me :-)
> > > 
> > > Thank you :)
> > > Sorry for my picky comment :P
> > > 
> > > Simon, we need your opinion.
> > 
> > I would prefer separate patches.
> 
> OK, I'll resubmit this patch without the removal of the unused macros. As 
> you've originally submitted a patch to remove the macros, would you like to 
> rebase it on top of this, or should I include one in the repost ?

I can rebase that patch, seeing as its mine.

      parent reply	other threads:[~2013-11-26  0:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 15:52 [PATCH v2 2/3] ARM: shmobile: r8a7779: Wait for status on selected MSTP clocks Laurent Pinchart
2013-11-21  2:07 ` Kuninori Morimoto
2013-11-21  8:26 ` Laurent Pinchart
2013-11-25  0:05 ` Kuninori Morimoto
2013-11-25  0:08 ` Laurent Pinchart
2013-11-25  0:23 ` Kuninori Morimoto
2013-11-25  3:36 ` Simon Horman
2013-11-25 14:19 ` Laurent Pinchart
2013-11-26  0:26 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131126002603.GF15227@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox