* Re: [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()
2014-07-30 23:32 [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late() Magnus Damm
@ 2014-07-31 0:12 ` Simon Horman
2014-07-31 1:05 ` Magnus Damm
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2014-07-31 0:12 UTC (permalink / raw)
To: linux-sh
On Thu, Jul 31, 2014 at 08:32:06AM +0900, Magnus Damm wrote:
> ARM: shmobile: Consistent use of shmobile_init_late()
>
> [PATCH 01/09] ARM: shmobile: Add shmobile_init_late() to sh73a0
> [PATCH 02/09] ARM: shmobile: Add shmobile_init_late() to KZM9G
> [PATCH 03/09] ARM: shmobile: Fix shmobile_init_late() on r8a7779
> [PATCH 04/09] ARM: shmobile: Add shmobile_init_late() to Marzen
> [PATCH 05/09] ARM: shmobile: Fix shmobile_init_late() on r8a7778
> [PATCH 06/09] ARM: shmobile: Add shmobile_init_late() to Bock-W
> [PATCH 07/09] ARM: shmobile: Add shmobile_init_late() to r8a73a4
> [PATCH 08/09] ARM: shmobile: Add shmobile_init_late() to APE6EVM
> [PATCH 09/09] ARM: shmobile: Add shmobile_init_late() to r7s72100
>
> Make sure all mach-shmobile SoCs and DT Reference board support code
> call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup
> in a consistent way. The SoC DT case for r8a7778 and r8a7779 are
> also adjusted to not add any platform devices. DT shall be used instead.
Hi Magnus,
these patches seem fine for me but I wonder if you could follow the
convention that has emerged as being dominant for subjects
for shmobile patches.
* Using lowercase for SOC names
* Omitting hyphens from boards names (i.e. bockw)
* Putting the board or soc after "shmobile: " and followed by a ':'.
I have taken the liberty of updating the patch names to the
following and queued up the result:
ARM: shmobile: sh73a0: Add shmobile_init_late()
ARM: shmobile: kzm9g: Add shmobile_init_late()
ARM: shmobile: r8a7779: Fix shmobile_init_late()
ARM: shmobile: marzen: Add shmobile_init_late()
ARM: shmobile: r8a7778: Fix shmobile_init_late()
ARM: shmobile: bockw: Add shmobile_init_late()
ARM: shmobile: r8a73a4: Add shmobile_init_late()
ARM: shmobile: ape6evm: Add shmobile_init_late()
ARM: shmobile: r7s72100: Add shmobile_init_late()
The reason for requesting this is that from time to time
I in turn receive requests to make subjects consistent.
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
>
> Written on top of renesas-devel-v3.16-rc7-20140729
>
> arch/arm/mach-shmobile/board-ape6evm-reference.c | 1 +
> arch/arm/mach-shmobile/board-ape6evm.c | 1 +
> arch/arm/mach-shmobile/board-bockw-reference.c | 1 +
> arch/arm/mach-shmobile/board-kzm9g-reference.c | 1 +
> arch/arm/mach-shmobile/board-marzen-reference.c | 1 +
> arch/arm/mach-shmobile/setup-r7s72100.c | 1 +
> arch/arm/mach-shmobile/setup-r8a73a4.c | 1 +
> arch/arm/mach-shmobile/setup-r8a7778.c | 2 +-
> arch/arm/mach-shmobile/setup-r8a7779.c | 2 +-
> arch/arm/mach-shmobile/setup-sh73a0.c | 1 +
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()
2014-07-30 23:32 [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late() Magnus Damm
2014-07-31 0:12 ` Simon Horman
@ 2014-07-31 1:05 ` Magnus Damm
2014-07-31 2:29 ` Simon Horman
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Magnus Damm @ 2014-07-31 1:05 UTC (permalink / raw)
To: linux-sh
On Thu, Jul 31, 2014 at 9:12 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Jul 31, 2014 at 08:32:06AM +0900, Magnus Damm wrote:
>> ARM: shmobile: Consistent use of shmobile_init_late()
>>
>> [PATCH 01/09] ARM: shmobile: Add shmobile_init_late() to sh73a0
>> [PATCH 02/09] ARM: shmobile: Add shmobile_init_late() to KZM9G
>> [PATCH 03/09] ARM: shmobile: Fix shmobile_init_late() on r8a7779
>> [PATCH 04/09] ARM: shmobile: Add shmobile_init_late() to Marzen
>> [PATCH 05/09] ARM: shmobile: Fix shmobile_init_late() on r8a7778
>> [PATCH 06/09] ARM: shmobile: Add shmobile_init_late() to Bock-W
>> [PATCH 07/09] ARM: shmobile: Add shmobile_init_late() to r8a73a4
>> [PATCH 08/09] ARM: shmobile: Add shmobile_init_late() to APE6EVM
>> [PATCH 09/09] ARM: shmobile: Add shmobile_init_late() to r7s72100
>>
>> Make sure all mach-shmobile SoCs and DT Reference board support code
>> call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup
>> in a consistent way. The SoC DT case for r8a7778 and r8a7779 are
>> also adjusted to not add any platform devices. DT shall be used instead.
>
> Hi Magnus,
>
> these patches seem fine for me but I wonder if you could follow the
> convention that has emerged as being dominant for subjects
> for shmobile patches.
>
> * Using lowercase for SOC names
> * Omitting hyphens from boards names (i.e. bockw)
> * Putting the board or soc after "shmobile: " and followed by a ':'.
>
> I have taken the liberty of updating the patch names to the
> following and queued up the result:
>
> ARM: shmobile: sh73a0: Add shmobile_init_late()
> ARM: shmobile: kzm9g: Add shmobile_init_late()
> ARM: shmobile: r8a7779: Fix shmobile_init_late()
> ARM: shmobile: marzen: Add shmobile_init_late()
> ARM: shmobile: r8a7778: Fix shmobile_init_late()
> ARM: shmobile: bockw: Add shmobile_init_late()
> ARM: shmobile: r8a73a4: Add shmobile_init_late()
> ARM: shmobile: ape6evm: Add shmobile_init_late()
> ARM: shmobile: r7s72100: Add shmobile_init_late()
>
> The reason for requesting this is that from time to time
> I in turn receive requests to make subjects consistent.
Hi Simon,
Thanks for fixing up inconsistencies and picking up patches. I agree
with the hyphen removal - why on earth would anyone want a hyphen in
their board name anyway? Lower case SoC name makes sense - with the
exception on EMEV2, but I'm fine adjusting that to lower case too. =)
The upper case board name is something that i've used over many years,
but I will do my best to try to adjust my default mode of operation
and stick to lower case from now on.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()
2014-07-30 23:32 [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late() Magnus Damm
2014-07-31 0:12 ` Simon Horman
2014-07-31 1:05 ` Magnus Damm
@ 2014-07-31 2:29 ` Simon Horman
2014-08-04 13:11 ` Geert Uytterhoeven
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2014-07-31 2:29 UTC (permalink / raw)
To: linux-sh
On Thu, Jul 31, 2014 at 10:05:03AM +0900, Magnus Damm wrote:
> On Thu, Jul 31, 2014 at 9:12 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Jul 31, 2014 at 08:32:06AM +0900, Magnus Damm wrote:
> >> ARM: shmobile: Consistent use of shmobile_init_late()
> >>
> >> [PATCH 01/09] ARM: shmobile: Add shmobile_init_late() to sh73a0
> >> [PATCH 02/09] ARM: shmobile: Add shmobile_init_late() to KZM9G
> >> [PATCH 03/09] ARM: shmobile: Fix shmobile_init_late() on r8a7779
> >> [PATCH 04/09] ARM: shmobile: Add shmobile_init_late() to Marzen
> >> [PATCH 05/09] ARM: shmobile: Fix shmobile_init_late() on r8a7778
> >> [PATCH 06/09] ARM: shmobile: Add shmobile_init_late() to Bock-W
> >> [PATCH 07/09] ARM: shmobile: Add shmobile_init_late() to r8a73a4
> >> [PATCH 08/09] ARM: shmobile: Add shmobile_init_late() to APE6EVM
> >> [PATCH 09/09] ARM: shmobile: Add shmobile_init_late() to r7s72100
> >>
> >> Make sure all mach-shmobile SoCs and DT Reference board support code
> >> call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup
> >> in a consistent way. The SoC DT case for r8a7778 and r8a7779 are
> >> also adjusted to not add any platform devices. DT shall be used instead.
> >
> > Hi Magnus,
> >
> > these patches seem fine for me but I wonder if you could follow the
> > convention that has emerged as being dominant for subjects
> > for shmobile patches.
> >
> > * Using lowercase for SOC names
> > * Omitting hyphens from boards names (i.e. bockw)
> > * Putting the board or soc after "shmobile: " and followed by a ':'.
> >
> > I have taken the liberty of updating the patch names to the
> > following and queued up the result:
> >
> > ARM: shmobile: sh73a0: Add shmobile_init_late()
> > ARM: shmobile: kzm9g: Add shmobile_init_late()
> > ARM: shmobile: r8a7779: Fix shmobile_init_late()
> > ARM: shmobile: marzen: Add shmobile_init_late()
> > ARM: shmobile: r8a7778: Fix shmobile_init_late()
> > ARM: shmobile: bockw: Add shmobile_init_late()
> > ARM: shmobile: r8a73a4: Add shmobile_init_late()
> > ARM: shmobile: ape6evm: Add shmobile_init_late()
> > ARM: shmobile: r7s72100: Add shmobile_init_late()
> >
> > The reason for requesting this is that from time to time
> > I in turn receive requests to make subjects consistent.
>
> Hi Simon,
>
> Thanks for fixing up inconsistencies and picking up patches. I agree
> with the hyphen removal - why on earth would anyone want a hyphen in
> their board name anyway? Lower case SoC name makes sense - with the
> exception on EMEV2, but I'm fine adjusting that to lower case too. =)
>
> The upper case board name is something that i've used over many years,
> but I will do my best to try to adjust my default mode of operation
> and stick to lower case from now on.
Thanks, I know that everyone isn't entirely sold on the convention.
But it seems easiest to follow it for now.
I agree about the hyphen :)
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()
2014-07-30 23:32 [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late() Magnus Damm
` (2 preceding siblings ...)
2014-07-31 2:29 ` Simon Horman
@ 2014-08-04 13:11 ` Geert Uytterhoeven
2014-08-05 5:49 ` Magnus Damm
2014-08-13 11:46 ` Geert Uytterhoeven
5 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2014-08-04 13:11 UTC (permalink / raw)
To: linux-sh
Hi Magnus,
On Thu, Jul 31, 2014 at 1:32 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> Make sure all mach-shmobile SoCs and DT Reference board support code
> call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup
> in a consistent way. The SoC DT case for r8a7778 and r8a7779 are
> also adjusted to not add any platform devices. DT shall be used instead.
Aha, that last part was missing from the individual descriptions for
r8a7778 and r8a7779 ;-)
r8a7779_init_late() already called shmobile_init_late() internally.
However, r8a7778_init_late() doesn't call shmobile_init_late(). Shouldn't
that be added, too, to fix bockw?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()
2014-07-30 23:32 [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late() Magnus Damm
` (3 preceding siblings ...)
2014-08-04 13:11 ` Geert Uytterhoeven
@ 2014-08-05 5:49 ` Magnus Damm
2014-08-13 11:46 ` Geert Uytterhoeven
5 siblings, 0 replies; 7+ messages in thread
From: Magnus Damm @ 2014-08-05 5:49 UTC (permalink / raw)
To: linux-sh
Hi Geert,
On Mon, Aug 4, 2014 at 10:11 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Magnus,
>
> On Thu, Jul 31, 2014 at 1:32 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> Make sure all mach-shmobile SoCs and DT Reference board support code
>> call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup
>> in a consistent way. The SoC DT case for r8a7778 and r8a7779 are
>> also adjusted to not add any platform devices. DT shall be used instead.
>
> Aha, that last part was missing from the individual descriptions for
> r8a7778 and r8a7779 ;-)
> r8a7779_init_late() already called shmobile_init_late() internally.
Right, next time I'll put more contents in the each patch!
> However, r8a7778_init_late() doesn't call shmobile_init_late(). Shouldn't
> that be added, too, to fix bockw?
Maybe so, but I deem the legacy code as a lost cause. I also don't
have any hardware access myself, so I can't test it.
If you feel like it, please cook up a patch then I think Simon or
Morimoto-san can test!
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()
2014-07-30 23:32 [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late() Magnus Damm
` (4 preceding siblings ...)
2014-08-05 5:49 ` Magnus Damm
@ 2014-08-13 11:46 ` Geert Uytterhoeven
5 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2014-08-13 11:46 UTC (permalink / raw)
To: linux-sh
Hi Magnus,
On Tue, Aug 5, 2014 at 7:49 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> On Mon, Aug 4, 2014 at 10:11 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Thu, Jul 31, 2014 at 1:32 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>> Make sure all mach-shmobile SoCs and DT Reference board support code
>>> call shmobile_init_late() so Suspend-to-RAM and CPUIdle get setup
>>> in a consistent way. The SoC DT case for r8a7778 and r8a7779 are
>>> also adjusted to not add any platform devices. DT shall be used instead.
>>
>> Aha, that last part was missing from the individual descriptions for
>> r8a7778 and r8a7779 ;-)
>> r8a7779_init_late() already called shmobile_init_late() internally.
>
> Right, next time I'll put more contents in the each patch!
>
>> However, r8a7778_init_late() doesn't call shmobile_init_late(). Shouldn't
>> that be added, too, to fix bockw?
>
> Maybe so, but I deem the legacy code as a lost cause. I also don't
> have any hardware access myself, so I can't test it.
>
> If you feel like it, please cook up a patch then I think Simon or
> Morimoto-san can test!
Understood. Patch sent.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread