* Re: [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
2014-10-31 0:27 [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig Kuninori Morimoto
@ 2014-12-08 4:37 ` Kuninori Morimoto
2014-12-09 0:20 ` Simon Horman
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2014-12-08 4:37 UTC (permalink / raw)
To: linux-sh
Hi Simon
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v1 -> v2
>
> - no change
>
> arch/arm/configs/shmobile_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index b32afae..a2de58e 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -145,6 +145,7 @@ CONFIG_RTC_CLASS=y
> CONFIG_RTC_DRV_S35390A=y
> CONFIG_DMADEVICES=y
> CONFIG_SH_DMAE=y
> +CONFIG_RCAR_AUDMAC_PP=y
> CONFIG_RCAR_DMAC=y
> # CONFIG_IOMMU_SUPPORT is not set
> CONFIG_PWM=y
Is it possible to revert this patch from defconfig ?
Current upstreamed Audio DMAC peri peri driver is based on SH_DMAE_BASE,
but, it breaks DMAEngine handling.
I fix-uped this issue on below patch, but it is not yet accepted.
Subject: [PATCH][resend] dmaengine: rcar-audmapp: independent from SH_DMAE_BASE
Date: Fri, 28 Nov 2014 00:17:59 +0000
Above patches need this order
[1/2] : dmaengine: rcar-audmapp: independent from SH_DMAE_BASE
[2/2] : ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
It seems that I2C driver is broken by this patch.
I will re-send it if missing DMAEngine patch was accepted.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
2014-10-31 0:27 [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig Kuninori Morimoto
2014-12-08 4:37 ` Kuninori Morimoto
@ 2014-12-09 0:20 ` Simon Horman
2014-12-10 0:58 ` Kuninori Morimoto
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2014-12-09 0:20 UTC (permalink / raw)
To: linux-sh
On Mon, Dec 08, 2014 at 04:37:03AM +0000, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > v1 -> v2
> >
> > - no change
> >
> > arch/arm/configs/shmobile_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> > index b32afae..a2de58e 100644
> > --- a/arch/arm/configs/shmobile_defconfig
> > +++ b/arch/arm/configs/shmobile_defconfig
> > @@ -145,6 +145,7 @@ CONFIG_RTC_CLASS=y
> > CONFIG_RTC_DRV_S35390A=y
> > CONFIG_DMADEVICES=y
> > CONFIG_SH_DMAE=y
> > +CONFIG_RCAR_AUDMAC_PP=y
> > CONFIG_RCAR_DMAC=y
> > # CONFIG_IOMMU_SUPPORT is not set
> > CONFIG_PWM=y
>
> Is it possible to revert this patch from defconfig ?
> Current upstreamed Audio DMAC peri peri driver is based on SH_DMAE_BASE,
> but, it breaks DMAEngine handling.
>
> I fix-uped this issue on below patch, but it is not yet accepted.
>
> Subject: [PATCH][resend] dmaengine: rcar-audmapp: independent from SH_DMAE_BASE
> Date: Fri, 28 Nov 2014 00:17:59 +0000
>
> Above patches need this order
> [1/2] : dmaengine: rcar-audmapp: independent from SH_DMAE_BASE
> [2/2] : ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
>
> It seems that I2C driver is broken by this patch.
> I will re-send it if missing DMAEngine patch was accepted.
Hi Morimoto-san,
I believe this patch is not present in v3.18 (good) but has been accepted
by the ARM SoC maintainers for v3.19 (not so good). In other words its
present in arm-soc/for-next and linux-next but not Linus's tree
(but may be soon).
Would you like me to submit a reversion of a fix-for-v3.19 to the ARM SoC
maintainers?
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
2014-10-31 0:27 [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig Kuninori Morimoto
2014-12-08 4:37 ` Kuninori Morimoto
2014-12-09 0:20 ` Simon Horman
@ 2014-12-10 0:58 ` Kuninori Morimoto
2014-12-10 2:41 ` Simon Horman
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2014-12-10 0:58 UTC (permalink / raw)
To: linux-sh
Hi Simon
> > Is it possible to revert this patch from defconfig ?
> > Current upstreamed Audio DMAC peri peri driver is based on SH_DMAE_BASE,
> > but, it breaks DMAEngine handling.
> >
> > I fix-uped this issue on below patch, but it is not yet accepted.
> >
> > Subject: [PATCH][resend] dmaengine: rcar-audmapp: independent from SH_DMAE_BASE
> > Date: Fri, 28 Nov 2014 00:17:59 +0000
> >
> > Above patches need this order
> > [1/2] : dmaengine: rcar-audmapp: independent from SH_DMAE_BASE
> > [2/2] : ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
> >
> > It seems that I2C driver is broken by this patch.
> > I will re-send it if missing DMAEngine patch was accepted.
>
> Hi Morimoto-san,
>
> I believe this patch is not present in v3.18 (good) but has been accepted
> by the ARM SoC maintainers for v3.19 (not so good). In other words its
> present in arm-soc/for-next and linux-next but not Linus's tree
> (but may be soon).
>
> Would you like me to submit a reversion of a fix-for-v3.19 to the ARM SoC
> maintainers?
Thank you for your help
It depends on RCAR-DMAC enable/disable and driver (which want to use DMAEngine).
But, unfortunately, reverting it from v3.19 is very safety.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
2014-10-31 0:27 [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig Kuninori Morimoto
` (2 preceding siblings ...)
2014-12-10 0:58 ` Kuninori Morimoto
@ 2014-12-10 2:41 ` Simon Horman
2014-12-10 3:51 ` Kuninori Morimoto
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2014-12-10 2:41 UTC (permalink / raw)
To: linux-sh
On Wed, Dec 10, 2014 at 12:58:42AM +0000, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > Is it possible to revert this patch from defconfig ?
> > > Current upstreamed Audio DMAC peri peri driver is based on SH_DMAE_BASE,
> > > but, it breaks DMAEngine handling.
> > >
> > > I fix-uped this issue on below patch, but it is not yet accepted.
> > >
> > > Subject: [PATCH][resend] dmaengine: rcar-audmapp: independent from SH_DMAE_BASE
> > > Date: Fri, 28 Nov 2014 00:17:59 +0000
> > >
> > > Above patches need this order
> > > [1/2] : dmaengine: rcar-audmapp: independent from SH_DMAE_BASE
> > > [2/2] : ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
> > >
> > > It seems that I2C driver is broken by this patch.
> > > I will re-send it if missing DMAEngine patch was accepted.
> >
> > Hi Morimoto-san,
> >
> > I believe this patch is not present in v3.18 (good) but has been accepted
> > by the ARM SoC maintainers for v3.19 (not so good). In other words its
> > present in arm-soc/for-next and linux-next but not Linus's tree
> > (but may be soon).
> >
> > Would you like me to submit a reversion of a fix-for-v3.19 to the ARM SoC
> > maintainers?
>
> Thank you for your help
> It depends on RCAR-DMAC enable/disable and driver (which want to use DMAEngine).
> But, unfortunately, reverting it from v3.19 is very safety.
Thanks, I think I understand.
I plan to queue-up the following:
From: Simon Horman <horms+renesas@verge.net.au>
[PATCH] Revert "ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig"
This reverts commit 2315f9fce4da7df9362e4baeb5250d14ea48bf63.
Unfortunately enabling RCAR_AUDMAC_PP support this patch breaks dmaengine
support on R-Car Gen2 boards. This should be resolved by driver updates
in v3.20. But v3.19 was too early for this defconfig change.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/configs/shmobile_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index cc67508..302faab 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -147,7 +147,6 @@ CONFIG_RTC_CLASS=y
CONFIG_RTC_DRV_S35390A=y
CONFIG_DMADEVICES=y
CONFIG_SH_DMAE=y
-CONFIG_RCAR_AUDMAC_PP=y
CONFIG_RCAR_DMAC=y
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_PWM=y
--
2.1.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
2014-10-31 0:27 [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig Kuninori Morimoto
` (3 preceding siblings ...)
2014-12-10 2:41 ` Simon Horman
@ 2014-12-10 3:51 ` Kuninori Morimoto
2014-12-11 3:23 ` Simon Horman
2014-12-11 3:40 ` Kuninori Morimoto
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2014-12-10 3:51 UTC (permalink / raw)
To: linux-sh
Hi Simon
> > Thank you for your help
> > It depends on RCAR-DMAC enable/disable and driver (which want to use DMAEngine).
> > But, unfortunately, reverting it from v3.19 is very safety.
>
> Thanks, I think I understand.
>
> I plan to queue-up the following:
>
> From: Simon Horman <horms+renesas@verge.net.au>
>
> [PATCH] Revert "ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig"
>
> This reverts commit 2315f9fce4da7df9362e4baeb5250d14ea48bf63.
>
> Unfortunately enabling RCAR_AUDMAC_PP support this patch breaks dmaengine
> support on R-Car Gen2 boards. This should be resolved by driver updates
> in v3.20. But v3.19 was too early for this defconfig change.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
Thank you.
I will re-send this patch if all are OK
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
2014-10-31 0:27 [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig Kuninori Morimoto
` (4 preceding siblings ...)
2014-12-10 3:51 ` Kuninori Morimoto
@ 2014-12-11 3:23 ` Simon Horman
2014-12-11 3:40 ` Kuninori Morimoto
6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2014-12-11 3:23 UTC (permalink / raw)
To: linux-sh
On Wed, Dec 10, 2014 at 03:51:59AM +0000, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > Thank you for your help
> > > It depends on RCAR-DMAC enable/disable and driver (which want to use DMAEngine).
> > > But, unfortunately, reverting it from v3.19 is very safety.
> >
> > Thanks, I think I understand.
> >
> > I plan to queue-up the following:
> >
> > From: Simon Horman <horms+renesas@verge.net.au>
> >
> > [PATCH] Revert "ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig"
> >
> > This reverts commit 2315f9fce4da7df9362e4baeb5250d14ea48bf63.
> >
> > Unfortunately enabling RCAR_AUDMAC_PP support this patch breaks dmaengine
> > support on R-Car Gen2 boards. This should be resolved by driver updates
> > in v3.20. But v3.19 was too early for this defconfig change.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
>
> Thank you.
> I will re-send this patch if all are OK
Thanks, please do.
I have sent a pull-request for the reversion above.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
2014-10-31 0:27 [PATCH 11/12 v2] ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig Kuninori Morimoto
` (5 preceding siblings ...)
2014-12-11 3:23 ` Simon Horman
@ 2014-12-11 3:40 ` Kuninori Morimoto
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2014-12-11 3:40 UTC (permalink / raw)
To: linux-sh
Hi Simon
> > Thank you.
> > I will re-send this patch if all are OK
>
> Thanks, please do.
>
> I have sent a pull-request for the reversion above.
Thank you
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 8+ messages in thread