[PATCH v2 0/7] ARM: shmobile: ape6evm: multiplatform support

[PATCH v2 0/7] ARM: shmobile: ape6evm: multiplatform support

[Ulrich Hecht]

Hi!

This series implements multiplatform support for the APE6EVM board, and
eliminates both legacy platforms.

This version incorporates the "ARM: shmobile: ape6evm-reference: add missing
devices" series.  As suggested by Magnus, it synchronizes the ape6evm and
ape6evm-reference dts files first, eliminating the big renaming at the end.

It is split in such a way that the first five patches can be merged without
breaking either of the two legacy platforms.  Simon, please pick those up. 
(Or the first three, if adding a multiplatform target that does not build is
a problem.) Thank you.

CU
Uli


Changes since v1:
- merged with "ARM: shmobile: ape6evm-reference: add missing devices"
- resequenced for merging without CCF support
- removed a few leftover Kconfig and Makefile targets
- added Acked-Bys


Ulrich Hecht (7):
  ARM: shmobile: ape6evm: synchronize dts with reference platform
  ARM: shmobile: ape6evm: Add LEDs to the device tree
  ARM: shmobile: ape6evm: Add keypad to the device tree
  ARM: shmobile: r8a73a4: Multiplatform support
  ARM: shmobile: r8a73a4: Add r8a73a4-ape6evm.dtb to ARCH_SHMOBILE_MULTI
  ARM: shmobile: ape6evm-reference: Remove board C code and DT file
  ARM: shmobile: r8a73a4: ape6evm: remove legacy platform

 arch/arm/boot/dts/Makefile                       |   3 +-
 arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts  | 156 -------------
 arch/arm/boot/dts/r8a73a4-ape6evm.dts            | 163 ++++++++++++-
 arch/arm/mach-shmobile/Kconfig                   |  30 +--
 arch/arm/mach-shmobile/Makefile                  |   2 -
 arch/arm/mach-shmobile/Makefile.boot             |   2 -
 arch/arm/mach-shmobile/board-ape6evm-reference.c |  61 -----
 arch/arm/mach-shmobile/board-ape6evm.c           | 286 -----------------------
 8 files changed, 166 insertions(+), 537 deletions(-)
 delete mode 100644 arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts
 delete mode 100644 arch/arm/mach-shmobile/board-ape6evm-reference.c
 delete mode 100644 arch/arm/mach-shmobile/board-ape6evm.c

-- 
1.8.4.5

Re: [PATCH v2 0/7] ARM: shmobile: ape6evm: multiplatform support

[Magnus Damm]

Hi Ulrich and Simon,

On Wed, Dec 17, 2014 at 1:25 AM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Hi!
>
> This series implements multiplatform support for the APE6EVM board, and
> eliminates both legacy platforms.
>
> This version incorporates the "ARM: shmobile: ape6evm-reference: add missing
> devices" series.  As suggested by Magnus, it synchronizes the ape6evm and
> ape6evm-reference dts files first, eliminating the big renaming at the end.

Thanks for resending following this style. It is easy to understand -
at least for me!

> It is split in such a way that the first five patches can be merged without
> breaking either of the two legacy platforms.  Simon, please pick those up.
> (Or the first three, if adding a multiplatform target that does not build is
> a problem.) Thank you.

The first patch seems to have some issue reported by Laurent. It needs
to be reworked.

Patch 2-5 should be possible to merge as-is unless I'm mistaken.

Simon, if you don't mind, can you please consider picking up 2-5 before 1, 6-7?

As for patch 6-7 and the sh73a4 legacy removal code by Laurent, I
think the main blocker there is the r8a73a4 CCF support patch. I don't
want to remove legacy code before reference is at least half-complete.

How can we move forward on the r8a73a4 CCF bits?

Cheers,

/ magnus

Re: [PATCH v2 0/7] ARM: shmobile: ape6evm: multiplatform support

[Simon Horman]

On Wed, Dec 17, 2014 at 10:23:39AM +0900, Magnus Damm wrote:
> Hi Ulrich and Simon,
> 
> On Wed, Dec 17, 2014 at 1:25 AM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
> > Hi!
> >
> > This series implements multiplatform support for the APE6EVM board, and
> > eliminates both legacy platforms.
> >
> > This version incorporates the "ARM: shmobile: ape6evm-reference: add missing
> > devices" series.  As suggested by Magnus, it synchronizes the ape6evm and
> > ape6evm-reference dts files first, eliminating the big renaming at the end.
> 
> Thanks for resending following this style. It is easy to understand -
> at least for me!
> 
> > It is split in such a way that the first five patches can be merged without
> > breaking either of the two legacy platforms.  Simon, please pick those up.
> > (Or the first three, if adding a multiplatform target that does not build is
> > a problem.) Thank you.
> 
> The first patch seems to have some issue reported by Laurent. It needs
> to be reworked.
> 
> Patch 2-5 should be possible to merge as-is unless I'm mistaken.
> 
> Simon, if you don't mind, can you please consider picking up 2-5 before 1, 6-7?

Sure, that looks like it should work out.
I'll see about making it so and get back to you accordingly.

> 
> As for patch 6-7 and the sh73a4 legacy removal code by Laurent, I
> think the main blocker there is the r8a73a4 CCF support patch. I don't
> want to remove legacy code before reference is at least half-complete.
> 
> How can we move forward on the r8a73a4 CCF bits?
> 
> Cheers,
> 
> / magnus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH v2 0/7] ARM: shmobile: ape6evm: multiplatform support

[Ulrich Hecht]

On Wed, Dec 17, 2014 at 2:23 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> Hi Ulrich and Simon,
>
> On Wed, Dec 17, 2014 at 1:25 AM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
>> It is split in such a way that the first five patches can be merged without
>> breaking either of the two legacy platforms.  Simon, please pick those up.
>> (Or the first three, if adding a multiplatform target that does not build is
>> a problem.) Thank you.
>
> The first patch seems to have some issue reported by Laurent. It needs
> to be reworked.
>
> Patch 2-5 should be possible to merge as-is unless I'm mistaken.
>
> Simon, if you don't mind, can you please consider picking up 2-5 before 1, 6-7?

I respun the series following Laurent's suggestions, there should be
no need for special-casing anymore.

> As for patch 6-7 and the sh73a4 legacy removal code by Laurent, I
> think the main blocker there is the r8a73a4 CCF support patch. I don't
> want to remove legacy code before reference is at least half-complete.
>
> How can we move forward on the r8a73a4 CCF bits?

For starters I have sent a new version of the series with the last
remaining trivialities fixed.

CU
Uli

Re: [PATCH v2 0/7] ARM: shmobile: ape6evm: multiplatform support

[Simon Horman]

On Wed, Dec 17, 2014 at 05:20:15PM +0100, Ulrich Hecht wrote:
> On Wed, Dec 17, 2014 at 2:23 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > Hi Ulrich and Simon,
> >
> > On Wed, Dec 17, 2014 at 1:25 AM, Ulrich Hecht
> > <ulrich.hecht+renesas@gmail.com> wrote:
> >> It is split in such a way that the first five patches can be merged without
> >> breaking either of the two legacy platforms.  Simon, please pick those up.
> >> (Or the first three, if adding a multiplatform target that does not build is
> >> a problem.) Thank you.
> >
> > The first patch seems to have some issue reported by Laurent. It needs
> > to be reworked.
> >
> > Patch 2-5 should be possible to merge as-is unless I'm mistaken.
> >
> > Simon, if you don't mind, can you please consider picking up 2-5 before 1, 6-7?
> 
> I respun the series following Laurent's suggestions, there should be
> no need for special-casing anymore.
> 
> > As for patch 6-7 and the sh73a4 legacy removal code by Laurent, I
> > think the main blocker there is the r8a73a4 CCF support patch. I don't
> > want to remove legacy code before reference is at least half-complete.
> >
> > How can we move forward on the r8a73a4 CCF bits?
> 
> For starters I have sent a new version of the series with the last
> remaining trivialities fixed.

Thanks, that seems clean to me. And I see that Laurent has Acked the
changes. I will queue those up.

Re: [PATCH v2 0/7] ARM: shmobile: ape6evm: multiplatform support

[Magnus Damm]

Hi Simon,

On Thu, Dec 18, 2014 at 9:19 AM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Dec 17, 2014 at 05:20:15PM +0100, Ulrich Hecht wrote:
>> On Wed, Dec 17, 2014 at 2:23 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> > Hi Ulrich and Simon,
>> >
>> > On Wed, Dec 17, 2014 at 1:25 AM, Ulrich Hecht
>> > <ulrich.hecht+renesas@gmail.com> wrote:
>> >> It is split in such a way that the first five patches can be merged without
>> >> breaking either of the two legacy platforms.  Simon, please pick those up.
>> >> (Or the first three, if adding a multiplatform target that does not build is
>> >> a problem.) Thank you.
>> >
>> > The first patch seems to have some issue reported by Laurent. It needs
>> > to be reworked.
>> >
>> > Patch 2-5 should be possible to merge as-is unless I'm mistaken.
>> >
>> > Simon, if you don't mind, can you please consider picking up 2-5 before 1, 6-7?
>>
>> I respun the series following Laurent's suggestions, there should be
>> no need for special-casing anymore.
>>
>> > As for patch 6-7 and the sh73a4 legacy removal code by Laurent, I
>> > think the main blocker there is the r8a73a4 CCF support patch. I don't
>> > want to remove legacy code before reference is at least half-complete.
>> >
>> > How can we move forward on the r8a73a4 CCF bits?
>>
>> For starters I have sent a new version of the series with the last
>> remaining trivialities fixed.
>
> Thanks, that seems clean to me. And I see that Laurent has Acked the
> changes. I will queue those up.

Thanks. I assume you guys work out the CCF vs the shmobile ordering
and keep at least one DT-reference implementation working at any given
time.

Cheers,

/ magnus

Re: [PATCH v2 0/7] ARM: shmobile: ape6evm: multiplatform support

[Simon Horman]

On Thu, Dec 18, 2014 at 10:22:00AM +0900, Magnus Damm wrote:
> Hi Simon,
> 
> On Thu, Dec 18, 2014 at 9:19 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Dec 17, 2014 at 05:20:15PM +0100, Ulrich Hecht wrote:
> >> On Wed, Dec 17, 2014 at 2:23 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> >> > Hi Ulrich and Simon,
> >> >
> >> > On Wed, Dec 17, 2014 at 1:25 AM, Ulrich Hecht
> >> > <ulrich.hecht+renesas@gmail.com> wrote:
> >> >> It is split in such a way that the first five patches can be merged without
> >> >> breaking either of the two legacy platforms.  Simon, please pick those up.
> >> >> (Or the first three, if adding a multiplatform target that does not build is
> >> >> a problem.) Thank you.
> >> >
> >> > The first patch seems to have some issue reported by Laurent. It needs
> >> > to be reworked.
> >> >
> >> > Patch 2-5 should be possible to merge as-is unless I'm mistaken.
> >> >
> >> > Simon, if you don't mind, can you please consider picking up 2-5 before 1, 6-7?
> >>
> >> I respun the series following Laurent's suggestions, there should be
> >> no need for special-casing anymore.
> >>
> >> > As for patch 6-7 and the sh73a4 legacy removal code by Laurent, I
> >> > think the main blocker there is the r8a73a4 CCF support patch. I don't
> >> > want to remove legacy code before reference is at least half-complete.
> >> >
> >> > How can we move forward on the r8a73a4 CCF bits?
> >>
> >> For starters I have sent a new version of the series with the last
> >> remaining trivialities fixed.
> >
> > Thanks, that seems clean to me. And I see that Laurent has Acked the
> > changes. I will queue those up.
> 
> Thanks. I assume you guys work out the CCF vs the shmobile ordering
> and keep at least one DT-reference implementation working at any given
> time.

Yes, that is the assumption that I am working on.

Re: [PATCH v2 0/7] ARM: shmobile: ape6evm: multiplatform support

[Magnus Damm]

Hi Simon,

On Thu, Dec 18, 2014 at 10:25 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Dec 18, 2014 at 10:22:00AM +0900, Magnus Damm wrote:
>> Hi Simon,
>>
>> On Thu, Dec 18, 2014 at 9:19 AM, Simon Horman <horms@verge.net.au> wrote:
>> > On Wed, Dec 17, 2014 at 05:20:15PM +0100, Ulrich Hecht wrote:
>> >> On Wed, Dec 17, 2014 at 2:23 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> >> > Hi Ulrich and Simon,
>> >> >
>> >> > On Wed, Dec 17, 2014 at 1:25 AM, Ulrich Hecht
>> >> > <ulrich.hecht+renesas@gmail.com> wrote:
>> >> >> It is split in such a way that the first five patches can be merged without
>> >> >> breaking either of the two legacy platforms.  Simon, please pick those up.
>> >> >> (Or the first three, if adding a multiplatform target that does not build is
>> >> >> a problem.) Thank you.
>> >> >
>> >> > The first patch seems to have some issue reported by Laurent. It needs
>> >> > to be reworked.
>> >> >
>> >> > Patch 2-5 should be possible to merge as-is unless I'm mistaken.
>> >> >
>> >> > Simon, if you don't mind, can you please consider picking up 2-5 before 1, 6-7?
>> >>
>> >> I respun the series following Laurent's suggestions, there should be
>> >> no need for special-casing anymore.
>> >>
>> >> > As for patch 6-7 and the sh73a4 legacy removal code by Laurent, I
>> >> > think the main blocker there is the r8a73a4 CCF support patch. I don't
>> >> > want to remove legacy code before reference is at least half-complete.
>> >> >
>> >> > How can we move forward on the r8a73a4 CCF bits?
>> >>
>> >> For starters I have sent a new version of the series with the last
>> >> remaining trivialities fixed.
>> >
>> > Thanks, that seems clean to me. And I see that Laurent has Acked the
>> > changes. I will queue those up.
>>
>> Thanks. I assume you guys work out the CCF vs the shmobile ordering
>> and keep at least one DT-reference implementation working at any given
>> time.
>
> Yes, that is the assumption that I am working on.

Great, thank you!

/ magnus